Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17934325rwd; Tue, 27 Jun 2023 09:17:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ529bsVWbLwaUe/hTyUhnDbSzXYYSAr+am0xV/eWNCobCGjUKSvESBwmI87FAg3lWxgk+rm X-Received: by 2002:a05:6402:447:b0:51d:a49b:aa40 with SMTP id p7-20020a056402044700b0051da49baa40mr2500401edw.38.1687882667841; Tue, 27 Jun 2023 09:17:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687882667; cv=none; d=google.com; s=arc-20160816; b=iEIBsue5Bf6DoVX3MI+x/Saasum9MKucn7/sWTJkzqxsZa4uGuqbHrG0/CJXVDazt5 tsRd5nsawiHKX348pmfw4qzxqufjmH+8KNhd5CyvtZRPnJfK7zAc6cLe/HFnwgCrAEBb sideEH+/LBe4D/oRMFBHUhoRo0S8o9AQVe+diCf2JIoZzAQqlXu1pHNcxAuzDHFyp51J MNqEcLGTGecPzOs5QdeXFdQSxoNQb4seq4XRQv3kSySMo9rCf1wOGpq2xmasAb02tu4U n8YGfz7VZvzLyMed+Eevcv9l2mR2qNy7l/T2P4fsSeqikgU98+JuhdsoxIYjJqlZc3Nm w0eQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=F0YkNdNP4x/79Jg/HNWkUQMe3owuqwhhtLuSc41VQ5Y=; fh=cwluaEeye23flsG5i4pBGGVbmZ4pGZCW+qGcLpGyyeE=; b=XkX1bbkqLUOCl3F4H/PSawdtmJ4qFV0owFRAhHflgCAfojZ8xQNQm7tqGaAFFL6yeq iLlpMcrgHsqkWVxkaC3AJqnLr2KXuC0OGt+6u2zYFxcjzpYkNqZGhCBRTtlykpSUTL3s Tn3gYLOkbXhRsW7LWGZ8Z2v8+vumfbdWl42EN1RKHNtn6o9+JXN4quukqOrPr+54svOg VJa0wSuZf3ADUprAZVao89PhdEtLo2eRezmFbgzJbqzwH9VshH02nnIufNY0ZVi9Otxv 2e+tyxdUYcsRf4EEcvi2pwomiz9GqzOcMoCyoxX1UVSv9992Xxwqt7JAbzzYb8krsbrH 7aVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qoGyPe5V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u8-20020a05640207c800b0051a5ae39797si4313412edy.641.2023.06.27.09.17.21; Tue, 27 Jun 2023 09:17:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qoGyPe5V; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231834AbjF0Pw4 (ORCPT + 99 others); Tue, 27 Jun 2023 11:52:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbjF0Pwz (ORCPT ); Tue, 27 Jun 2023 11:52:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56199297D; Tue, 27 Jun 2023 08:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=F0YkNdNP4x/79Jg/HNWkUQMe3owuqwhhtLuSc41VQ5Y=; b=qoGyPe5VPadHN0hptR04XWwCM+ VpQ+9KpV91do6qeKZRjuFlELUhr25Kcv/oA5ru6SB18GxM4BIxx5VrB4f2N9hDjOEj2y4VaUHQ/XG r8P7bfLGbEGcK7mH8Xo1ynQBshg1xClg1EKFocDXNf5KiH9xCIuXEWA1aPMy932Tl+uZHX5Z6cvcS 8K983SPFd/e8hawOFSQq5K2boxKAhSF/8G6dN2616V16b7pfokpgNOBbq6e5mIsc1mF0AM1H03oGe y2CL94aOrZwN9kWf9mc9oqxLefbetxwb1ZZGfrsLQAUS4FdbeGZB2FAazn4cl2nYdZYqR5dA3CsPw nRErmeRA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEAzq-00DZba-1O; Tue, 27 Jun 2023 15:52:50 +0000 Date: Tue, 27 Jun 2023 08:52:50 -0700 From: Christoph Hellwig To: Lu Hongfei Cc: Christoph Hellwig , "Darrick J. Wong" , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] fs: iomap: Change the type of blocksize from 'int' to 'unsigned int' in iomap_file_buffered_write_punch_delalloc Message-ID: References: <20230627100325.51290-1-luhongfei@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230627100325.51290-1-luhongfei@vivo.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 06:03:25PM +0800, Lu Hongfei wrote: > loff_t start_byte; > loff_t end_byte; > - int blocksize = i_blocksize(inode); > + unsigned int blocksize = i_blocksize(inode); Please keep the existing alignment of the variable names. With that the patch looks good: Reviewed-by: Christoph Hellwig