Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp17980899rwd; Tue, 27 Jun 2023 09:56:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6zhFE0gbf8uoksdkwOdiaL0NKFkb5yk+RP3IRrKhuNsF7ddqzwJCjavXfMMEERam+M+IaW X-Received: by 2002:a05:6a20:7d95:b0:126:676f:1f1c with SMTP id v21-20020a056a207d9500b00126676f1f1cmr13420377pzj.28.1687884992550; Tue, 27 Jun 2023 09:56:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687884992; cv=none; d=google.com; s=arc-20160816; b=BcWYDwsGV1INoNO8xvtZ1L3ncjwgdCy2CjZvewzsMb9VvhqJKO8Abjh5fnGoExnGIG bKl/2hoAw33Ws7xXjqxrYBt0JmgVzXPViH8w0FsFd4cGB5p0C5pwfSnAuTbC0+484noE JxCdFllCByWp6OTazFqpR657a+c3WtDIJYMlnTiO7qq5OgeIhxRLDmrvDMJod6VRtM2a MXeemmcFCV7qk9ExaSPswLoO4FGDuUNlT3IS5W8RQnBbsCEiurg1XVY7lV/SkLrmEumY MS5yFphq28vYTTqbtL5rp6x+kb2j2XAIVhxrYBtxXbYZZZrvTl+84J+ylGrpbIOPLxNn prkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; fh=AqulJRHISBOAIcIpbI+DW0fnVYrI/ky+Zsza1VlaGkM=; b=okRjT1kS/A7nf3RKrDXBFiemBSi3e7vc7Z+w1XAWEcGGF3P+IcBoWMFd8Js+BmmRMe DsKtmLvxiSxCBRFLPEZ5QNlD3KX36zDcJGhZY0fJrNGSKjyXzfXedDR/C6KhPQzcIC9l wUgP0pDD4e3vS/bZfNPyiWx8E05UGYvhtNtx1wHPJSvOE+w6IT4QsMha2ighaUxHy14a fG6asWEstS90+81VWib3jOAA2oHHH/M3Xo3fyE4wfg7FcLvrM36aLjj7rZnyIrviFTM4 ppaeWwWirTDOw4Gl+76aN9xvZXwlXdYg51DlowIvtA7wBTEtPcQ0p15zdaljOcpwLirf Ac7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=itTKOTQ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c5-20020a6566c5000000b0055acfb661c0si5533666pgw.524.2023.06.27.09.56.19; Tue, 27 Jun 2023 09:56:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=itTKOTQ8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232478AbjF0Q2i (ORCPT + 99 others); Tue, 27 Jun 2023 12:28:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47810 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230058AbjF0Q2W (ORCPT ); Tue, 27 Jun 2023 12:28:22 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EDC935B1 for ; Tue, 27 Jun 2023 09:27:39 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id 46e09a7af769-6b13e2af122so3712096a34.2 for ; Tue, 27 Jun 2023 09:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687883238; x=1690475238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; b=itTKOTQ86SntEjnwzI4JoX0BexZJ1pu/XpytRxK4zPckna0jMVyksw9xu+EJszLZeP 8uFIG0vTobqWN5ctzM/QeA/zhhBpfP8gK7w4NzNLu21ddFYzQd5uCJdZLIkHRhDjsPEt cS6icMdVzW99rSPmL/p3rwoFz4jR+q2+SnMdZVLC6e712lumkhlu36B+3aINvRmEV8H3 iPdVy1BUeFBDfdR/QZozT86M6pj52wygB6XXH+6+jFI2kelNI3P10IjmAvJtMlLstYA+ 90GTZKwcFW30u72Q7hXfvi0YvmHa6e7Ovz5y4CwphiczY10m7mo2NMV22k3w/QjhePPk 1H8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687883238; x=1690475238; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pJFRdvLZEJUWCkL2EK4nO+CExAHFvCuxR6yO/np/Csg=; b=WAKi8FxSp9lID64HY2Py809RaV6YNJ2etbU2WGX0hQnVe/masvy99qLkKmCjv1rvQn zHy0zZFqrRi28wUTLxgpl4wnS56uYWOEq3o1HSIczFkOn6hPmLmbobpt4awC6r4RST6L k6A3zvm/zAnGgtQxBXeDEr86Twyt2SR2mwMDHN2ONLLrA0pK/Mb7mgin/aV0y/bpJyxY nO68VflVKs+eTVKpXmiC7lF3bFZs60lGDGt5/TiI50qC7vWE9UKiliWHef3XTtvZ6WFJ 3CcOxuzpdnfceDerzF2Bq5sAzBtQTpnRobzuX6hds8Uc6gbFD4+Wcgaam80tb2P8fNN+ AsJw== X-Gm-Message-State: AC+VfDw6ceUfYjUvgeWqfYoaF8Y5xMhOXPdGfDkkswQR/Ln6luBxHkTs bC4L/yfDmvW+mtTLitCEu3XLyAZ6mJ1u1c4oesmYXg== X-Received: by 2002:a9d:7510:0:b0:6b7:397a:6342 with SMTP id r16-20020a9d7510000000b006b7397a6342mr7691290otk.16.1687883237932; Tue, 27 Jun 2023 09:27:17 -0700 (PDT) MIME-Version: 1.0 References: <20230627042321.1763765-1-surenb@google.com> <20230627042321.1763765-5-surenb@google.com> In-Reply-To: From: Suren Baghdasaryan Date: Tue, 27 Jun 2023 09:27:07 -0700 Message-ID: Subject: Re: [PATCH v3 4/8] mm: replace folio_lock_or_retry with folio_lock_fault To: Peter Xu Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 8:22=E2=80=AFAM Peter Xu wrote: > > On Mon, Jun 26, 2023 at 09:23:17PM -0700, Suren Baghdasaryan wrote: > > Change folio_lock_or_retry to accept vm_fault struct and return the > > vm_fault_t directly. This will be used later to return additional > > information about the state of the mmap_lock upon return from this > > function. > > > > Suggested-by: Matthew Wilcox > > Signed-off-by: Suren Baghdasaryan > > The patch looks all fine to me except on the renaming.. > > *_fault() makes me think of a fault handler, while *_lock_or_retry() was > there for years and it still sounds better than the new one to me. > > Can we still come up with a better renaming, or just keep the name? I thought about alternatives but could not find anything better. I can keep the old name if that is preferred. > > Thanks, > > -- > Peter Xu > > -- > To unsubscribe from this group and stop receiving emails from it, send an= email to kernel-team+unsubscribe@android.com. >