Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1e081fc1-5d90-f3d4-7429-363dba996ef7@infradead.org>
Date:   Tue, 27 Jun 2023 09:18:35 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH V24 2/3] misc: dcc: Add driver support for Data Capture
 and Compare unit(DCC)
Content-Language: en-US
To:     Souradeep Chowdhury <quic_schowdhu@quicinc.com>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Alex Elder <elder@ieee.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        Sibi Sankar <quic_sibis@quicinc.com>,
        Rajendra Nayak <quic_rjendra@quicinc.com>
References: <cover.1687855361.git.quic_schowdhu@quicinc.com>
 <62bf3d9766bc785cfd0fc8e674ce7f86499a0f5b.1687855361.git.quic_schowdhu@quicinc.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <62bf3d9766bc785cfd0fc8e674ce7f86499a0f5b.1687855361.git.quic_schowdhu@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 6/27/23 02:49, Souradeep Chowdhury wrote:
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 433aa4197785..3112dbb15cf4 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -276,6 +276,15 @@ config QCOM_COINCELL
>  	  to maintain PMIC register and RTC state in the absence of
>  	  external power.
> 
> +config QCOM_DCC
> +	tristate "Qualcomm Technologies, Inc. Data Capture and Compare(DCC) engine driver"

	                                                       Compare (DCC)

> +	depends on ARCH_QCOM || COMPILE_TEST
> +	help
> +	  This option enables driver for Data Capture and Compare engine. DCC

	              enables the driver for the                        . The DCC

> +	  driver provides interface to configure DCC block and read back

	         provides interfaces to configure the DCC block and read back

> +	  captured data from DCC's internal SRAM. The module name for this

	                from the DCC's

> +	  is qcom-dcc.ko

We don't usually add the ".ko" here, so just:

	  is qcom-dcc.

thanks.
-- 
~Randy