Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Drew Fustini <dfustini@baylibre.com>
CC:     James Morse <james.morse@arm.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Babu Moger <Babu.Moger@amd.com>,
        Peter Newman <peternewman@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        D Scott Phillips OS <scott@os.amperecomputing.com>,
        "carl@os.amperecomputing.com" <carl@os.amperecomputing.com>,
        "lcherian@marvell.com" <lcherian@marvell.com>,
        "bobo.shaobowang@huawei.com" <bobo.shaobowang@huawei.com>,
        "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>,
        "xingxin.hx@openanolis.org" <xingxin.hx@openanolis.org>,
        "baolin.wang@linux.alibaba.com" <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>,
        "Pitre, Nicolas" <npitre@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        "aricciardi@baylibre.com" <aricciardi@baylibre.com>,
        "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
Subject: RE: [RFC PATCH 0/2] Resctrl - rewrite (WIP)
Thread-Topic: [RFC PATCH 0/2] Resctrl - rewrite (WIP)
Thread-Index: AQHZoyiDuZCsHP7U1EeCATLJj0kK+q+eYGiAgACAUgA=
Date:   Tue, 27 Jun 2023 16:33:52 +0000
Message-ID: <SJ1PR11MB60832BA425B43CA19C778100FC27A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230620033702.33344-1-tony.luck@intel.com> <ZJqhDYLG+/Kr44sp@x1>
In-Reply-To: <ZJqhDYLG+/Kr44sp@x1>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LsI2BdvRdStb9F5GnTaIbz1mm0NegYl1AfXtYJ42izCSfviwHLDAQ2OOkzxs?=
 =?us-ascii?Q?qH0mkbTDh3Ab0xhsMxpeOvL9sEjQ+25p2N4CuejCEhWak40BsimS1oaqXJYz?=
 =?us-ascii?Q?z19uPrvQiEoaax2x7BD//eGSFeC61mduACB8j4r/kfe+rggfF/XK4mqGPtHR?=
 =?us-ascii?Q?CvQjj5KMjlDRvpXOJK6nsZqmyqWGpH95TSgFxq72jRS9Gjq/4L3Esdr72hog?=
 =?us-ascii?Q?jfksbsNrNrwd5T8zNwT/A/o/bZRps+GAZQdI/Uf6JTrKHUAOEGFoFY7p/Ndg?=
 =?us-ascii?Q?MQcgnkIv0+4G1EspYpDSxe03fZUdxLiE7DvJTej3RaciHe41lxfxvM8XnsNw?=
 =?us-ascii?Q?mQJXTZ44cqVJCq4EHYzbtlGNqoCT7w8VWBjawW2ftzUnp8ba03Wt6nScE1kC?=
 =?us-ascii?Q?gDyl+MYv4TnZjxTfsHUvWlVaPaqxYTpTTOYzA8eSRRIasDyan8xFeO7dgcu0?=
 =?us-ascii?Q?XGpzXBFIaj3UWpOIr+o+dNxyeAq7n1bqxotUl3Xwt93U6DOpPxasQItvaPIz?=
 =?us-ascii?Q?GHltApEe8qllSJ4ZvxQUrv9y9qvYdXt82cxRjgKeLZZz24hvbEyER0Vo+3ze?=
 =?us-ascii?Q?H7C48JsAidwUY6Zj86cJUWdnh6vNvTt6Urostb78dQOR8TlPwiy7+QGGhYnb?=
 =?us-ascii?Q?na5alDqdzBfTxnPflWGfBx/b+W5vQO3FOwNHguejtncLwrlDSktH+y9oenhF?=
 =?us-ascii?Q?GooqtU7Fh5kFUREySSRElSsKP/tBtx0WSZMykyEbM1XwqUrDxjHhb+MAbUTe?=
 =?us-ascii?Q?1uYPe2ySN7jq04twLIffuWKG14kBM5hxx2/+Q+hX0nTnVVSXIhIMSh9XN6j1?=
 =?us-ascii?Q?LnzKGOmkJkrmjCIPWfXFs1rspWBQZpdxp1KMmPdVlUaxhWh2lhDzcEThCK5T?=
 =?us-ascii?Q?taoG7E70+oxgjVuuCjgqCpV6EagCemGxPK8pGa8dyVRGB4OMklHT57F3KfPD?=
 =?us-ascii?Q?CpxU5CV5kFTRiSBCVUJdMoVyah7nwS94DKyrhNKmRXPxUXZiDreQ6CnEiX3k?=
 =?us-ascii?Q?bfhISQgDIPbedyBCP6C+X1MSkesSJLt7gaSMe2VsfH166cRX/JKE/ZCeLvtr?=
 =?us-ascii?Q?ULR3TpIrb+MS/dCGnYnpP3B5YloBcorVhUUFxSDH3Y+Su6bDZ86E/p11ocB2?=
 =?us-ascii?Q?KPqpgm1fX6UB5+YeOBcTgZOpOB32J5gL45orLnKJ+f8h+RkQ+f3+PDtdABXM?=
 =?us-ascii?Q?kxbX4bJVIhiZFlP/OjKYHqcXaEA3bs6LxuPounLYKGjcKTTYtzI3keGa/xo8?=
 =?us-ascii?Q?5hHiBRnOqkZCOm4foyR/FbnUrFWsh4SPjtyeuK0/dLCmEX/Ja6GDJFL1vIV6?=
 =?us-ascii?Q?RC0ooC1Owe1SD8VYpFMit7rPdhD93f9ZosPkrGdS0R7l50RWGyyyT5w1wrAF?=
 =?us-ascii?Q?6njVB171+5iNdjlqk2ZvcuHBc216rvSRZZLxfsoxbhs/il1ECte59NvV3vgw?=
 =?us-ascii?Q?LAwGzsNyH7X3/9P9MC5mFuXXmMXttEG27Izjoj2YiPH4uKgDUkwcPyjWS6gT?=
 =?us-ascii?Q?vGxYduGzsyt/CPCFNebL7btYckzVAxQZjWCH6sCN8v7BpYTs1ZLZAESvPKxe?=
 =?us-ascii?Q?1jy6lRw1XHXxbp7o/yk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1388164a-7dcb-4f54-b0b0-08db772c4b4d
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jun 2023 16:33:52.8645
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0GiDNvEjyN0ItfCMb+HcVJJRkmrouIngUGKjIB8WLhyd1ZPmPmk2j4ztUvBND4e//R8O5cmbtDUNmA/Mq7pffg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5701
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>> By itself the core code is useless. Cannot even be built as the
>> controlling Kconfig option "CONFIG_RESCTRL2_FS" must be invoked by
>> a "select" request from architecture specific code that provides
>> the necessary "arch_*()" functions to make everything work.
>
> I would like to try to rebase the RISC-V CBQRI resctrl RFC [1] on top of
> this patch series instead of the mpam snapshot branch [2].

Thanks. That should help shake out any places where I've left in Intel-isms=
, or
my abstraction is insufficient to handle your architecture.

I've made some significant changes since I posted those patches. I pushed
the latest version to:

git://git.kernel.org/pub/scm/linux/kernel/git/aegl/linux.git    resctrl2_v6=
4

> I had a patch in my RFC that added config option RISCV_ISA_SSQOSID which
> selects ARCH_HAS_CPU_RESCTRL and RESCTRL_FS [3]. It seems I would need
> to change that to select CONFIG_RESCTRL2_FS ?

Yes. Just have your architecture CONFIG option select RESCTRL2_FS

> A patch [4] in that RFC adds the "arch_*()" functions in
> arch/riscv/kernel/qos/qos_resctrl.c

Yes. This is an area that may need some tweaking to get the prototypes
for the arch_*() functions right.

I put all the x86 architecture code under fs/resctrl2/arch/x86/ .... mostly
so I can do quick test builds of both the common code and architecture
code with "make fs/resctrl2/" ... maybe in the end-game they should be
under arch/x86 rather than adding arch specific subdirs under generic
top-level directories (though I see a smattering of "x86" directories in
several places.

-Tony