Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 18:55:50 +0200
From:   Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= 
        <nabijaczleweli@nabijaczleweli.xyz>
To:     Amir Goldstein <amir73il@gmail.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jan Kara <jack@suse.cz>,
        Chung-Chiang Cheng <cccheng@synology.com>, ltp@vger.kernel.org
Subject: [PATCH v3 2/3] splice: fsnotify_access(fd)/fsnotify_modify(fd) in
 vmsplice
Message-ID: <4206d7388fdbee87053c9655919096225a461423.1687884031.git.nabijaczleweli@nabijaczleweli.xyz>
References: <CAOQ4uxh7i_s4R9pFJPENALdWGG5-dDhqPLEUXuJqSoHraktFiA@mail.gmail.com>
 <cover.1687884029.git.nabijaczleweli@nabijaczleweli.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cpbjxknbnzpkvej4"
Content-Disposition: inline
In-Reply-To: <cover.1687884029.git.nabijaczleweli@nabijaczleweli.xyz>
User-Agent: NeoMutt/20230517
Precedence: bulk


--cpbjxknbnzpkvej4
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Same logic applies here: this can fill up the pipe and pollers that rely
on getting IN_MODIFY notifications never wake up.

Fixes: 983652c69199 ("splice: report related fsnotify events")
Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs=
3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
Link: https://bugs.debian.org/1039488
Signed-off-by: Ahelenia Ziemia=C5=84ska <nabijaczleweli@nabijaczleweli.xyz>
---
 fs/splice.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/splice.c b/fs/splice.c
index e16f4f032d2f..0eb36e93c030 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -1346,6 +1346,9 @@ static long vmsplice_to_user(struct file *file, struc=
t iov_iter *iter,
 		pipe_unlock(pipe);
 	}
=20
+	if (ret > 0)
+		fsnotify_access(file);
+
 	return ret;
 }
=20
@@ -1375,8 +1378,10 @@ static long vmsplice_to_pipe(struct file *file, stru=
ct iov_iter *iter,
 	if (!ret)
 		ret =3D iter_to_pipe(iter, pipe, buf_flag);
 	pipe_unlock(pipe);
-	if (ret > 0)
+	if (ret > 0) {
 		wakeup_pipe_readers(pipe);
+		fsnotify_modify(file);
+	}
 	return ret;
 }
=20
--=20
2.39.2


--cpbjxknbnzpkvej4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSbFJYACgkQvP0LAY0m
WPGKpg/+P1CWa054iG0eUAuibLGHKkDfKfxiOdTlFq9wnUd6z5Kf3Lu23aL8QjBM
DM2DQ4MRpfsqTtFUFt2GNbR9jfjGpSbBpOB6gm0oIkxc5agoj6q3QrI5U3eaS2tk
LRXYirsceM1eTe3aNnxuiTgH3mbGy11dTsiQQca5B/E1HoHB0w7jkHfRIbPKR7vE
ZGeq33QEZnIDhd/K7LGQtkLHONKI50wyOx4heq9uPsP6kb4AlqLlUgjQ3lQR+Pg0
y0cHK3vkcx2uxLbsJu8bdzym18QZRmUPu47iwoqitrAbVeXy9Yp3qqgZ2nXTwCVd
RzIc8YL4sMoLnV1hC0c/LRQfycQLihkP1+Er0AI3fRoGJ8YoIdiTYUKc7IQSwLgM
trpMMichcXnbJDE9gAUD+6xRws2pD02Au2Op0bh1MD8qyuOQ5Cashx68X1mmsdSV
e1Ph2RQbQo5/tjyoHS/oRB2ng2a5dnYQdomI3VeTjh2rmsksqGPVSB+G1d1xEE8q
DL390ZMnSSyUD56kdxmVcUQiZdVyuDBf/Q3OAB+ZBSEXYUjE/leoZLD1EgPECrxB
LP30SNOsKe1V0no4/rf2IBpyAzCD6Yv0hXi30VF3jobxBnl7jnBUId84oeRKXwbk
BV3ZK70o/4eDqdpxN2uEvViRvp8rCzU17wRD1DzDbnoN4gQ743c=
=DRDx
-----END PGP SIGNATURE-----

--cpbjxknbnzpkvej4--