Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 12:39:29 -0500
From:   Chris Morgan <macroalpha82@gmail.com>
To:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc:     Sebastian Reichel <sre@kernel.org>,
        Maya Matuszczyk <maccraft123mc@gmail.com>,
        Lee Jones <lee@kernel.org>,
        Chris Morgan <macromorgan@hotmail.com>,
        linux-rockchip@lists.infradead.org, stable@vger.kernel.org,
        Sebastian Reichel <sebastian.reichel@collabora.com>,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: rk817: Add missing module alias
Message-ID: <ZJse0Z7OMeh+tuur@wintermute.localhost.fail>
References: <20230612143651.959646-2-frattaroli.nicolas@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230612143651.959646-2-frattaroli.nicolas@gmail.com>
Precedence: bulk

On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
> 
> Add the right MODULE_ALIAS to fix this.
> 

Good catch, thank you.

Reviewed-by: Chris Morgan <macromorgan@hotmail.com>

> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: stable@vger.kernel.org
> Signed-off-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
> ---
>  drivers/power/supply/rk817_charger.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
>  MODULE_AUTHOR("Maya Matuszczyk <maccraft123mc@gmail.com>");
>  MODULE_AUTHOR("Chris Morgan <macromorgan@hotmail.com>");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> -- 
> 2.41.0
>