Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <721575ee-4a48-dab1-eabd-32428c20cc72@alu.unizg.hr>
Date:   Tue, 27 Jun 2023 20:16:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [BUG] btrfs: MAX_LOCKDEP_CHAIN_HLOCKS too low!
From:   Mirsad Goran Todorovac <mirsad.todorovac@alu.unizg.hr>
To:     dsterba@suse.cz
Cc:     linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>
References: <5ce1e20e-019b-373f-f412-31fdb2c2379d@alu.unizg.hr>
 <ffa970c3-6907-023b-c8fb-7438694b24ef@gmx.com>
 <20230627142739.GB16168@twin.jikos.cz>
 <ca3f483e-38fc-786b-d85b-35d543a701a9@alu.unizg.hr>
Content-Language: en-US
In-Reply-To: <ca3f483e-38fc-786b-d85b-35d543a701a9@alu.unizg.hr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/27/23 18:27, Mirsad Goran Todorovac wrote:
> Hi, Qu, David,
> 
> On 6/27/23 16:27, David Sterba wrote:
>> On Tue, Jun 27, 2023 at 08:19:37AM +0800, Qu Wenruo wrote:
>>>
>>> On 2023/6/27 07:40, Mirsad Goran Todorovac wrote:
>>>> Hi,
>>>>
>>>> There is a bug apparently in btrfs file system.
>>>>
>>>> The platform is an assembled box with Ryzen 9 processor and ASRock X670E PG
>>>> Lightning motherboard.
>>>>
>>>> I do not have a reproducer, just kernel log:
>>>>
>>>> Jun 26 20:41:58 defiant kernel: [ 2273.786736] BUG:
>>>> MAX_LOCKDEP_CHAIN_HLOCKS too low!
>>>
>>> This is really what it said.
>>>
>>> The setting is too low for certain workload.
>>>
>>> In fact Fedora is already increasing this value.
>>> If you want lockdep, I guess that's the only way to go.
>>
>> https://btrfs.readthedocs.io/en/latest/dev/Development-notes.html#bug-max-lockdep-chain-hlocks-too-low
>>
>> As the reports will probably keep coming until lockdep changes I'll move
>> the answer to a more user-visible page.
> 
> Thank you for your prompt response. It wasn't obvious from the kernel
> message though which .config setting needs adjustment.
> 
> I am yet unable to tell whether the lockdep setting being too low and
> turning off the locking correctness validator caused the kernel crash, but
> I will know more after restarting the kselftest with the new lockdep
> setting ...

P.S.

I heard it is uncool to answer one's own email, but I have been unable to
reproduce the crash of yesterday without or with pcscd smartcard daemon
in debug mode.

This of course doesn't mean that the LOCKDEP setting was a direct cause
of crash, I believe that findings are inconclusive. (IMHO, correct locking
should work even with locking correctness validator turned off.)

FYI, here are the crash logs, in case it could help improve btrfs:

[1] https://domac.alu.unizg.hr/~mtodorov/linux/crashes/2023-06-27/

Best regards,
Mirsad Todorovac