Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 23:55:57 +0530
From:   Deepak R Varma <drv@mailo.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc:     Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
        Ira Weiny <ira.weiny@intel.com>,
        Sumitra Sharma <sumitraartsy@gmail.com>
Subject: Re: [PATCH] gfs2: Replace deprecated kmap_atomic() by
 kmap_local_page()
Message-ID: <ZJsptSAVHroP5hDk@bu2204.myguest.virtualbox.org>
References: <ZJiUKeVy7G6ZkX80@bu2204.myguest.virtualbox.org>
 <1905283.taCxCBeP46@suse>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1905283.taCxCBeP46@suse>
Precedence: bulk

On Tue, Jun 27, 2023 at 01:11:46PM +0200, Fabio M. De Francesco wrote:
> On domenica 25 giugno 2023 21:23:21 CEST Deepak R Varma wrote:
> > kmap_atomic() is deprecated in favor of kmap_local_{folio,page}().
> > 
> >  		}
> > -		p = kmap_atomic(page);
> > +		p = kmap_local_page(page);
> >  		amt = size - copied;
> >  		if (offset + size > PAGE_SIZE)
> >  			amt = PAGE_SIZE - offset;
> >  		memcpy(buf + copied, p + offset, amt);
> 
> How about using memcpy_from_page()? 

We can do that. I will include that in v3.

Deepak.

> 
> Fabio
> 
> > -		kunmap_atomic(p);
> > +		kunmap_local(p);
> >  		put_page(page);
> >  		copied += amt;
> >  		index++;
> > --
> > 2.34.1
> 
> 
> 
>