Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\))
Subject: Re: support pmsg record size larger than kmalloc limitation
From:   Yuxiao Zhang <yuxiaozh.zhang@gmail.com>
In-Reply-To: <2023062702-frosty-winking-9257@gregkh>
Date:   Tue, 27 Jun 2023 13:28:11 -0700
Cc:     Yuxiao Zhang <yuxiaozhang@google.com>, keescook@chromium.org,
        tony.luck@intel.com, gpiccoli@igalia.com,
        linux-hardening@vger.kernel.org,
        William Kennington <wak@google.com>,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <D4435632-785B-43AC-AE21-EC9797458F42@gmail.com>
References: <CAOOoKeQ=b4u1C_FZ-OFHSfVt5Z9xw1KtpJ4316zubt46Tny41Q@mail.gmail.com>
 <2023062715-eldercare-washed-3c29@gregkh>
 <CAOOoKeSxJzJEwX2aVsn_jcqK7gsgEVpB3VdhoKjJPCJgdNf9Mg@mail.gmail.com>
 <2023062702-frosty-winking-9257@gregkh>
To:     Greg KH <gregkh@linuxfoundation.org>
Precedence: bulk

Thanks for the pointer, the document is very helpful. Seems that I =
cannot use gmail to send patches. I sent it again by git send-email. I =
also tested myself that the patch is well-formatted. Hopefully this time =
it works.

> On Jun 27, 2023, at 10:35 AM, Greg KH <gregkh@linuxfoundation.org> =
wrote:
>=20
> On Tue, Jun 27, 2023 at 10:05:04AM -0700, Yuxiao Zhang wrote:
>>  kfree(record->priv);
>>  kfree(record);
>>  if (rc !=3D -EEXIST || !quiet)
>> diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c
>> index ade66dbe5f39..296465b14fa9 100644
>> --- a/fs/pstore/ram.c
>> +++ b/fs/pstore/ram.c
>> @@ -20,6 +20,7 @@
>> #include <linux/compiler.h>
>> #include <linux/of.h>
>> #include <linux/of_address.h>
>> +#include <linux/mm.h>
>>=20
>> #include "internal.h"
>> #include "ram_internal.h"
>> @@ -268,7 +269,7 @@ static ssize_t ramoops_pstore_read(struct
>> pstore_record *record)
>>  /* ECC correction notice */
>>  record->ecc_notice_size =3D persistent_ram_ecc_string(prz, NULL, 0);
>>=20
>> - record->buf =3D kmalloc(size + record->ecc_notice_size + 1, =
GFP_KERNEL);
>> + record->buf =3D kvmalloc(size + record->ecc_notice_size + 1, =
GFP_KERNEL);
>>  if (record->buf =3D=3D NULL) {
>>  size =3D -ENOMEM;
>>  goto out;
>=20
> Please try emailing a patch to yourself and see if you can apply it
> afterwards.  The kernel documentation has a section for how to handle
> email clients, perhaps you should read it?
>=20
> thanks,
>=20
> greg k-h