Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 22:51:04 +0200
From:   Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= 
        <nabijaczleweli@nabijaczleweli.xyz>
To:     Amir Goldstein <amir73il@gmail.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jan Kara <jack@suse.cz>,
        Chung-Chiang Cheng <cccheng@synology.com>, ltp@lists.linux.it
Subject: [PATCH v4 3/3] splice: fsnotify_access(in), fsnotify_modify(out) on
 success in tee
Message-ID: <1274d6074fdd2ca4e028c8b62e42d0ef2b847703.1687898895.git.nabijaczleweli@nabijaczleweli.xyz>
References: <t5az5bvpfqd3rrwla43437r5vplmkujdytixcxgm7sc4hojspg@jcc63stk66hz>
 <cover.1687898895.git.nabijaczleweli@nabijaczleweli.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4ot4an2wv4srdmhm"
Content-Disposition: inline
In-Reply-To: <cover.1687898895.git.nabijaczleweli@nabijaczleweli.xyz>
User-Agent: NeoMutt/20230517
Precedence: bulk


--4ot4an2wv4srdmhm
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Same logic applies here: this can fill up the pipe, and pollers that rely
on getting IN_MODIFY notifications never wake up.

Fixes: 983652c69199 ("splice: report related fsnotify events")
Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs=
3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
Link: https://bugs.debian.org/1039488
Signed-off-by: Ahelenia Ziemia=C5=84ska <nabijaczleweli@nabijaczleweli.xyz>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
---
 fs/splice.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fs/splice.c b/fs/splice.c
index d3a7f4d5c078..bdbabc2ebfff 100644
--- a/fs/splice.c
+++ b/fs/splice.c
@@ -1810,6 +1810,11 @@ long do_tee(struct file *in, struct file *out, size_=
t len, unsigned int flags)
 		}
 	}
=20
+	if (ret > 0) {
+		fsnotify_access(in);
+		fsnotify_modify(out);
+	}
+
 	return ret;
 }
=20
--=20
2.39.2

--4ot4an2wv4srdmhm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSbS7cACgkQvP0LAY0m
WPGHoBAAuEr2KQDe9rtumdeeAh4Ffl/KEpS/Bi8/idfGipB+ouXMPgw5YvEzycCN
SczBs3/Iw+E/8CHFuXJN9XFrj0GglDr/cYmH0qmZ1ljmKnQUa/P6iRmPhZErr8lv
hHVtfszJGBb2MInCUmEom0SZjZloyvQLtipSabeasgrtBf8prBZcOdjvnzIolGKq
T2IJ2v9xP2ijrNavdvxcO66Gh9ibnQqYAyZtajaXek0qyY0RJoSY7V5N3RwGLQuS
cDsn9fiXYH91zB02leNyzQySWSnS7EIcG1NeSi4SL15ZD9s0srr6LuA5oWBiZBNa
oMTG1zjE2/F85qMEBuCBpFeWw4EHXgVs8XU6XSQXxwSzRHpbPbCOJzQvVNfANVAe
UN61cHxHSPePvWNUG4hnPTCP7ZyTPvNNxVzZ5T8XjT2wAYjTR39bxJczN2wrZkfV
ASrgDVj4mQlReuJD2IWt9S9NTtSzU3TOqWxGi0jXt3m+dxArFS8WW/YK0fmJ2yaq
ZfuaoEEV05G2hqXPvdW3FHFLmdFqG7JlCJsA3gat05z3GttSRmDQaQRDy6CJ0GbW
eSgfr9yFp3ZwuDxqTfWz3vOr6VtX3HHx8n8lRTzzuoUS9iaWW3uNTLYEaEak2koz
nR6OJn7z2/mQ7+gX8GqJMEmnf7UcH1zTTG2xPukKB9bGaYhPVvU=
=CovH
-----END PGP SIGNATURE-----

--4ot4an2wv4srdmhm--