Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230627050148.2045691-1-yangcong5@huaqin.corp-partner.google.com>
In-Reply-To: <20230627050148.2045691-1-yangcong5@huaqin.corp-partner.google.com>
From:   Doug Anderson <dianders@google.com>
Date:   Tue, 27 Jun 2023 14:17:10 -0700
Message-ID: <CAD=FV=WR=fnhCxC37Eo3hinh2MV=eTNuXG+GrwgR6K_pV4Rbaw@mail.gmail.com>
Subject: Re: [v2] drm/panel: Fine tune Starry-ili9882t panel HFP and HBP
To:     Cong Yang <yangcong5@huaqin.corp-partner.google.com>
Cc:     sam@ravnborg.org, neil.armstrong@linaro.org, daniel@ffwll.ch,
        airlied@gmail.com, hsinyi@google.com,
        dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

On Mon, Jun 26, 2023 at 10:01=E2=80=AFPM Cong Yang
<yangcong5@huaqin.corp-partner.google.com> wrote:
>
> Because the setting of hproch is too small, there will be warning in
> kernel log[1]. After fine tune the HFP and HBP, this warning can be
> solved. The actual measurement frame rate is 60.1Hz.
>
> [1]: WARNING kernel:[drm] HFP + HBP less than d-phy, FPS will under 60Hz

Thanks for including the warming. This looks like something that's
only printed on Mediatek display controllers. Just out of curiosity:
is that because Mediatek controllers have special requirements, or is
this something generic and the Mediatek controller is the only one
that warns about it?


> Fixes: 8716a6473e6c ("drm/panel: Support for Starry-ili9882t TDDI
> MIPI-DSI panel")

Ideally the tool you have to send mail wouldn't wrap the Fixes line.
Probably not worth resending just for this, but see if there's
something you can do to fix this in the future.

Since this is a tiny fix, I don't think we need to wait too long. I'll
plan to land it on Thursday unless Neil wants to land it himself
sooner.

Reviewed-by: Douglas Anderson <dianders@chromium.org>