Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 27 Jun 2023 22:59:17 +0200
From:   Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= 
        <nabijaczleweli@nabijaczleweli.xyz>
To:     Amir Goldstein <amir73il@gmail.com>
Cc:     Alexander Viro <viro@zeniv.linux.org.uk>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jan Kara <jack@suse.cz>,
        Chung-Chiang Cheng <cccheng@synology.com>, ltp@lists.linux.it
Subject: [LTP RFC PATCH v2] inotify13: new test for fs/splice.c functions vs
 pipes vs inotify
Message-ID: <ajkeyn2sy35h6ctfbupom4xg3ozoxxgsojdvu7vebac44zqped@ecnusnv6daxn>
References: <CAOQ4uxifYoKdup6gzyW0iV=KFBzTWu5T8=zq8s8pFw2X3+5xRg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="aadmf3i7azbjbqpw"
Content-Disposition: inline
In-Reply-To: <CAOQ4uxifYoKdup6gzyW0iV=KFBzTWu5T8=zq8s8pFw2X3+5xRg@mail.gmail.com>
User-Agent: NeoMutt/20230517
Precedence: bulk


--aadmf3i7azbjbqpw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The only one that passes on 6.1.27-1 is sendfile_file_to_pipe.

Link: https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs=
3dodpofafnkkunxq7bu@jngkdxx65pux/t/#u
Signed-off-by: Ahelenia Ziemia=C5=84ska <nabijaczleweli@nabijaczleweli.xyz>
---
Whitespace-only changes against v1.
Marking as RFC since we have no commit SHA to reference.

I didn't find any style opinions in the repository, so I just let
clang-format rip. Apparently, according to a /github wiki page/:
  https://github.com/linux-test-project/ltp/wiki/Test-Writing-Guidelines#2-=
coding-style
which is /only referenced/ from a 2020 issue:
  https://github.com/linux-test-project/ltp/issues/631
LTP uses the kernel style.

Could've fooled me, because the other inotify tests are definitely not
in the kernel style.

Re-formatted the whole file with the linux .clang-format.

 testcases/kernel/syscalls/inotify/.gitignore  |   1 +
 testcases/kernel/syscalls/inotify/inotify13.c | 260 ++++++++++++++++++
 2 files changed, 261 insertions(+)
 create mode 100644 testcases/kernel/syscalls/inotify/inotify13.c

diff --git a/testcases/kernel/syscalls/inotify/.gitignore b/testcases/kerne=
l/syscalls/inotify/.gitignore
index f6e5c546a..b597ea63f 100644
--- a/testcases/kernel/syscalls/inotify/.gitignore
+++ b/testcases/kernel/syscalls/inotify/.gitignore
@@ -10,3 +10,4 @@
 /inotify10
 /inotify11
 /inotify12
+/inotify13
diff --git a/testcases/kernel/syscalls/inotify/inotify13.c b/testcases/kern=
el/syscalls/inotify/inotify13.c
new file mode 100644
index 000000000..8c2cd4cf1
--- /dev/null
+++ b/testcases/kernel/syscalls/inotify/inotify13.c
@@ -0,0 +1,260 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*\
+ * Verify splice-family functions (and sendfile) generate IN_ACCESS
+ * for what they read and IN_MODIFY for what they write.
+ *
+ * Regression test for 983652c69199 and
+ * https://lore.kernel.org/linux-fsdevel/jbyihkyk5dtaohdwjyivambb2gffyjs3d=
odpofafnkkunxq7bu@jngkdxx65pux/t/#u
+ */
+
+#define _GNU_SOURCE
+#include "config.h"
+
+#include <stdio.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <fcntl.h>
+#include <stdbool.h>
+#include <inttypes.h>
+#include <signal.h>
+#include <sys/mman.h>
+#include <sys/sendfile.h>
+
+#include "tst_test.h"
+#include "tst_safe_macros.h"
+#include "inotify.h"
+
+#if defined(HAVE_SYS_INOTIFY_H)
+#include <sys/inotify.h>
+
+static int pipes[2] =3D { -1, -1 };
+static int inotify =3D -1;
+static int memfd =3D -1;
+static int data_pipes[2] =3D { -1, -1 };
+
+static void watch_rw(int fd)
+{
+	char buf[64];
+	sprintf(buf, "/proc/self/fd/%d", fd);
+	SAFE_MYINOTIFY_ADD_WATCH(inotify, buf, IN_ACCESS | IN_MODIFY);
+}
+
+static int compar(const void *l, const void *r)
+{
+	const struct inotify_event *lie =3D l;
+	const struct inotify_event *rie =3D r;
+	return lie->wd - rie->wd;
+}
+
+static void get_events(size_t evcnt, struct inotify_event evs[static evcnt=
])
+{
+	struct inotify_event tail, *itr =3D evs;
+	for (size_t left =3D evcnt; left; --left)
+		SAFE_READ(true, inotify, itr++, sizeof(struct inotify_event));
+
+	TEST(read(inotify, &tail, sizeof(struct inotify_event)));
+	if (TST_RET !=3D -1)
+		tst_brk(TFAIL, ">%zu events", evcnt);
+	if (TST_ERR !=3D EAGAIN)
+		tst_brk(TFAIL | TTERRNO, "expected EAGAIN");
+
+	qsort(evs, evcnt, sizeof(struct inotify_event), compar);
+}
+
+static void expect_event(struct inotify_event *ev, int wd, uint32_t mask)
+{
+	if (ev->wd !=3D wd)
+		tst_brk(TFAIL, "expect event for wd %d got %d", wd, ev->wd);
+	if (ev->mask !=3D mask)
+		tst_brk(TFAIL,
+			"expect event with mask %" PRIu32 " got %" PRIu32 "",
+			mask, ev->mask);
+}
+
+#define F2P(splice)                                                      \
+	SAFE_WRITE(SAFE_WRITE_RETRY, memfd, __func__, sizeof(__func__)); \
+	SAFE_LSEEK(memfd, 0, SEEK_SET);                                  \
+	watch_rw(memfd);                                                 \
+	watch_rw(pipes[0]);                                              \
+	TEST(splice);                                                    \
+	if (TST_RET =3D=3D -1)                                               \
+		tst_brk(TBROK | TERRNO, #splice);                        \
+	if (TST_RET !=3D sizeof(__func__))                                 \
+		tst_brk(TBROK, #splice ": %" PRId64 "", TST_RET);        \
+                                                                         \
+	/* expecting: IN_ACCESS memfd, IN_MODIFY pipes[0] */             \
+	struct inotify_event events[2];                                  \
+	get_events(ARRAY_SIZE(events), events);                          \
+	expect_event(events + 0, 1, IN_ACCESS);                          \
+	expect_event(events + 1, 2, IN_MODIFY);                          \
+                                                                         \
+	char buf[sizeof(__func__)];                                      \
+	SAFE_READ(true, pipes[0], buf, sizeof(__func__));                \
+	if (memcmp(buf, __func__, sizeof(__func__)))                     \
+		tst_brk(TFAIL, "buf contents bad");
+static void splice_file_to_pipe(void)
+{
+	F2P(splice(memfd, NULL, pipes[1], NULL, 128 * 1024 * 1024, 0));
+}
+static void sendfile_file_to_pipe(void)
+{
+	F2P(sendfile(pipes[1], memfd, NULL, 128 * 1024 * 1024));
+}
+
+static void splice_pipe_to_file(void)
+{
+	SAFE_WRITE(SAFE_WRITE_RETRY, pipes[1], __func__, sizeof(__func__));
+	watch_rw(pipes[0]);
+	watch_rw(memfd);
+	TEST(splice(pipes[0], NULL, memfd, NULL, 128 * 1024 * 1024, 0));
+	if (TST_RET =3D=3D -1)
+		tst_brk(TBROK | TERRNO, "splice");
+	if (TST_RET !=3D sizeof(__func__))
+		tst_brk(TBROK, "splice: %" PRId64 "", TST_RET);
+
+	/* expecting: IN_ACCESS pipes[0], IN_MODIFY memfd */
+	struct inotify_event events[2];
+	get_events(ARRAY_SIZE(events), events);
+	expect_event(events + 0, 1, IN_ACCESS);
+	expect_event(events + 1, 2, IN_MODIFY);
+
+	char buf[sizeof(__func__)];
+	SAFE_LSEEK(memfd, 0, SEEK_SET);
+	SAFE_READ(true, memfd, buf, sizeof(__func__));
+	if (memcmp(buf, __func__, sizeof(__func__)))
+		tst_brk(TFAIL, "buf contents bad");
+}
+
+#define P2P(splice)                                                  \
+	SAFE_WRITE(SAFE_WRITE_RETRY, data_pipes[1], __func__,        \
+		   sizeof(__func__));                                \
+	watch_rw(data_pipes[0]);                                     \
+	watch_rw(pipes[1]);                                          \
+	TEST(splice);                                                \
+	if (TST_RET =3D=3D -1)                                           \
+		tst_brk(TBROK | TERRNO, #splice);                    \
+	if (TST_RET !=3D sizeof(__func__))                             \
+		tst_brk(TBROK, #splice ": %" PRId64 "", TST_RET);    \
+                                                                     \
+	/* expecting: IN_ACCESS data_pipes[0], IN_MODIFY pipes[1] */ \
+	struct inotify_event events[2];                              \
+	get_events(ARRAY_SIZE(events), events);                      \
+	expect_event(events + 0, 1, IN_ACCESS);                      \
+	expect_event(events + 1, 2, IN_MODIFY);                      \
+                                                                     \
+	char buf[sizeof(__func__)];                                  \
+	SAFE_READ(true, pipes[0], buf, sizeof(__func__));            \
+	if (memcmp(buf, __func__, sizeof(__func__)))                 \
+		tst_brk(TFAIL, "buf contents bad");
+static void splice_pipe_to_pipe(void)
+{
+	P2P(splice(data_pipes[0], NULL, pipes[1], NULL, 128 * 1024 * 1024, 0));
+}
+static void tee_pipe_to_pipe(void)
+{
+	P2P(tee(data_pipes[0], pipes[1], 128 * 1024 * 1024, 0));
+}
+
+static char vmsplice_pipe_to_mem_dt[32 * 1024];
+static void vmsplice_pipe_to_mem(void)
+{
+	memcpy(vmsplice_pipe_to_mem_dt, __func__, sizeof(__func__));
+	watch_rw(pipes[0]);
+	TEST(vmsplice(
+		pipes[1],
+		&(struct iovec){ .iov_base =3D vmsplice_pipe_to_mem_dt,
+				 .iov_len =3D sizeof(vmsplice_pipe_to_mem_dt) },
+		1, SPLICE_F_GIFT));
+	if (TST_RET =3D=3D -1)
+		tst_brk(TBROK | TERRNO, "vmsplice");
+	if (TST_RET !=3D sizeof(vmsplice_pipe_to_mem_dt))
+		tst_brk(TBROK, "vmsplice: %" PRId64 "", TST_RET);
+
+	/* expecting: IN_MODIFY pipes[0] */
+	struct inotify_event event;
+	get_events(1, &event);
+	expect_event(&event, 1, IN_MODIFY);
+
+	char buf[sizeof(__func__)];
+	SAFE_READ(true, pipes[0], buf, sizeof(__func__));
+	if (memcmp(buf, __func__, sizeof(__func__)))
+		tst_brk(TFAIL, "buf contents bad");
+}
+
+static void vmsplice_mem_to_pipe(void)
+{
+	char buf[sizeof(__func__)];
+	SAFE_WRITE(SAFE_WRITE_RETRY, pipes[1], __func__, sizeof(__func__));
+	watch_rw(pipes[1]);
+	TEST(vmsplice(pipes[0],
+		      &(struct iovec){ .iov_base =3D buf,
+				       .iov_len =3D sizeof(buf) },
+		      1, 0));
+	if (TST_RET =3D=3D -1)
+		tst_brk(TBROK | TERRNO, "vmsplice");
+	if (TST_RET !=3D sizeof(buf))
+		tst_brk(TBROK, "vmsplice: %" PRId64 "", TST_RET);
+
+	/* expecting: IN_ACCESS pipes[1] */
+	struct inotify_event event;
+	get_events(1, &event);
+	expect_event(&event, 1, IN_ACCESS);
+	if (memcmp(buf, __func__, sizeof(__func__)))
+		tst_brk(TFAIL, "buf contents bad");
+}
+
+typedef void (*tests_f)(void);
+#define TEST_F(f)      \
+	{              \
+		f, #f, \
+	}
+static const struct {
+	tests_f f;
+	const char *n;
+} tests[] =3D {
+	TEST_F(splice_file_to_pipe),  TEST_F(sendfile_file_to_pipe),
+	TEST_F(splice_pipe_to_file),  TEST_F(splice_pipe_to_pipe),
+	TEST_F(tee_pipe_to_pipe),     TEST_F(vmsplice_pipe_to_mem),
+	TEST_F(vmsplice_mem_to_pipe),
+};
+
+static void run_test(unsigned int n)
+{
+	tst_res(TINFO, "%s", tests[n].n);
+
+	SAFE_PIPE2(pipes, O_CLOEXEC);
+	SAFE_PIPE2(data_pipes, O_CLOEXEC);
+	inotify =3D SAFE_MYINOTIFY_INIT1(IN_NONBLOCK | IN_CLOEXEC);
+	if ((memfd =3D memfd_create(__func__, MFD_CLOEXEC)) =3D=3D -1)
+		tst_brk(TCONF | TERRNO, "memfd");
+	tests[n].f();
+	tst_res(TPASS, "=D0=BE=D0=BA");
+}
+
+static void cleanup(void)
+{
+	if (memfd !=3D -1)
+		SAFE_CLOSE(memfd);
+	if (inotify !=3D -1)
+		SAFE_CLOSE(inotify);
+	if (pipes[0] !=3D -1)
+		SAFE_CLOSE(pipes[0]);
+	if (pipes[1] !=3D -1)
+		SAFE_CLOSE(pipes[1]);
+	if (data_pipes[0] !=3D -1)
+		SAFE_CLOSE(data_pipes[0]);
+	if (data_pipes[1] !=3D -1)
+		SAFE_CLOSE(data_pipes[1]);
+}
+
+static struct tst_test test =3D {
+	.max_runtime =3D 10,
+	.cleanup =3D cleanup,
+	.test =3D run_test,
+	.tcnt =3D ARRAY_SIZE(tests),
+	.tags =3D (const struct tst_tag[]){ { "linux-git", "983652c69199" }, {} },
+};
+
+#else
+TST_TEST_TCONF("system doesn't have required inotify support");
+#endif
--=20
2.39.2

--aadmf3i7azbjbqpw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmSbTaUACgkQvP0LAY0m
WPGNNRAAi6Lq2fRPTqF97WtfGi8Gfxt8iKcK1m8DKj9cHd4VbJNRZVl3FYvMOgAW
Al8SkLG4oTHtYwBkEVDzWzTucc5SlyTHDebDEoW84H9HufMoTrobw2o8w4KSYLKr
27nRXvBDqq7hWsiLe/5EZTM09HAvda/iCisL3TzWWdbwX1tMU6rOx5iLe2NoInyy
b4vtyQAbSc+WcbzMMlF239KrwJx+2fxRnh0MyWVTap9nmoNbHmE3FBsdTTXYXxVn
Fa7n78nuDKWyHCP24Lw9979Amn4DuFvm3IlIa4Du/Jc5NJil1tL+3C3RmiLw1sXv
kmz3yjaiomm52JggY1/7dgZzebfu7XW0ULR6r8Wzr/VPtsHl0wJjxe3XXMv3VHDQ
I/74GpC78RAZE6m6YCJHxqCpre6aGBn+DfTp4D7yunR0on9vAPx4BIeAruUCR+X2
buXBLNHaz1N5SUHMNmY/fS4iDWH3MizsR0xAEqZ4npJYHBIcKJ11pX/SpPSJYZTv
r7S5xuTbplOM1o0q8egDIcF9AOWFYZAfEXBTUCMY4Q387V4D8EcMlG7jwrrGkfO+
xEs3qYhZjwjYfFhYDvTrcAd5vyoDOLx2q6rkJXs+3r4EymPA/YuB+3itTjPEVKJj
uiBoV0coS/qMpPURsYSAUqIm/TkNB87Nsyt9U+NgXhDFLNuRz6c=
=Mxnw
-----END PGP SIGNATURE-----

--aadmf3i7azbjbqpw--