Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 08:18:01 +0900
From:   Naoya Horiguchi <naoya.horiguchi@linux.dev>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, naoya.horiguchi@nec.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memory-failure: remove unneeded 'inline' annotation
Message-ID: <20230627231801.GA992637@ik1-406-35019.vs.sakura.ne.jp>
References: <20230626114343.1846587-1-linmiaohe@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230626114343.1846587-1-linmiaohe@huawei.com>
Precedence: bulk

On Mon, Jun 26, 2023 at 07:43:43PM +0800, Miaohe Lin wrote:
> Remove unneeded 'inline' annotation from num_poisoned_pages_inc() and
> num_poisoned_pages_sub(). No functional change intended.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>

Yes, num_poisoned_pages_{inc,sub} seem not to be inlined even if "inline"
keyword is given, maybe because they are not static functions.

Thank you for finding this.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> ---
>  mm/memory-failure.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 66e7b3ceaf2d..aada6ac72fe5 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -75,13 +75,13 @@ atomic_long_t num_poisoned_pages __read_mostly = ATOMIC_LONG_INIT(0);
>  
>  static bool hw_memory_failure __read_mostly = false;
>  
> -inline void num_poisoned_pages_inc(unsigned long pfn)
> +void num_poisoned_pages_inc(unsigned long pfn)
>  {
>  	atomic_long_inc(&num_poisoned_pages);
>  	memblk_nr_poison_inc(pfn);
>  }
>  
> -inline void num_poisoned_pages_sub(unsigned long pfn, long i)
> +void num_poisoned_pages_sub(unsigned long pfn, long i)
>  {
>  	atomic_long_sub(i, &num_poisoned_pages);
>  	if (pfn != -1UL)
> -- 
> 2.27.0
> 
> 
>