Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 09:04:51 +0900
From:   Naoya Horiguchi <naoya.horiguchi@linux.dev>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     akpm@linux-foundation.org, naoya.horiguchi@nec.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in
 shake_page()
Message-ID: <20230628000451.GA1000547@ik1-406-35019.vs.sakura.ne.jp>
References: <20230625113430.2310385-1-linmiaohe@huawei.com>
 <20230626005221.GA353339@ik1-406-35019.vs.sakura.ne.jp>
 <2cd57a67-1cb2-83b8-3f73-6da72cd6159d@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <2cd57a67-1cb2-83b8-3f73-6da72cd6159d@huawei.com>
Precedence: bulk

On Mon, Jun 26, 2023 at 09:43:44AM +0800, Miaohe Lin wrote:
> On 2023/6/26 8:52, Naoya Horiguchi wrote:
> > On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote:
> >> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches
> >> are not shrunk now. This check can be added back when a lightweight range
> >> based shrinker is available.
> >>
> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> > 
> > This looks to me a good cleanup because the result of
> > "if (PageLRU(p) || is_free_buddy_page(p))" check is not used, so the check
> > itself is unneeded.
> > 
> >> ---
> >>  mm/memory-failure.c | 9 ++++-----
> >>  1 file changed, 4 insertions(+), 5 deletions(-)
> >>
> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> >> index 5b663eca1f29..92f951df3e87 100644
> >> --- a/mm/memory-failure.c
> >> +++ b/mm/memory-failure.c
> >> @@ -373,11 +373,10 @@ void shake_page(struct page *p)
> >>  	if (PageHuge(p))
> >>  		return;
> >>  
> >> -	if (!PageSlab(p)) {
> >> -		lru_add_drain_all();
> >> -		if (PageLRU(p) || is_free_buddy_page(p))
> >> -			return;
> >> -	}
> >> +	if (PageSlab(p))
> >> +		return;
> >> +
> >> +	lru_add_drain_all();
> >>  
> >>  	/*
> >>  	 * TODO: Could shrink slab caches here if a lightweight range-based
> > 
> > I think that this TODO comment can be put together with "if (PageSlab)" block.
> 
> Thanks for your comment and advice. Do you mean something like below?

Yes, this is what I mean.  Feel free to add my ack when posting v2.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

Thank you.

> 
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 5b663eca1f29..66e7b3ceaf2d 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -372,17 +372,14 @@ void shake_page(struct page *p)
>  {
>         if (PageHuge(p))
>                 return;
> -
> -       if (!PageSlab(p)) {
> -               lru_add_drain_all();
> -               if (PageLRU(p) || is_free_buddy_page(p))
> -                       return;
> -       }
> -
>         /*
>          * TODO: Could shrink slab caches here if a lightweight range-based
>          * shrinker will be available.
>          */
> +       if (PageSlab(p))
> +               return;
> +
> +       lru_add_drain_all();
>  }
>  EXPORT_SYMBOL_GPL(shake_page);
> 
> Thanks.
> 
>