Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ddcc31b5-0518-e2e3-2887-62a4ccc9e582@intel.com>
Date:   Wed, 28 Jun 2023 10:43:05 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH v1 06/10] mm: Allow deferred splitting of arbitrary large
 anon folios
Content-Language: en-US
To:     Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        David Hildenbrand <david@redhat.com>,
        Yu Zhao <yuzhao@google.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-alpha@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-ia64@vger.kernel.org>, <linux-m68k@lists.linux-m68k.org>,
        <linux-s390@vger.kernel.org>
References: <20230626171430.3167004-1-ryan.roberts@arm.com>
 <20230626171430.3167004-7-ryan.roberts@arm.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20230626171430.3167004-7-ryan.roberts@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T2xSbFFuSFV6RVVjZ1lVMWVnVkN0bXFLL1ZlQnc3ME1xdU4vZHRRMXhaSzVT?=
 =?utf-8?B?bDlQQXRlY1VFTnlsZXN1UFBYN2U3cmlCUlJaVVlUQWZXQjhiWmdNSGVQNC9s?=
 =?utf-8?B?UkczSkNodXhXOHF3UlN1eWVGNEVDU09IUndKOEl6a3ZTcExFQW1Relg0YWJa?=
 =?utf-8?B?Nm9JZzBCNWJmRlhqaG1xNGZwV3p5eFE2MnhMVUIxSUJrdjBoZjRMbTdtaFBa?=
 =?utf-8?B?WmdkcEh3UUNZZzBmcFdCU2pPM3ZnaVB0TFAxUGQyQjRhcjQ4USs4U2k4ZTdl?=
 =?utf-8?B?R2g0M0J5Wk0xL3d2VkZaMVAvM0VwK0ZDVXI5aWZsREh0THpzeWlNQmVySXJi?=
 =?utf-8?B?ajFDWGZUM2ozTjV1WjQ1cXM5TENGem9URHZwVWR0ZTVoeHRpYnNya3B0dUJo?=
 =?utf-8?B?MlFpc2RqenY5TGNOei9EUm1kZXVqR2xxM3BMOUpxRWZ0VkpWWWlVK3ZvN2Ja?=
 =?utf-8?B?OE9MRUkrTmR1RnMyMCtDTzBvamRPVkNMdE9ZeDZEaWFkUnh5Z1ZtVkpnRHR0?=
 =?utf-8?B?QXVsdGhlZGpPWnUwZFlBNkhMVmNIbEZjUXlEcTNSSWpuN2wrRU5UWmpSRzN5?=
 =?utf-8?B?eGZxQURJbXhnV0swLytrcXZOeUFkcjNTcFF3cnVwdnBTTG5QdjNGODNQOWxn?=
 =?utf-8?B?TkJDSkJYSkk0ZnZYbUdIZEZGYmJhSWxFZTdoSEhtNmNaTlJZaG0wNzcyMlky?=
 =?utf-8?B?NE84dXVNaTdnL25BclU1SG5maTFydW5hMFJxYTFwUUJpSXMwZE9CNXB1dExD?=
 =?utf-8?B?aUx0dEZyVVZxNTJtNnhqbzI1cWI3UGJGRlFwR2l0R2NOQ1k1ckYwemR3Yk4r?=
 =?utf-8?B?SlQ1TTRtYVdwZXVSRUZjV0E3cWZ5S2lrUFFLMmx1ZHEwRHUvNzdHUWJ0Q0dt?=
 =?utf-8?B?dGRVM3AwaE1OSjJYYk80QWtCVmlVY2lCZXNRT2ZzMmJlUmxPdXNRUFZJUnVa?=
 =?utf-8?B?YzhLUXdXRVcxK3k4ZmNsek1FbHRiMkM5UXdXTlhETTdrMVgrZzBTOVN4UnJC?=
 =?utf-8?B?eFBLOGlwS0UvTlVsWjFzV3p1emNlNzlOb25VKzZmWTNWQ0FjRVF2NklwMUEz?=
 =?utf-8?B?cVRVZ3pkOE41eDV4UzZ6ckhFLy81WGl6ejRhYVN5SmdET0tvQUR6cXp3UHFZ?=
 =?utf-8?B?cnFTZEwzaEh1OGVBQS8vSnhHc1N3SkZhMjFnZ3NWZ0VCNXBsOTIvRzA3Vm4w?=
 =?utf-8?B?dnpyTUJ5RlRTU3kvajdBUEtPMFdFVDhaVTNTVzBjTHliQmxhRWZIdGRBUDNi?=
 =?utf-8?B?ZjM2MkpFRVJIc1hFeUFldnc3aVJBY0Z4TWhibllNQkx2VkNLb0JDUW56NWFi?=
 =?utf-8?B?OWRTMVoyZjB3NjlpSVR4TTYwbVFrOVdhTVBpMjQvbkdSTVhnUlN3R2ZSZjBv?=
 =?utf-8?B?R1ZZOFVNOVdpTUdUVksyQWlIWEhvWElpTVN4SGJEYlRZdHEyL0FlWEoxNkhV?=
 =?utf-8?B?aTFRWTBxQ1ZaQlM1K3NKaThnRTlSdkNOQnBoWmJ5aHNSM200NXJ1WVZhSmFN?=
 =?utf-8?B?TDVGSjBOWUpzdlN6YklXMlRCb0o5ZGwrUXg4NThVSmlsVXkvWVRyam1mOStH?=
 =?utf-8?B?bzhIazFleGFoRnZYT1NyRDRmb05hVDB1Rzd6cTN5VWtxMWJvemdsd3V0Y1Ex?=
 =?utf-8?B?Q1o5Si8zWmVzTU5TQ29nbyt3ZXdZVWxYbDNhakxtRXJtK2pINVNTKytPSzQ3?=
 =?utf-8?B?UWZCd3B4WGZjMHMrdmhNMFU1T2xhUVVPZjkyeEppb3V5eUhSVHMvdWFxbXRv?=
 =?utf-8?B?anJyZFJqUXFiMzl6YjNRbHI3MW9aN05uUThjWlJBOTRrZ3NncmsxRDEwdWhP?=
 =?utf-8?B?c2tsSlFQcENlQndkMVVnSXVaeDJhbFY0UGpvQVcvY2lpN2o5Rm9rSmVSQm9l?=
 =?utf-8?B?N2pJUm1EdEZZS2NyaDc0NTI2Z0lzUVZhZnZWaGxjNy81dTNoaWRiTkI0RXdO?=
 =?utf-8?B?VytSNFZuRTBmMnFHc29CT2FnZ0FLRGdRaGZDenV1TWFFRnZkN0lSWFJXa1RI?=
 =?utf-8?B?WUt3RjJVcnk3NnFBeGxlRzZhbkxWSEIwZytoZU14Y2FqWThicXgxNXAzcmU1?=
 =?utf-8?B?M2V4N1dFcXhnRjZXZU03ZTI1V2RpSzZJMmFXUGlqclpHVUdldkxLMVdmeURr?=
 =?utf-8?Q?51uRhZRsxBtS9+3WB0R7IXNdS?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 22651b35-81f4-49cf-eceb-08db77817085
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 02:43:22.7814
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5XtWioyfUH7ElG2sw4eeX+1SduxhQWUWVOmf+rAbrXVfaqQnPPyxSg1CfPtDloBIIwBTBm+BzYLQcGcvSnekXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6359
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/27/23 01:14, Ryan Roberts wrote:
> With the introduction of large folios for anonymous memory, we would
> like to be able to split them when they have unmapped subpages, in order
> to free those unused pages under memory pressure. So remove the
> artificial requirement that the large folio needed to be at least
> PMD-sized.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>
Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>


Regards
Yin, Fengwei

> ---
>  mm/rmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index ac1d93d43f2b..3d11c5fb6090 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1567,7 +1567,7 @@ void page_remove_rmap(struct page *page, struct vm_area_struct *vma,
>  		 * page of the folio is unmapped and at least one page
>  		 * is still mapped.
>  		 */
> -		if (folio_test_pmd_mappable(folio) && folio_test_anon(folio))
> +		if (folio_test_large(folio) && folio_test_anon(folio))
>  			if (!compound || nr < nr_pmdmapped)
>  				deferred_split_folio(folio);
>  	}