Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8d35bbf9-5843-39be-c429-3c43108520d3@intel.com>
Date:   Wed, 28 Jun 2023 10:59:22 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH] readahead: Correct the start and size in
 ondemand_readahead()
Content-Language: en-US
To:     <akpm@linux-foundation.org>, <mike.kravetz@oracle.com>,
        <willy@infradead.org>, <ackerleytng@google.com>,
        <linux-fsdevel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
CC:     kernel test robot <oliver.sang@intel.com>
References: <20230627050702.823033-1-fengwei.yin@intel.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20230627050702.823033-1-fengwei.yin@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2VzSzlINkdWMnA0UDN0NHB6SG8vUHhOTjQ1Y1p0dWcyMFZUOXI0T3hlMCty?=
 =?utf-8?B?UlVaS1RjRE52cGUrd1NZZEh3VU5CNy9Ob3dTTkVvNnVtM2w2TUxKQ2p4VFhR?=
 =?utf-8?B?VHFReWNub3duN1RMeDFJUjN1WnZMU2lQdHNaaXFyYWlUR0lmclVvaENCMlRO?=
 =?utf-8?B?U1RaMjJWd1VFd054L3ZmYnh4SVd0VVgrc09pUmZodHNUbCtWQ05BRFBWNlBD?=
 =?utf-8?B?WTc5VmdzamRlZ1BWbmkzWkVnaE9LdGZRTVRSZXpDZWo5ZHU1aUc1QkY0NFYz?=
 =?utf-8?B?aUd1N3RSTUJrbzZrYWdGZVJVcHh6YVhxUjRlL2ZUL1N2QWJvNmR3TU10Q1Zh?=
 =?utf-8?B?RURBUFRYdHcyd0JlTHhGemp5bmpIci9XNlI5Wk1xeCtNSXVaSlNzYW9TdlBU?=
 =?utf-8?B?UWN1M1hXdjRaeGlXdmZmYkpOWlZxWHZnaE9IY3p0Zmt6eGJIM1IzcDExRThu?=
 =?utf-8?B?aHlDaU1NeHg2S2tGWk1saHdVczNvVk1JS3ZyMUZKdlNPdWlaOG1GaFBSbGo3?=
 =?utf-8?B?OUo1NEZZUllFeFJ4SzdvM3FPNFhTYUE0VllXT3lmT3lTY1ZReWROYkVNcGVm?=
 =?utf-8?B?ZTZnSUNWaDlETmJoeXBKaUNDZjlqRFowV0J6d2EvUk1TdXBDU3A1bFI4MDRM?=
 =?utf-8?B?cXpyVktSaVpUQllFcHpFcjlKYWtoYUR3MjgyMFNyVjY3TURVcGRvSkt5SS95?=
 =?utf-8?B?UTBYRXpkdm0rUS9YK213MjJxTUJyWUZlYys5TDZUUjRTZ25lQStTdXEyK3hP?=
 =?utf-8?B?ckNVOGJkR1EvYlAzUUgvanRKbHliS25zZUE3eWtLVlNkUnZhYkNRa1g0SXRN?=
 =?utf-8?B?QldqZnhKNkVyTEpzNWsrd2x4WGVyb2R0TzhYWUlpOFlUdlVvT2lrUkgrSjRk?=
 =?utf-8?B?bkppZFpKSWMrT3lBZm5hR1FjZ1lEelBDVTFFaWRBV2tmbHR6STlubEsxejJw?=
 =?utf-8?B?UnZyRWJ5V01tdTNGVlJlQStpTHpZY2RobWU2QnNieDJRRHhJQ0ZoNW5Hbkhi?=
 =?utf-8?B?d0dHS25FYlhvSzU0TXMvb1BFaU1zRUxaejNEQXZwd3ZGSVlIN2xkMUJNeDFk?=
 =?utf-8?B?QThDbzZUV2l0WUplTm0yR0lwODloNUlqUXNzNmdEMDY0MkpNQzlXWXZhbFlz?=
 =?utf-8?B?dGdUSDZUQ000RFJVUXFwS29mZktycWUzTFA0VE1KNU9yMktoZnNWTWZNWDYv?=
 =?utf-8?B?VTZXV01aUG1yYUkrUm9TblRkWWtYQjNidmM1UGFzMnNWUkcwbkRRU3hnck1J?=
 =?utf-8?B?a0w4RmQrVWVjQkJ1WXRQZzF4a0d3Wnh2MkRibzJsSXZKREtURjFNV3AxZGY1?=
 =?utf-8?B?U0grWkpuNUJ4c2UwL2laSHpBNS9YLzkwQ2dJL1d0QytrSHhiOFVlRTlrdjFY?=
 =?utf-8?B?a2hFK0dnSjh4M2g3SGI1bXpKUGoycm9RejFQQitBTVEyekxqazRSdUk1ZWdo?=
 =?utf-8?B?cFIzSDlpa2MrNm9YWWRDZTRVa043aFNuU09KcFZ3OXZCRmpGUHY3YzlGY2tV?=
 =?utf-8?B?NFlxblVEUzNobFJ4RUtBN2RsMWM4OExzZlpMWmdqWmNZblFsbkF3SDdESGRm?=
 =?utf-8?B?SGFtSVErTFlBOGs3Z1BvMkRrdkduWEhFeCt1NDJiYjhLZjNnWlpqVkMybDRz?=
 =?utf-8?B?MXdhNkxqR0tmSGdKdzNPeFhIU21senl4Ymx0eVVTM2ljM0JUaWNFUDRvL01n?=
 =?utf-8?B?dkE3R29GTEg3UVJXTmJ0bitBNEpwY3Q2TEpDeHRzMlZKRmI2LzY4SndYT0p1?=
 =?utf-8?B?dUZtdkU5QStaekxhVVdPRlZqcTFCTnNJMDlsSjF2V1R5VEFNSThwbnBHZEh2?=
 =?utf-8?B?U3V3OUtwM3h4OHUwL25VYXRRQzkzMXdpUC96WHAzYzA5Yzc4R25KSUVMcVJD?=
 =?utf-8?B?ZGhhSy9BWWFYT2VWRUNwZ2RhYXFKZTRZK3NRNkR3L0NTamJ1OU9UbWdxRWtV?=
 =?utf-8?B?OEtoM2UwcjZTTjh4NXY2ZG13cGZ1ZWUxWHFxa2J1SnNRU2paL3hha1drczhN?=
 =?utf-8?B?MXViczlzSUQ4bW9KMWY3S0MxNU1ITTVwaHNwaFlub1dJUXZPOGNiWWZOdUU2?=
 =?utf-8?B?UFBZTERYREFnWDhaOTI3YjZ4U292cFV6bUF1aHQ5OXoreVhuR2tmTGhIakNt?=
 =?utf-8?Q?pgLS0O2ycaypXRMc7SB2QX5Z8?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e4c7a7e-13cf-4ea2-e45b-08db7783b521
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 02:59:36.9129
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NDwQ3hzXMF4xVa9sPTe2rUTaa5AxeX7ob3n30QR0kskTXHW0ewqe3qX/Ic+wWsqQVfmUFnKDmuUgQxPg6Z283g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7589
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/27/23 13:07, Yin Fengwei wrote:
> The commit
> 9425c591e06a ("page cache: fix page_cache_next/prev_miss off by one")
> updated the page_cache_next_miss() to return the index beyond
> range.
> 
> But it breaks the start/size of ra in ondemand_readahead() because
> the offset by one is accumulated to readahead_index. As a consequence,
> not best readahead order is picked.
> 
> Tracing of the order parameter of filemap_alloc_folio() showed:
>      page order    : count     distribution
>         0          : 892073   |                                        |
>         1          : 0        |                                        |
>         2          : 65120457 |****************************************|
>         3          : 32914005 |********************                    |
>         4          : 33020991 |********************                    |
> with 9425c591e06a9.
> 
> With parent commit:
>      page order    : count     distribution
>         0          : 3417288  |****                                    |
>         1          : 0        |                                        |
>         2          : 877012   |*                                       |
>         3          : 288      |                                        |
>         4          : 5607522  |*******                                 |
>         5          : 29974228 |****************************************|
> 
> Fix the issue by set correct start/size of ra in ondemand_readahead().
> 
> Reported-by: kernel test robot <oliver.sang@intel.com>
> Closes: https://lore.kernel.org/oe-lkp/202306211346.1e9ff03e-oliver.sang@intel.com
> Fixes: 9425c591e06a ("page cache: fix page_cache_next/prev_miss off by one")
> Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
> ---
>  mm/readahead.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/mm/readahead.c b/mm/readahead.c
> index 47afbca1d122e..a1b8c628851a9 100644
> --- a/mm/readahead.c
> +++ b/mm/readahead.c
> @@ -614,11 +614,11 @@ static void ondemand_readahead(struct readahead_control *ractl,
>  				max_pages);
>  		rcu_read_unlock();
>  
> -		if (!start || start - index > max_pages)
> +		if (!start || start - index - 1 > max_pages)
>  			return;
The offset by one only happens when no gaps in the range. So this patch need an update.
I will send out v2 soon. Thanks.


Regards
Yin, Fengwei

>  
> -		ra->start = start;
> -		ra->size = start - index;	/* old async_size */
> +		ra->start = start - 1;
> +		ra->size = start - index - 1;	/* old async_size */
>  		ra->size += req_size;
>  		ra->size = get_next_ra_size(ra, max_pages);
>  		ra->async_size = ra->size;