Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 11:09:43 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Kai Huang <kai.huang@intel.com>
CC:     <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
        <linux-mm@kvack.org>, <x86@kernel.org>, <dave.hansen@intel.com>,
        <kirill.shutemov@linux.intel.com>, <tony.luck@intel.com>,
        <peterz@infradead.org>, <tglx@linutronix.de>, <bp@alien8.de>,
        <mingo@redhat.com>, <hpa@zytor.com>, <seanjc@google.com>,
        <pbonzini@redhat.com>, <david@redhat.com>,
        <dan.j.williams@intel.com>, <rafael.j.wysocki@intel.com>,
        <ashok.raj@intel.com>, <reinette.chatre@intel.com>,
        <len.brown@intel.com>, <ak@linux.intel.com>,
        <isaku.yamahata@intel.com>, <ying.huang@intel.com>,
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        <nik.borisov@suse.com>, <bagasdotme@gmail.com>, <sagis@google.com>,
        <imammedo@redhat.com>
Subject: Re: [PATCH v12 05/22] x86/virt/tdx: Add SEAMCALL infrastructure
Message-ID: <ZJukd/bnkffgsQzT@chao-email>
References: <cover.1687784645.git.kai.huang@intel.com>
 <b2a875fd855145728744617ac4425a06d8b46c90.1687784645.git.kai.huang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <b2a875fd855145728744617ac4425a06d8b46c90.1687784645.git.kai.huang@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?D/C0Wa+JlNdG6T45xzj2uTpK+r55ppb/TOl209DeQPZLwKE91M8T9FmhfeT9?=
 =?us-ascii?Q?YzlAQuK7EmzwQR82WiAiRYT1BsPmNEpc1L4LfZFUZShlH4Kyidc0fVZkdARb?=
 =?us-ascii?Q?EQtRaGNR+1ZvUYfyN+T3GxHakfTVWludD8LkWZNYojh6WgZYJ9oQJi0+M4sP?=
 =?us-ascii?Q?qU5BA/YtfyGkyNCBcOLeIxK56qEeQ8qG9l8uzp8PO6foyDxd8Kys4A28FkNo?=
 =?us-ascii?Q?fGYnra6u5vMyn9wj9Zt19DedokJP5B8ok2FfJujbs/2JGp0G3+Vlbe9x1yvc?=
 =?us-ascii?Q?udMBEwidRyydYivzrhgtOSFDMJDs5Gw1RFSch0ysZSYeNEwjzRO5up0nke/v?=
 =?us-ascii?Q?Vp8YmZuvcyc6s/oukNHFfGZ0bPt1gmWhXBzrrMzUyyS0wb/UegL5SZxjv+Yw?=
 =?us-ascii?Q?uC9kaFXLRZBXelVMmoad8AAJgv4qcuLmY5yK6WYd56uWl/w+tZSlqnzhpDo5?=
 =?us-ascii?Q?rslcN2sfJR257Yux64uuQeAV38XaUWUbgqtzgz7b0PpsCvNJdkgIS3fByoJ9?=
 =?us-ascii?Q?Nhj8BZmwwyCcWBZxM/IDwuIpIXWS2JC73sbuoMS+lY87WaaZSutoWgflci3P?=
 =?us-ascii?Q?Gi0/RVGkcc2G/motvnPtpvfrHThG0R6d94TAg4VgguzbMTO0Bv65stNdUrsn?=
 =?us-ascii?Q?WFFD9ntrxHx2/ujsLZQMg2RjHW43KR/JdKodq87LhPUT7IuilrbyxxQJ9Kbi?=
 =?us-ascii?Q?ckUQJUKAFuNLcNcptvV3erP4heShZ3e2s7aw5RCZRmneoC1oUPQmgcaW8Zg7?=
 =?us-ascii?Q?qvtBrmks0IjKgwfMeuI5eu+8UWe1/BT6yEKoJXX9wO048AH1TZPSfDsD83TS?=
 =?us-ascii?Q?bLERd9hCBYwl/5J1CNHgGzojwDPXi1vsfJeDXYnsrYA2jAqkWsQkwdqjbSzt?=
 =?us-ascii?Q?nOvlbf4J+/6deAsqAQhpI42t5liKU74k96xw2z5gxxUirRpmDskwPpbIHVAd?=
 =?us-ascii?Q?W4zDKO3lUhznpK9LnPgO7OceKIjfqiPkKi/9QE5pd9W4RBSN/TcY8p2waU6C?=
 =?us-ascii?Q?B1VI/bKfp/njlv8C5iYWtnq70R6fJAHS/Wt/9QJykgPCxwbzl+/SuI4w6Afb?=
 =?us-ascii?Q?iEoaUiAsOrDNOT8Md2UQB7N/98y+uSupFM+62Ylg7DUwxgX8DWiAefTD4jMi?=
 =?us-ascii?Q?3hkgitOyUsGbsZwiFofl340XJ6wwby9YrMjJAW+h4JrIDfC1GgCOQ36ZkWbr?=
 =?us-ascii?Q?sMt4CDej2pzTLDJqUNAh9YMPRskSMj5MrEJnVtBzqOna9xm2+gb1nvz4GCwp?=
 =?us-ascii?Q?WM7ZcYjWMa1ZRxWk5T8vlE2C+hdcP4W8BZECmw9qwjUzSA1oUQQ74uEBaSfq?=
 =?us-ascii?Q?ngo6ZyMlvLM6tbE2stWECH5Hrat9tvXH/03gnI7G1mz4GVSVZksbEIp00VDT?=
 =?us-ascii?Q?FBDnlpK/D6RxW82mvxhDHs0bzq+KFiU5JdNs8hCVSbhOrcc1l4qZokypTCMV?=
 =?us-ascii?Q?JVQMnQOvPnk6PSMMFR2LzxpRxUM2KyijnGXHzZTu7BxwR82mpEeEBFo5ewIa?=
 =?us-ascii?Q?AY4iS3865+eynp6tve/ONAeAZwjfFxkXJkWygPsra1yEoq1PfIcxqrdZx6Vz?=
 =?us-ascii?Q?Ir/0YuAp5FS/TImNV8x0OYercqxVsTdlawL6fbRa?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ac695e0-a236-4a1c-2a39-08db778528c3
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB6780.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 03:10:00.4318
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x7vNoHPdtYhBn+M3t6NJh/yxX871Sec8rxqgwq17gZiZGuDpdkcS+1NWAgAA6ez3UWl6dMoKULFH697rpKI0Sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4683
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>+/*
>+ * Wrapper of __seamcall() to convert SEAMCALL leaf function error code
>+ * to kernel error code.  @seamcall_ret and @out contain the SEAMCALL
>+ * leaf function return code and the additional output respectively if
>+ * not NULL.
>+ */
>+static int __always_unused seamcall(u64 fn, u64 rcx, u64 rdx, u64 r8, u64 r9,
>+				    u64 *seamcall_ret,
>+				    struct tdx_module_output *out)
>+{
>+	u64 sret;
>+	int cpu;
>+
>+	/* Need a stable CPU id for printing error message */
>+	cpu = get_cpu();
>+	sret = __seamcall(fn, rcx, rdx, r8, r9, out);
>+	put_cpu();
>+
>+	/* Save SEAMCALL return code if the caller wants it */
>+	if (seamcall_ret)
>+		*seamcall_ret = sret;

Hi Kai,

All callers in this series pass NULL for seamcall_ret. I am no sure if
you keep it intentionally.

>+
>+	switch (sret) {
>+	case 0:
>+		/* SEAMCALL was successful */

Nit: if you add

#define TDX_SUCCESS	0

and do

	case TDX_SUCCESS:
		return 0;

then the code becomes self-explanatory. i.e., you can drop the comment.

>+		return 0;