Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Gaddam, Sarath Babu Naidu" <sarath.babu.naidu.gaddam@amd.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     "richardcochran@gmail.com" <richardcochran@gmail.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "simon.horman@corigine.com" <simon.horman@corigine.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "vincent.cheng.xh@renesas.com" <vincent.cheng.xh@renesas.com>,
        "Katakam, Harini" <harini.katakam@amd.com>,
        "git (AMD-Xilinx)" <git@amd.com>
Subject: RE: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load
 fails
Thread-Topic: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware load
 fails
Thread-Index: AQHZnn7SnE0MZjPu20aK+BkJgO+ed6+MTF0AgBOcpnA=
Date:   Wed, 28 Jun 2023 07:38:56 +0000
Message-ID: <MW5PR12MB55988C5FD23FB2380AF100168724A@MW5PR12MB5598.namprd12.prod.outlook.com>
References: <20230614051204.1614722-1-sarath.babu.naidu.gaddam@amd.com>
 <20230615130506.3efb333c@kernel.org>
In-Reply-To: <20230615130506.3efb333c@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BhMtpTYgKJnEGPPO3smcZqJBJbJadoJShirtIIMA/WONvKmRrxtvG4EGUPh/?=
 =?us-ascii?Q?a+E4SyAjfoAmiB/Mu6U/K4yam/gtlpXm7s3DaUyutLryfobVIM9WShXPO2lX?=
 =?us-ascii?Q?1pf72h+IvdLNcQY0EnBtZxZTQGYqZS6ObEY7URzBygsbYbDeRO65kcH7VGPY?=
 =?us-ascii?Q?vqAhLNpON5PxJkp9X/V5+00pcW4amvsgcVYf815C4MbutNcTvWf6srfcND9X?=
 =?us-ascii?Q?pK/1g6d+F92UWhrbOrEpNKM1pczZm6shDTkEDrBgt7y3RmyWEcn8msagLfJv?=
 =?us-ascii?Q?VOQ2bN9su1LsbtYuaePivGbKyP2F9ZOyb3QCU4R9d4xTkBwbauuaD6LBbTG5?=
 =?us-ascii?Q?VKDngNOzYXPgg0uAenhPF9aLUidcav1+H2UGQXZMSkN6mOKo2V9INNCeSTuM?=
 =?us-ascii?Q?VkUWVFKK1xoD511kz68ZsyGU7Ek9PWDlsbQbtpe36vfqm1wQP9NbB1mZCuY/?=
 =?us-ascii?Q?s2PLNBeaqPmWl04+E98QUW1zLQbM0dqVoH/5euLXRl0pBLqUUwPWeUIoaUem?=
 =?us-ascii?Q?qa7jB7mRwjIBE9hlEh2AqTeckbkKJVeufLUE66/ua06+EAQ8+nWnqHQhtN1G?=
 =?us-ascii?Q?BI+pppQpRoWbm8DD5gC9h7pD7bFDILEVt7RYd5Eagtb9uKRAp9E3qFoirukR?=
 =?us-ascii?Q?YjS/AIFm78ScPcS9ODUBIOcJBqqlrZTVptshJav8EZ/rwTrKZ+yrocwoSGkR?=
 =?us-ascii?Q?qiajVmzjIQ54EEtRtStVHnfTR2xJ1GJWMiKBYxDbalPAyfIUlke1m8dQDudz?=
 =?us-ascii?Q?cCCyWDMjQEwm2d3eYXJuKfvfKQnEuPFTAyeSfcIv7G0q86D5ATO6GmwgXiO5?=
 =?us-ascii?Q?Qau86VjpB+m5oKIBvCCkC9BK5uJXVnSum+xKi4I4B+EcfCXHkrPuGG/h/5aH?=
 =?us-ascii?Q?rfyUw9/hyqIePEzrdM9tT7mIM1iDFxwddvq4rEkWnRnBYlEffyuPHnI8Y4d2?=
 =?us-ascii?Q?tnu/sQfboZC1IZq6w5vTBCwnNud01AApp4HbiE5bhwKFx7ByBz8fajxrhyUX?=
 =?us-ascii?Q?V6b7rr7sozO2nCepfxEIq4mycAeJXY+VDsIN0DTWRj+Mm07O/goEhcPfFTYj?=
 =?us-ascii?Q?x0SrpvMfhwmg8RvyFYNjNls765/wMjjRmZcxX09OPWp8YSnk1rn2p4jGZwEI?=
 =?us-ascii?Q?Q4BbUxZqvA4rsUHE5ueVeV5653LoU4LsTYmacKPZ5bLFg++HF0c6SMlt2BcY?=
 =?us-ascii?Q?izapcrjPUWp2re94iGxTAvL4CBy2vOHx8O18sZsR2lJohCSVggR5AYpGqStS?=
 =?us-ascii?Q?ifMPlEr+/Ni2zI8jsx9ZUcC77HS3UDdKk2qdk929HSkDnhMS5LlWqITrYKnY?=
 =?us-ascii?Q?tN7AkVTq7fp2d7qEMixFeGbtU/NSCwLmui6km3Ami3PHBS9NQPT7SVQcNj3Y?=
 =?us-ascii?Q?9CJYhCS65aFUy9oJmWOXQxCNyns9wiCyEXfgjWid28H1UPvGbNTat4CYw3FB?=
 =?us-ascii?Q?h2qyYMUL2vB2NVEMYB2CVxorjKMxInAryqcrgp+OPxCvwKXJekQt5uHxN75U?=
 =?us-ascii?Q?GTXEpMagwuJ0I9jlrMOXqrdMvzntSaUDaiLRFQvupVCVh4d3K8n/9niAaa4i?=
 =?us-ascii?Q?J4NI8oXiNZxolsaiwzI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW5PR12MB5598.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 192f6874-78e6-4d12-13d8-08db77aaba9c
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 07:38:56.1416
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wtBCJINkP0rTifT836bH+u0OPhA3P0aM8yiIRoEXc12yT59OZQXb84lyFhbbYTKJT0pLzkDlpnk/iRtjXlkqLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR12MB5429
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Friday, June 16, 2023 1:35 AM
> To: Gaddam, Sarath Babu Naidu <sarath.babu.naidu.gaddam@amd.com>
> Cc: richardcochran@gmail.com; netdev@vger.kernel.org;
> simon.horman@corigine.com; andrew@lunn.ch; linux-
> kernel@vger.kernel.org; vincent.cheng.xh@renesas.com; Katakam, Harini
> <harini.katakam@amd.com>; git (AMD-Xilinx) <git@amd.com>
> Subject: Re: [PATCH V2] ptp: clockmatrix: Add Defer probe if firmware
> load fails
>=20
> On Wed, 14 Jun 2023 10:42:04 +0530 Sarath Babu Naidu Gaddam wrote:
> > Clock matrix driver can be probed before the rootfs containing
> > firmware/initialization .bin is available. The current driver throws a
> > warning and proceeds to execute probe even when firmware is not
> ready.
> > Instead, defer probe and wait for the .bin file to be available.
>=20
> The first-step fix should be to try to get the FW into initramfs.
> For that driver should specify MODULE_FIRMWARE(), which I don't see
> here.

Thanks for the review. We will take MODULE_FIRMWARE as a separate patch.
We want defer probe to go first.

Thanks,
Sarath