Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 09:29:46 +0200
From:   Juerg Haefliger <juerg.haefliger@canonical.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     jk@ozlabs.org, joel@jms.id.au, alistair@popple.id.au,
        eajames@linux.ibm.com, linux-fsi@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsi: master-ast-cf: Add MODULE_FIRMWARE macro
Message-ID: <20230628092946.00958b2c@gollum>
In-Reply-To: <2023062852-spirited-excitable-dabc@gregkh>
References: <20230616122040.1035518-1-juerg.haefliger@canonical.com>
        <2023062852-spirited-excitable-dabc@gregkh>
Organization: Canonical Ltd
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/eK12kAyZl1P/JjFDhv=jm04";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/eK12kAyZl1P/JjFDhv=jm04
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

On Wed, 28 Jun 2023 08:47:12 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Jun 16, 2023 at 02:20:40PM +0200, Juerg Haefliger wrote:
> > The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> > information via modinfo.
> >=20
> > Signed-off-by: Juerg Haefliger <juerg.haefliger@canonical.com>
> > ---
> >  drivers/fsi/fsi-master-ast-cf.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-a=
st-cf.c
> > index 5f608ef8b53c..1316bfd121fe 100644
> > --- a/drivers/fsi/fsi-master-ast-cf.c
> > +++ b/drivers/fsi/fsi-master-ast-cf.c
> > @@ -1441,3 +1441,5 @@ static struct platform_driver fsi_master_acf =3D {
> > =20
> >  module_platform_driver(fsi_master_acf);
> >  MODULE_LICENSE("GPL");
> > +
> > +MODULE_FIRMWARE(FW_FILE_NAME); =20
>=20
> No need for the extra blank line, right?

Guess not.

=20
> And what commit id does this fix?

6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire=
")

Want me to send a v2?

...Juerg


=20
> thanks,
>=20
> greg k-h


--Sig_/eK12kAyZl1P/JjFDhv=jm04
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEhZfU96IuprviLdeLD9OLCQumQrcFAmSb4XoACgkQD9OLCQum
QrfF/xAAgQPQlpulUegyfPVHtutQu0ENPyC6upj7Fh3qeaMacTkdkbexWytuYvYt
huxoS60/1sWnnlyxsKJ5EJcWEBIgIjlLKYKwSRnbodVbtw7nyF+DyYBtSl6K83jC
M/4FpNyTN58mHNf8id6C/TyF7EZC9M/HP2P6+kbpvXF6IgupLshis61JBeQlszB7
7NCkH+7ynvLX0p6kDLQDfssQffVsUryRzfIPkS+zC3YDuLYVqKpwrYh3l/wwOoU/
cpy/tFZ+vrN+yVyfD5Fze2gWm2G5efRPzFoPKWGkcH0/BdGlLaTs+8cUTOl+pi3x
MrP+PWtOFLBZ73ff8K1GvwyFBN01dlJ5bjA3BcD2PbnE9L0Fnoer2NnHgGbqkbpa
XiS0PEK8lCyTvMU8rU2nxJdY1HN65ZST+YDzIr9czz/39VaI9SVwPX5Wzw25tonA
Va3VoVWyZS3uTQNMvDxq8JoQRS6X7kg9+0FgvrE9V+pWsSAvBZGq7hrstIPWRKOZ
4y2WhwoDRmUL2pOSs0LeWo02RLj7ZtqeWjjgOvS1GKw7wGt34d/mQgpynSTPJETn
NB8fUQFxije50adkSz90BR1JqVho2YZaiOHwvtIAUyqaSg4uci1DPaNTUiUNY1We
/DWmqaIXThIf9yt9c5Rb6w3WWTPyFECAkfGHz0TUHg3KC4kg/w8=
=66oP
-----END PGP SIGNATURE-----

--Sig_/eK12kAyZl1P/JjFDhv=jm04--