Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230627130122.1491765-1-kernel@xen0n.name> <20230627130122.1491765-2-kernel@xen0n.name>
 <20230627162456.GA223742@dev-arch.thelio-3990X>
In-Reply-To: <20230627162456.GA223742@dev-arch.thelio-3990X>
From:   Huacai Chen <chenhuacai@kernel.org>
Date:   Wed, 28 Jun 2023 12:22:15 +0800
Message-ID: <CAAhV-H5P1+hToeNFO2Np5v2EorPK4B9Fmh5U4n+aHRDsaOnYcw@mail.gmail.com>
Subject: Re: [PATCH 1/2] LoongArch: vDSO: Use CLANG_FLAGS instead of filtering
 out '--target='
To:     Nathan Chancellor <nathan@kernel.org>
Cc:     WANG Xuerui <kernel@xen0n.name>, WANG Rui <wangrui@loongson.cn>,
        Xi Ruoyao <xry111@xry111.site>, loongarch@lists.linux.dev,
        linux-kbuild@vger.kernel.org, llvm@lists.linux.dev,
        linux-kernel@vger.kernel.org, WANG Xuerui <git@xen0n.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Queued for loongarch-next, thanks.

Huacai

On Wed, Jun 28, 2023 at 12:24=E2=80=AFAM Nathan Chancellor <nathan@kernel.o=
rg> wrote:
>
> On Tue, Jun 27, 2023 at 09:01:21PM +0800, WANG Xuerui wrote:
> > From: WANG Xuerui <git@xen0n.name>
> >
> > This is a port of commit 76d7fff22be3e ("MIPS: VDSO: Use CLANG_FLAGS
> > instead of filtering out '--target=3D'") to arch/loongarch, for fixing
> > cross-compilation with Clang.
> >
> > Reported-by: Nathan Chancellor <nathan@kernel.org>
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1787#issuecomment=
-1608306002
> > Signed-off-by: WANG Xuerui <git@xen0n.name>
>
> Thanks for the patch!
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> > ---
> >  arch/loongarch/vdso/Makefile | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/arch/loongarch/vdso/Makefile b/arch/loongarch/vdso/Makefil=
e
> > index 3f9df4d9930f..a50308b6fc25 100644
> > --- a/arch/loongarch/vdso/Makefile
> > +++ b/arch/loongarch/vdso/Makefile
> > @@ -12,12 +12,9 @@ ccflags-vdso :=3D \
> >       $(filter -E%,$(KBUILD_CFLAGS)) \
> >       $(filter -march=3D%,$(KBUILD_CFLAGS)) \
> >       $(filter -m%-float,$(KBUILD_CFLAGS)) \
> > +     $(CLANG_FLAGS) \
> >       -D__VDSO__
> >
> > -ifeq ($(cc-name),clang)
> > -ccflags-vdso +=3D $(filter --target=3D%,$(KBUILD_CFLAGS))
> > -endif
> > -
> >  cflags-vdso :=3D $(ccflags-vdso) \
> >       -isystem $(shell $(CC) -print-file-name=3Dinclude) \
> >       $(filter -W%,$(filter-out -Wa$(comma)%,$(KBUILD_CFLAGS))) \
> > --
> > 2.40.0
> >