Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 09:32:14 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Min Li <min15.li@samsung.com>
Cc:     axboe@kernel.dk, willy@infradead.org, hch@lst.de,
        dlemoal@kernel.org, gregkh@linuxfoundation.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        stable@kernel.org
Subject: Re: [PATCH v3] block: add check that partition length needs to be
 aligned with block size
Message-ID: <20230628073214.GA25314@lst.de>
References: <CGME20230628051122epcas5p45d70f2c36ce91b60863f702de1534321@epcas5p4.samsung.com> <20230628130941.10690-1-min15.li@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230628130941.10690-1-min15.li@samsung.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Wed, Jun 28, 2023 at 01:09:41PM +0000, Min Li wrote:
> +	long long blksz = bdev_logical_block_size(bdev), start, length;

long long for the blocksize is a bit weird here, as the value is
an unsigned int.

Also while pre-existing the long long for start/length looks weird,
do we need to check for negative values somewhere?

Also don't forget the Cc stable that Greg requested.