Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 13:18:34 +0800
From:   Aaron Lu <aaron.lu@intel.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Deng Pan <pan.deng@intel.com>, <tim.c.chen@intel.com>,
        <vincent.guittot@linaro.org>, <linux-kernel@vger.kernel.org>,
        <tianyou.li@intel.com>, <yu.ma@intel.com>, <lipeng.zhu@intel.com>,
        <yu.c.chen@intel.com>, Tim Chen <tim.c.chen@linux.intel.com>
Subject: Re: [PATCH v2] sched/task_group: Re-layout structure to reduce false
 sharing
Message-ID: <20230628051419.GA565419@ziqianlu-dell>
References: <20230621081425.420607-1-pan.deng@intel.com>
 <20230626054756.GA435374@ziqianlu-dell>
 <20230627101437.GY4253@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230627101437.GY4253@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yCgG031hpcxeaiJe1thTSJsEd1MXvL5Sl8f2s5uR5w07tgGDKxeoxqwa1m/j?=
 =?us-ascii?Q?PR63uTkAdgHvyRd3+vcrS4Zx5werWopqzIqiv91AsbbXXdDrvF+f+t1mtjY9?=
 =?us-ascii?Q?4o5O4LwJHxomaeC22f61IkVVNsNHGS5gsRwG4BUccdIDgKoblWga6A4mwbvP?=
 =?us-ascii?Q?UeYZrgDEPtQ5iOIzlLXHTFkge8DOJDqpItfzGp0ddeD3fZ4QGLA2gTlPlQs9?=
 =?us-ascii?Q?XyERJrAhIc3Li+In71FtNJZjSJ8t0pyDWxBmrYAQBZQ2UXAx9CEosABSD/jh?=
 =?us-ascii?Q?ZjJt/NvPSwcNC/gzOUQHwGnXtia9jTUZqMpcH8VGBahyrmzS1cmYHnGEIvb0?=
 =?us-ascii?Q?VUW2RT1EQH5mqU57+MHqKCRf1U/cyhxGsITmd+L/VEpZ8febV0S0zMkE1QuA?=
 =?us-ascii?Q?FF5aEu1zvvxiS+aJjBTCWbyVv4lvilXMoECjDYSpDiMZommBx5OVS/h/dh2m?=
 =?us-ascii?Q?DmtlC8gBfii9lVM2M/15mPPREDupcvAY3lThopXVvRo6Sdw01XimSiv6aGpG?=
 =?us-ascii?Q?Vd7eKbl8qEDQHOeR85YS8QwgNJZF5r+WWJfWuamUBKg/RxWEVgCdN1tcyMuP?=
 =?us-ascii?Q?fSy3w4/+PLK098wOFlphgwYppq9s1kP1uAtP67UKdAKWGepkcvYxUiIPZo5y?=
 =?us-ascii?Q?+8EXBz6BL6aM2w5ewRH+jZIuNOIGlHvfx7U8tRPf6XpBkEiLYJq1r2sFDKI7?=
 =?us-ascii?Q?HWlsfG6y12iWKouqzAdJ3a4wX2mgRVp3n17LYFsWYZ9w3SNTnUTn6Q8/I72d?=
 =?us-ascii?Q?M9hI1qx7+ahp6kNH7N6btguW9ne7r1SgDM4q7YHeesKhYOz5NVg4LAwXMm/V?=
 =?us-ascii?Q?0+obzvGSifVhNl6uHaEfwJLawAwz+jTBvm+7I2Wfd+mRdq7ibi9zuzRqTm72?=
 =?us-ascii?Q?H93XbDLluG67MsUjeIZYlK+JYrVANcYFPzoqF/r3DajT6gJsxk+t1YRexfAU?=
 =?us-ascii?Q?Y95u/68iBZpYZsph+6vNW/8jKc5OeyvW1eJw8vVzoYkYqfFJKx+0oQSX/dc8?=
 =?us-ascii?Q?KCjMBrNy6MoVmvz3+XR2bNRCIPYP6PKdFMhJMrO6HCWbizIwSaoNU1Ocuob6?=
 =?us-ascii?Q?xHjzMg4cG8V/xdVLA/vJEK79XZi4IvhzxAUdmqndOhMAYulMJIPKXD+tZgBN?=
 =?us-ascii?Q?0U52DJMBoSu/hjL2LAM3U5zotpubKIdr9XAxWOjZtBTdgClorGssQ7rPWybz?=
 =?us-ascii?Q?fXaC3O6NOm53EviqY9eorT2qTvy/tzynyZnqqgVxrc6dBffWiOfrPMtozWVy?=
 =?us-ascii?Q?TaWaOpvazL509CGQCO1JKcGU1gPoZXZp7I/pbp/f14qfKe8mOCCTp136zj6z?=
 =?us-ascii?Q?L5FpEUCpsP9Usd6Sw8e/rc0BK/QvSMFCwOFr8/Gf8iMwV42EN9V08PfVBU2J?=
 =?us-ascii?Q?QiQS+vkcqv3hNflgq5DWabOka01+6g4I70+jrPwZR/HxuWUUCRW6K7oCiDpq?=
 =?us-ascii?Q?UlrB1l+JfzjP6U6+y4PqkaSzr6YdI5ZK80L1fFiISB51uKQb7FK+jLvahfCh?=
 =?us-ascii?Q?QQ0ddtPVgYJZ63fcmHLi8CGd3t4gJxSRyzHlOuaCTW8yc47I/q5UHrx1BhYM?=
 =?us-ascii?Q?P+9mvPb7b8trsO5NVDjwV5pKNcC96WMpCApiAJie?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 38b6f095-7c10-4d75-4f0f-08db77972622
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3062.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 05:18:47.0141
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8c/42PWlFmDisBEGc4Hg3jY1pm9wAC4xCOOr4TIOijEst+eklxYfgHMcSFzITOafN/M1kjsigQ/8kylhZxGOcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6316
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 27, 2023 at 12:14:37PM +0200, Peter Zijlstra wrote:
> On Mon, Jun 26, 2023 at 01:47:56PM +0800, Aaron Lu wrote:
> > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
> > index ec7b3e0a2b20..31b73e8d9568 100644
> > --- a/kernel/sched/sched.h
> > +++ b/kernel/sched/sched.h
> > @@ -385,7 +385,9 @@ struct task_group {
> >  	 * it in its own cacheline separated from the fields above which
> >  	 * will also be accessed at each tick.
> >  	 */
> > -	atomic_long_t		load_avg ____cacheline_aligned;
> > +	struct {
> > +		atomic_long_t		load_avg;
> > +	} ____cacheline_aligned_in_smp;
> >  #endif
> >  #endif
> > 
> > This way it can make sure there is no false sharing with load_avg no
> > matter how the layout of this structure changes in the future.
> 
> This. Also, ISTR there was a series to split this atomic across nodes;

Yes.

> whatever happend to that, 

After collecting more data, the test summary is:
- on SPR, hackbench time reduced ~8% and netperf(UDP_RR/nr_thread=100%)                                                
  performance increased ~50%;                                                                                          
- on Icelake, performance regressed about 1%-2% for postgres_sysbench                                                  
  and hackbench, netperf has no performance change;                                                                    
- on Cascade Lake, netperf/UDP_RR/nr_thread=50% sees performance
  drop ~3%; others have no performance change.

So it is a win for SPR and has small regressions for Icelake and Cascade
Lake. Daniel tested on AMD machines and he also saw some minor
regressions. The win for SPR is most likely due to the per-node
tg->load_avg patch made all CPUs contending on the same cacheline to
contending on two cachelines and that helped SPR because when many CPUs
contending on the same cacheline, SPR is likely to enter the "Ingress
Queue Overflow" state and that is bad for performance. I also did some
experiments on a 2 sockets SPR to place the two per-node tg->load_avg on
the same node and I also saw similar performance improvement.

Based on the test results and the reason why SPR sees improvement, I
didn't continue to push it.

Another thing: after making tg->load_avg per node, update_tg_load_avg()
is strictly local, that's good but update_cfs_group() needs to read all
counters on each node and that means it will still cause the per-node
tg->load_avg bounce across nodes and update_cfs_group() is called very
frequently. I suppose it's where those small regressions come from but
the solution is not obvious.

> and can we still measure an improvement over this with that approach?

Let me re-run those tests and see how things change.

In my previous tests I didn't turn on CONFIG_RT_GROUP_SCHED. To test
this, I suppose I'll turn CONFIG_RT_GROUP_SCHED on and apply this change
here that made tg->load_avg in a dedicated cacheline, then see how
performances change with the "Make tg->load_avg per node" patch. Will
report back once done.

Thanks,
Aaron