Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 13:56:36 +0800
From:   Xu Yilun <yilun.xu@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Peter Colberg <peter.colberg@intel.com>, hao.wu@intel.com,
        gregkh@linuxfoundation.org, linux-fpga@vger.kernel.org,
        linux-kernel@vger.kernel.org, aaron.j.grier@intel.com,
        tianfei.zhang@intel.com, russell.h.weight@intel.com,
        matthew.gerlach@linux.intel.com, marpagan@redhat.com,
        lgoncalv@redhat.com
Subject: Re: [PATCH v2] fpga: dfl: afu: use PFN_DOWN() and PFN_PHYS() helper
 macros
Message-ID: <ZJvLlHpJwr/tv3gq@yilunxu-OptiPlex-7050>
References: <2023061908-subscribe-persuader-9b9f@gregkh>
 <20230619195634.11366-1-peter.colberg@intel.com>
 <ZJqBE1mCjSaRIvyt@yilunxu-OptiPlex-7050>
 <ZJspBy/imk1qH+s2@smile.fi.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZJspBy/imk1qH+s2@smile.fi.intel.com>
Precedence: bulk

On 2023-06-27 at 21:23:03 +0300, Andy Shevchenko wrote:
> On Tue, Jun 27, 2023 at 02:26:27PM +0800, Xu Yilun wrote:
> > On 2023-06-19 at 15:56:34 -0400, Peter Colberg wrote:
> 
> ...
> 
> > > -	int npages = region->length >> PAGE_SHIFT;
> > > +	int npages = PFN_DOWN(region->length);
> > 
> > I don't much prefer this change, it is not doing the phy addr to pfn
> > convertion. The macro name doesn't match what is doing here.
> 
> This macro converts length to pages. And it's not about phy addr.

You are right.

> > > -	offset = vma->vm_pgoff << PAGE_SHIFT;
> > > +	offset = PFN_PHYS(vma->vm_pgoff);
> > 
> > ditto. The variables are offsets within file, not phys addr & pfn.
> 
> Here I probably can agree.

OK. Remove this one, and others LGTM.

Thanks,
Yilun

> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>