Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7fe4adef-9be2-6dae-d53f-692f9775439c@ti.com>
Date:   Wed, 28 Jun 2023 13:50:42 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2-main: Enable support for
 SDR104 speed mode
To:     Bhavya Kapoor <b-kapoor@ti.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <robh+dt@kernel.org>,
        <kristo@kernel.org>, <vigneshr@ti.com>, <nm@ti.com>,
        <u-kumar1@ti.com>
References: <20230412121415.860447-1-b-kapoor@ti.com>
Content-Language: en-US
From:   "Kumar, Udit" <u-kumar1@ti.com>
In-Reply-To: <20230412121415.860447-1-b-kapoor@ti.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 4/12/2023 5:44 PM, Bhavya Kapoor wrote:
> According to TRM for J721S2, SDR104 speed mode is supported by the SoC
> but its capabilities were masked in device tree. Remove sdhci-caps-mask
> to enable support for SDR104 speed mode for SD card in J721S2 SoC.
>
> [+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
> - https://www.ti.com/lit/zip/spruj28
>
> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> Changelog v1->v2:
> 	- Modified Commit Message and Added Fixes tag
>
> Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/
>
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 8915132efcc1..95c6151ed10c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
>   		ti,clkbuf-sel = <0x7>;
>   		ti,trm-icp = <0x8>;
>   		dma-coherent;
> -		/* Masking support for SDR104 capability */
> -		sdhci-caps-mask = <0x00000003 0x00000000>;


Reviewed-by: Udit Kumar <u-kumar1@ti.com>

>   	};
>   
>   	main_navss: bus@30000000 {