Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1687515463.git.haibo1.xu@intel.com> <47f0502d076c071260a87953cbabadfc85d278cf.1687515463.git.haibo1.xu@intel.com>
 <20230627-adcb173b3ee813e2e16353bd@orel>
In-Reply-To: <20230627-adcb173b3ee813e2e16353bd@orel>
From:   Haibo Xu <xiaobo55x@gmail.com>
Date:   Wed, 28 Jun 2023 14:00:57 +0800
Message-ID: <CAJve8onuBoOOOL4yp3wTTsBMqxf4MZL6uUjgMBjUmWsTO61A2g@mail.gmail.com>
Subject: Re: [PATCH v4 09/12] KVM: selftests: Only do get/set tests on present
 blessed list
To:     Andrew Jones <ajones@ventanamicro.com>
Cc:     Haibo Xu <haibo1.xu@intel.com>, maz@kernel.org,
        oliver.upton@linux.dev, seanjc@google.com,
        Paolo Bonzini <pbonzini@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Anup Patel <anup@brainfault.org>,
        Atish Patra <atishp@atishpatra.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Shuah Khan <shuah@kernel.org>,
        James Morse <james.morse@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Ben Gardon <bgardon@google.com>,
        David Matlack <dmatlack@google.com>,
        Ricardo Koller <ricarkol@google.com>,
        Vishal Annapurve <vannapurve@google.com>,
        Vipin Sharma <vipinsh@google.com>,
        Colton Lewis <coltonlewis@google.com>, kvm@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org,
        linux-kselftest@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jun 27, 2023 at 5:11=E2=80=AFPM Andrew Jones <ajones@ventanamicro.c=
om> wrote:
>
> On Fri, Jun 23, 2023 at 06:40:11PM +0800, Haibo Xu wrote:
> > Only do the get/set tests on present and blessed registers
> > since we don't know the capabilities of any new ones.
> >
> > Suggested-by: Andrew Jones <ajones@ventanamicro.com>
> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com>
> > ---
> >  tools/testing/selftests/kvm/get-reg-list.c | 29 ++++++++++++++--------
> >  1 file changed, 18 insertions(+), 11 deletions(-)
> >
> > diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing=
/selftests/kvm/get-reg-list.c
> > index b956ee410996..3beb6b62de0a 100644
> > --- a/tools/testing/selftests/kvm/get-reg-list.c
> > +++ b/tools/testing/selftests/kvm/get-reg-list.c
> > @@ -52,6 +52,10 @@ extern int vcpu_configs_n;
> >       for_each_reg_filtered(i)                                         =
       \
> >               if (!find_reg(blessed_reg, blessed_n, reg_list->reg[i]))
> >
> > +#define for_each_present_blessed_reg(i)                      \
> > +     for ((i) =3D 0; (i) < blessed_n; ++(i))           \
> > +             if (find_reg(reg_list->reg, reg_list->n, blessed_reg[i]))
> > +
> >  static const char *config_name(struct vcpu_reg_list *c)
> >  {
> >       struct vcpu_reg_sublist *s;
> > @@ -189,6 +193,16 @@ static void run_test(struct vcpu_reg_list *c)
> >               return;
> >       }
> >
> > +     for_each_sublist(c, s)
> > +             blessed_n +=3D s->regs_n;
> > +     blessed_reg =3D calloc(blessed_n, sizeof(__u64));
> > +
> > +     n =3D 0;
> > +     for_each_sublist(c, s) {
> > +             for (i =3D 0; i < s->regs_n; ++i)
> > +                     blessed_reg[n++] =3D s->regs[i];
> > +     }
> > +
> >       /*
> >        * We only test that we can get the register and then write back =
the
> >        * same value. Some registers may allow other values to be writte=
n
> > @@ -198,8 +212,11 @@ static void run_test(struct vcpu_reg_list *c)
> >        * be written need to have the other values tested, then we shoul=
d
> >        * create a new set of tests for those in a new independent test
> >        * executable.
> > +      *
> > +      * Only do the get/set tests on present, blessed list registers,
> > +      * since we don't know the capabilities of any new registers.
> >        */
> > -     for_each_reg(i) {
> > +     for_each_present_blessed_reg(i) {
> >               uint8_t addr[2048 / 8];
> >               struct kvm_one_reg reg =3D {
> >                       .id =3D reg_list->reg[i],
> > @@ -242,16 +259,6 @@ static void run_test(struct vcpu_reg_list *c)
> >               }
> >       }
> >
> > -     for_each_sublist(c, s)
> > -             blessed_n +=3D s->regs_n;
> > -     blessed_reg =3D calloc(blessed_n, sizeof(__u64));
> > -
> > -     n =3D 0;
> > -     for_each_sublist(c, s) {
> > -             for (i =3D 0; i < s->regs_n; ++i)
> > -                     blessed_reg[n++] =3D s->regs[i];
> > -     }
> > -
> >       for_each_new_reg(i)
> >               ++new_regs;
> >
> > --
> > 2.34.1
> >
>
> Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
>
> Thanks,
> drew

Thanks for the review!