Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3bd72a0-6c19-b874-9942-2fc1e1f9a20b@redhat.com>
Date:   Wed, 28 Jun 2023 11:07:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH] mm/ksm: delete the redundant ksm_merging_pages interafce
 in proc
Content-Language: en-US
To:     xu xin <xu.xin.sc@gmail.com>, sunnanyong@huawei.com
Cc:     akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org, wangkefeng.wang@huawei.com,
        yang.yang29@zte.com.cn, xu.xin16@zte.com.cn
References: <20230627133542.2446285-1-sunnanyong@huawei.com>
 <20230628031233.9734-1-xu.xin16@zte.com.cn>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <20230628031233.9734-1-xu.xin16@zte.com.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 28.06.23 05:12, xu xin wrote:
>> Message-ID: <20230627133542.2446285-1-sunnanyong@huawei.com> (raw)
>>
>> Since the ksm_merging_pages information already included in
>> /proc/<pid>/ksm_stat, we can delete /proc/<pid>/ksm_merging_pages to
>> make the directory more clean, and can save a little bit resources.
> 
> I think it's ok to remove it because this interface was not proposed for a long time.
> I believe its users are not many yet. The earlier we delete it, the better.
> 

Well ... it's been around since v5.19, which was released 1 year ago.

... not sure if the removal is worth the possible user space break.

-- 
Cheers,

David / dhildenb