Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <55cece9b-b4b8-854c-f948-2e30895f36b0@nvidia.com>
Date:   Wed, 28 Jun 2023 10:58:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH] arm64: dts: tegra: drop serial clock-names and
 reset-names
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230123151543.369724-1-krzysztof.kozlowski@linaro.org>
From:   Jon Hunter <jonathanh@nvidia.com>
In-Reply-To: <20230123151543.369724-1-krzysztof.kozlowski@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1dSRzIwckI0clRGczRVYlNmUXZvMUNxdkF2c0NwMUV4UG1UUVE2ME1BT3dR?=
 =?utf-8?B?K0dOdk9tTUVUbFR0MTZrQ1lnbWFiM1pOWjhyaTd5cUdNejdaK09oZXpqTTBm?=
 =?utf-8?B?a1dpVnptb1gzbENOS3h3eFVLeGhBMXNFenBwOVpWaU13ZHBtUDRmRkZFU2xk?=
 =?utf-8?B?Z1dadEROUnJ1L3dtZEd4Wk9aUmxMblZtUkltWlM2U3hGOHBuNDlJNnQ1aHk2?=
 =?utf-8?B?N0crZ1g2aDY5eEU1WkxUY2c2b2lNdXhEejB2TzdKZGlzbHV3Vk5DSmo5aDU3?=
 =?utf-8?B?UG5JclY2ay9jaE94bkFEL1BrMTFabFg2SXhkSlVOcEZWS25QbCtGTWNURHkz?=
 =?utf-8?B?VkFyZ3B3NHllRnVMeVZOdjMvQ1RDb2s5NktieGRXTGVzRW80N1d0d0lXbFUz?=
 =?utf-8?B?VFgySWNxNU1NVytyNnE2eFBsT2NSK1RVQk1ZQzlLZVR3am5POCt4eDFJZkpp?=
 =?utf-8?B?YldhK21BUFhJdDJlaENwQ01yY3ZjSFpsNU1MQlpYT2tUdUlON1IvOHFlaFZN?=
 =?utf-8?B?dEg4M2x2aU1vcXRTdjIxSURtZXdKb0FnVXhrNkJ6SDMzcUNNT0pkcVJMSVY1?=
 =?utf-8?B?ek1oZ09RV2d1b0ZwMEh4M3RQR292T21OZ0FRQWdncko2Q0laTXVZcCt4ditu?=
 =?utf-8?B?QWhpVzd4TjVoZ240K1lUaDJ3enREU1R3QjYycVdGaS9HUjhLVk5MMXR1SVVB?=
 =?utf-8?B?Y0l4cXFmbnRIYnhQU2crVENkQzY1T3luRUZwY1Bqb2tlTU5tQXU3OXBzbmsr?=
 =?utf-8?B?NG5sM2g5TlB3b2tXUzNFeUFTRnI1b2hzd3BPQzFRdGdaOHptVEErWmVjY1Za?=
 =?utf-8?B?T25MTldCUVNCd3ZJVjg5S1ZxRnczeEtoM2hrQjFaVWJRSnVSbFJnTFFJRG5l?=
 =?utf-8?B?ZTh3RWhGYjEvZWRuS0wwaUZwVHU4aSt6YTdjeWlWSHNURmw5bUxOa1RET0tG?=
 =?utf-8?B?ZDNJQytKOVlpTy9UaUtPMjdaKzVtYVlqUjRYNnYxYW9kV0t2WjNFdU1laXIy?=
 =?utf-8?B?MlJLbkNtc0habnRUK3ltZU5jc00zaEJWTkR3UEE4MGZIemtsSmJYbTB1Q2pF?=
 =?utf-8?B?cVdibDFJdk1nSmgwcmRBaThSMmUvaHRIMHNQS0p2QjJnZURvK1h2RytsQm0z?=
 =?utf-8?B?NjlTWDNjTjFyOEh6Y0JFblNTUEFNVll6ZTJlbisxL0w1RHZxR3N1MmRuek4x?=
 =?utf-8?B?MWtacjJlUUJ1QWpSbXBqMWgxSzZyb3V2OHNwS3JEZ0IxTEpNZ3IwRkJ2cDEr?=
 =?utf-8?B?U1lpUnZ5VlBRcEdRNXFqSkpXM1ltOFhpYTNnVnpPeE5xenp1UXBNR2hXM0JR?=
 =?utf-8?B?ZndBRXlBaWtjeGRWcTV1TWJOS3ZkbVFXdmN0Vnc0UVF3NVdJR0tmOVZHb3l2?=
 =?utf-8?B?Y0FjSG1rQnVNVFRjVGR4dHNoK1FhaUlnR0dXRlpNZTMyMHFVQ0gwU1RiTC9H?=
 =?utf-8?B?SXpXZFJiYUNBUlFBS1VpeWRWdENvcXF0REY0aHVuajFrclRTdkFUMjJyWjZj?=
 =?utf-8?B?bWhzM011OU9lU1kxM1BXYmhab1ZpVkRtMzZxd05hdURGRVBxdUZ0L3RRM0pQ?=
 =?utf-8?B?K3FsOGlmNzZPNVhiWG1BVHovVzBjVW5nZVIxQ0NjZko5cmlZMzlBL0dJWXJT?=
 =?utf-8?B?Y2Z6QmUxcXZWNHE0Mm1nSnNpRVpMSUlFVDdUd000NFFuSjFvYzlXdkZrdkU2?=
 =?utf-8?B?T2NHNkNKY0xYY0JoR2dDNFJwVURyOGNMU0k0T3pMeUkxMzRKSFI0bjZ4SlBV?=
 =?utf-8?B?Q21EdWJxRjlnMG02Sjl2d1ZFUk1yaXo3Q2hlcU5aM3M1REdOZGw0bEw1OEZV?=
 =?utf-8?B?YVVpZGU2WlZKTFR6TkZuNWxlVGN5OXV6S1VaQlpka3p4dUEyMFQrRnFEYWpl?=
 =?utf-8?B?TXNjL0FVdjg5YnR2aWVQVGw5MFFBSkpIVWNCbEttRDlaa1F4L2U2enZ4TjBh?=
 =?utf-8?B?ZUtuMjRLY3hSTjR1NFVTVnA1dXNnSkpkVk5YaW5Sc0g1ZnZmTFZYTEkxNFJs?=
 =?utf-8?B?eDhsMjQybzRNTmJ1QlNUNkVIVTlRdGZmZU9taUVPNm5OazJkaTBUT0NmYzNo?=
 =?utf-8?B?LzQ0Nk9oSzlTZkViU1ZKanB6b2l1b3FEa3F3dG4rK2ljSk4xUGE3ZlJ2ZmRQ?=
 =?utf-8?B?ZVE0QlRxV3diTlVvUS91emhhcklHNHB5MXAzMmxucWJKQnJwMlQybjAyZVYv?=
 =?utf-8?B?ZzAxSW5HRTVhejdVWDlsbUczNnNpRXBXVWZhWnFGRVlZQVRudkFSRnFTRjRH?=
 =?utf-8?B?bTlYU2dMS2U2Qkh6MWZrZ0FTRkFnPT0=?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c38960c-4646-4db0-b7b4-08db77be4a8e
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5444.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 09:58:58.5042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 27Rkai4LAw/Mj3iEXjP/hKnvsDWWZbb7H6NKXbn708KEQvuZg419BRhpDC9hSdaXEbOAMMSBwJbsVm+9hTPxWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7586
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 23/01/2023 15:15, Krzysztof Kozlowski wrote:
> The serial node does not use clock-names and reset-names:
> 
>    tegra234-sim-vdk.dtb: serial@3100000: Unevaluated properties are not allowed ('clock-names', 'reset-names' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>   arch/arm64/boot/dts/nvidia/tegra132.dtsi | 8 --------
>   arch/arm64/boot/dts/nvidia/tegra186.dtsi | 2 --
>   arch/arm64/boot/dts/nvidia/tegra194.dtsi | 4 ----
>   arch/arm64/boot/dts/nvidia/tegra210.dtsi | 8 --------
>   arch/arm64/boot/dts/nvidia/tegra234.dtsi | 2 --
>   5 files changed, 24 deletions(-)

...

> diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> index b54353f31df5..372be226a7f4 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi
> @@ -676,9 +676,7 @@ uarta: serial@3100000 {
>   			reg = <0x0 0x03100000 0x0 0x10000>;
>   			interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
>   			clocks = <&bpmp TEGRA234_CLK_UARTA>;
> -			clock-names = "serial";
>   			resets = <&bpmp TEGRA234_RESET_UARTA>;
> -			reset-names = "serial";
>   			status = "disabled";
>   		};
>   


Thierry, do you have a patch to convert the Documentation/devicetree/bindings/serial/nvidia,tegra20-hsuart.txt to yaml? I have noticed that the above change now cause the hsuart to fail on Tegra234 ...

[    5.109961] serial-tegra 3100000.serial: Couldn't get the reset
[    5.116302] serial-tegra: probe of 3100000.serial failed with error -2

The drivers/tty/serial/serial-tegra.c driver is making the following call ...

  tup->rst = devm_reset_control_get_exclusive(&pdev->dev, "serial");

May be the correct fix for this would be to populate the reset-names in ...

diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
index cd13cf2381dd..513cc2cd0b66 100644
--- a/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
+++ b/arch/arm64/boot/dts/nvidia/tegra234-p3737-0000+p3701-0000.dts
@@ -2010,6 +2010,7 @@ interrupt-controller@2a40000 {
  
                 serial@3100000 {
                         compatible = "nvidia,tegra194-hsuart";
+                       reset-names = "serial";
                         status = "okay";
                 };

I can send a patch.

Jon

-- 
nvpublic