Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp18999741rwd; Wed, 28 Jun 2023 03:46:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ635PdmBHsoCTUAZK4vlnV5lEjvOxkSQjhTVMCWZLpFA3Rc6FKGChZUzbHowTjFuHBtXbj4 X-Received: by 2002:a05:6808:114d:b0:3a0:5724:1cc4 with SMTP id u13-20020a056808114d00b003a057241cc4mr21171640oiu.28.1687949216571; Wed, 28 Jun 2023 03:46:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687949216; cv=none; d=google.com; s=arc-20160816; b=ndhrP3nco9gf1j28mbzeg0JZRCZxJTNw74DdE63YljMIlsOR+73U836EEc0oJ0jgCw 6/V0kITswv4R61lllXZV1YPzaYM1h3GbxMVpHVLOKQdmFHGncL4kr74Dt30HKGTYNbJL 5vxUJ3Pys85Ny8QMwCAwmMgzWjq9Uy50bFegmz/pbPGX30SC0tOx4tHlRvQoN93m5nbY wpt07il/ZIvV3ecF+r8Ce1SaBjhG9Am66QNB8RmnRhwfy4cUR1gUNoYa740aLLxAD+WS 7VjAA9Yv+59QrpYOUq/m8xtiqYDVpF52O/H1asYqPQI15/ZbBp2Xl0qWpbngTTaXwYdo /KQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rs013m832eycdbI7wI/qncGLxYKg/qYM1dV7Gd0Gkgs=; fh=TvvQr21SD4h1b7iVN2olUSrWR8QVaoyzQ5yCJdBNZCM=; b=yt4is9oYkmK8i/QwgxjbTka3GxSPtfKR6KAUDex4xzvNPCu6Wi6H5jKIvifaMp0CIw P+Vfs6onNSLyKJqLgJk/VMZdIyxwuuA/77uVTLE1JGH+R0S3OQM3EGRpoEgBI4nou92y UTu+BHukfAg2OODdiy8er0+b76S3884+fjaYf+p0mhP+K7zmIti7zZmeQ5kA87miRSvL +FsXDlB0twXmtQha/NZ2o/TUGlXtpYcFFrWJUwuVw60YCJFqDdFYgdbD1hSeDDBTWu9v DzZs20TId3U3Mk8Nzd7flUSsvDuB+rx7Ila26IC/NXfLqrzVHgvV1kVs8qklYChQTZNE Deig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=PzravfTD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t14-20020a17090aae0e00b002632c1fc68dsi2082459pjq.72.2023.06.28.03.46.44; Wed, 28 Jun 2023 03:46:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=PzravfTD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjF1Jvn (ORCPT + 99 others); Wed, 28 Jun 2023 05:51:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234601AbjF1Jcg (ORCPT ); Wed, 28 Jun 2023 05:32:36 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C6353591; Wed, 28 Jun 2023 02:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rs013m832eycdbI7wI/qncGLxYKg/qYM1dV7Gd0Gkgs=; b=PzravfTDeMUsb+TMMGGGfXMNm0 /Z81cqwcqFlZ4wnimgB3S34jrQT7TtJDfeNsq0Rp9+51TvLQeQ5POCJ63GZ/JsrYDBF/FjJg24ZON +Y1FYmcuOWNYI6Fd9s+USoL1cvMYY/KCPFyQN8f+R7PvI5kHiCzoK5vYgDe+rwVf33838Ax7S0h9u j9LFUmpfLdCXULlE0/kBb/6VitpuGNSBFPrSz9JdbQpAWykCCuzGgfB1rsnSaRrFGLoCDs5SDYmSu LS4a38URAovV4wOLKbjiT9EQeptPqZvIcMJ/6JUG9cM6eEscXGPuj696IVXcaeus6KbfXR35xL+/Q TfGlmw1Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qEOPB-00EwSc-18; Wed, 28 Jun 2023 06:11:53 +0000 Date: Tue, 27 Jun 2023 23:11:53 -0700 From: Christoph Hellwig To: "zhaoyang.huang" Cc: Alexander Viro , Andrew Morton , Matthew Wilcox , Vlastimil Babka , Yang Shi , Suren Baghdasaryan , Yu Zhao , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , ke.wang@unisoc.com, Christian Brauner Subject: Re: [PATCH] mm: introduce statistic for inode's gen&tier Message-ID: References: <1687857438-29142-1-git-send-email-zhaoyang.huang@unisoc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1687857438-29142-1-git-send-email-zhaoyang.huang@unisoc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2023 at 05:17:18PM +0800, zhaoyang.huang wrote: > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -434,6 +434,8 @@ struct address_space { > struct rb_root_cached i_mmap; > struct rw_semaphore i_mmap_rwsem; > unsigned long nrpages; > + atomic_long_t gen; > + atomic_long_t tier; This increases the size of the inode by 16 byes, and better have really good data supporting it, as increases of the inode size impact a lot of workloads.