Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19008784rwd; Wed, 28 Jun 2023 03:56:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ce4Vwt3NUrIADedcQoW8QN+W1s7bOYOwkUoBQR0XfLPa34v2UZVakEL6ikyR7wOaHRjiu X-Received: by 2002:a17:907:3685:b0:973:c070:1b5f with SMTP id bi5-20020a170907368500b00973c0701b5fmr28364899ejc.44.1687949807973; Wed, 28 Jun 2023 03:56:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687949807; cv=none; d=google.com; s=arc-20160816; b=aSSwgUsSH7Hoso14MP25qGzcXdMWxXp3pnIExqkyHaHrmwAbewahwUjSdaQMUGXu7p D4+S4F6ijmtB5j3SMJc+Lbf3aChphWNe4KiZqPTTolB0lIL26m96p1UGpM90WwGE8E1o qGfGwxraBdpBBdRxH19OEsE5HvdcSEPQ7QcnGHKh2CLqanZzZQLGh63Xi5uBLz0Rx8MI b9dOlxEA45nbntu7qDCeDh1l7XuAS/Zn8/W16AO77OqBx6OwMaoVHKMIXpqPYiAKwOsx E5QYhb0ETryLqSUhMEFApAeAfyy6RGei5VM9Nv5/ioU0fVIfw4uWpxibYr8Upd13H5Xn XATw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pbu/OOzJC/tKjDOWnlqTLd5u/08Dd7bcxM59wL3dQds=; fh=/ARdy6x7Xfz0Ylo4VKbaofevnXq08g1WQTLzh5d3eMc=; b=vlEyD5R2NZhnvJ9l9BnnMOTafyI0Dgo622iCJoGt8EGzo+e+W8/WRYR7M4NqxKK9Iy dJujh24mk31b9rvlaoTrkNnCHQqBDSkBS+DvANdCGGj9HajlBU4ieXoP6vAO8QbPSY4o mPqVm8GWjgSt1hx/YfmTEcWU83ZXQmyomZ0TYp46/i+J1+NsUyu0uoHmXzp4WfF0dJf0 JynVRnlVAaTn3x5bv2bfFzZ5psLJgKM2iEjhdcBjPHOjgzfrf7UVhCC13YdvfuipFq4H H9L3guhMio4QqFrJD3HO42SCR5IjisLODjuYIfcfMP9Bzw8t1f4nXghDs33LN5ROzkQR hEkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hshj4b30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm6-20020a170906c04600b0098d861faa62si5209044ejb.81.2023.06.28.03.56.22; Wed, 28 Jun 2023 03:56:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=hshj4b30; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbjF1Km4 (ORCPT + 99 others); Wed, 28 Jun 2023 06:42:56 -0400 Received: from mga05.intel.com ([192.55.52.43]:57087 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230481AbjF1Kks (ORCPT ); Wed, 28 Jun 2023 06:40:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687948848; x=1719484848; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=2Zmhe10xKcWrQRM+knMSqhQmXAMpUf7kd2FjgsGcrkY=; b=hshj4b30L4r6KWirqS/lPTh/EGPA9UtAGKed1hsR1GY4jCDK2lSumDOH jBK89CLhX4/Sl3ax5RpkSr3EgJl9EikKUSXluMtxdG9EYv9FVRDqh4GSv N5R/QVXpIwbjI8G81BZdbZJmVrsXej8uyGqVdQOtWbJBuEwJd17ain2Dc X8+3KxRgbLz80yGbGumnC3pHOIIVVrVFMCDtAcVKfUonKvNFK07Rn8Uu3 LloEH5woG66vVMR3uyJJXcFpPUhcAbxphiMhhQ1QBud/i/DZ5+qA4037Y Yft1E+JgAbB95TC7Ax3uZVTzz46jNJhyQA5i49hGW2rUiuWERrcYtEzbT A==; X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="448193894" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="448193894" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2023 03:40:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10754"; a="667067110" X-IronPort-AV: E=Sophos;i="6.01,165,1684825200"; d="scan'208";a="667067110" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga003.jf.intel.com with ESMTP; 28 Jun 2023 03:40:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qESbI-000Yvj-2P; Wed, 28 Jun 2023 13:40:40 +0300 Date: Wed, 28 Jun 2023 13:40:40 +0300 From: Andy Shevchenko To: Luo Jiaxing , Wojciech Ziemba Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, martin.petersen@oracle.com, john.garry@huawei.com, himanshu.madhani@cavium.com, gregkh@linuxfoundation.org, uma.shankar@intel.com, anshuman.gupta@intel.com, animesh.manna@intel.com, linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org, linuxarm@huawei.com Subject: Re: [PATCH v4 0/5] Introduce a new helper macro DEFINE_SHOW_STORE_ATTRIBUTE at seq_file.c Message-ID: References: <1605164864-58944-1-git-send-email-luojiaxing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605164864-58944-1-git-send-email-luojiaxing@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 03:07:38PM +0800, Luo Jiaxing wrote: > We already own DEFINE_SHOW_ATTRIBUTE() helper macro for defining attribute > for read-only file, but we found many of drivers also want a helper macro > for read-write file too. > > So we add this macro to help decrease code duplication. Is it abandoned? Besides kbuildbot complains, can you simply reduce the scope to one subsystem and resend? Let's say USB is nice one and it has no issues according to kbuildbot. -- With Best Regards, Andy Shevchenko