Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19010709rwd; Wed, 28 Jun 2023 03:59:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlE9DBvsUeYQm2dkN5TgL84j6Vcl/SK9kTicIuDbMATBxXP77fDA+ZByGqM9C/GJgvsc2pvz X-Received: by 2002:a17:902:8d91:b0:1b8:46fc:f526 with SMTP id v17-20020a1709028d9100b001b846fcf526mr490688plo.61.1687949948596; Wed, 28 Jun 2023 03:59:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687949948; cv=none; d=google.com; s=arc-20160816; b=ZBc89Fy09gmtBK7G6b6om6bnwk2e8yaEOPM8SrgAwV0bhBAg//tKSzBv3+wbkKXyBm bDAgLcUAWFdGAtuCSWOkW0PfBn2HbRKTciCH5C2d0WELioDzEBtwpBN6poB7dyZlx0bG rQQ9WPQ69WM131ouHXKUEJFF4lu9yQsj8CoVsen/nsAAOeXeIi+DqS3PdglMLykazvzp Yv0vCPmYeNosQwfMeCr7UgLGlciL9LchbfdMxcDn3sK1CJqtcVa8mKfWT19gyWhJqroN CHTTTGy8xvyllSN/c65S0mF/MoR2ROEMm8QDXCwQNKhaCakuG3zcKiPrm46ZMZj9Tc6p bOHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=jQjUqhlmgY3UJHahNITK7M0T+rtPnt2gs+USx8qUmAw=; fh=YlYZdpc7vOisA67JsYIThlbdpK5bUUKypy4eufK2Wvc=; b=xIydvxzsso2kiuM0Cq0UbUWBFO6bzFJ5zhZ7d9FH4z9pOz9oy01fsKhIZMMREjg4Fj on5nvyP6+2OjYrke4bgtI0BH1OjPVjorzpvxC23R4tnbn9TuQynM6+uw8MVN4o6ZsJtD gQiRakQqskvDRv7oZzRVznGeSzLG2yvdpoQ+yHOf7oz3xsakk4jzl0o4xYhO4PoHzEsy +i1/mdYfAfNPERwkf0omxMAq6/7o8ExzMZ9u2V70EAoRfiAisibmSB3qnK6sxN8jgIDg QhqkLphkaZx2WOiGmeLxdajqqa7i1YentN1Ov7iIv/AneQw5b2zXUIJ5xnYTF+7BTtZ+ jjFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xen0n.name header.s=mail header.b=sO40R4CE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h4-20020a170902f54400b001b508dd9a84si9095641plf.422.2023.06.28.03.58.56; Wed, 28 Jun 2023 03:59:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@xen0n.name header.s=mail header.b=sO40R4CE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230448AbjF1K2Q (ORCPT + 99 others); Wed, 28 Jun 2023 06:28:16 -0400 Received: from mail.xen0n.name ([115.28.160.31]:50250 "EHLO mailbox.box.xen0n.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231189AbjF1K0N (ORCPT ); Wed, 28 Jun 2023 06:26:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1687947969; bh=CywiEZ2ioeoVRwvb3VhckHlwPQWISEuRuyDIMUh/SlE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sO40R4CELoyZP15+xzNfqv8fc7MUdkASAJSkqWSLOF+ywVO11MV3l+vbMWMg1dqiL S3XqzYIfgs3lH9JEuQ4NBON04QSxnL2skzqa8NCotSC1yJtWdJ9eUJkPUFbXxZTmd4 Zxi4HVbihTOgYh7ZLnJNy6YsG4+r5nIfmYW+cbyA= Received: from [100.100.34.13] (unknown [220.248.53.61]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 05B73600A6; Wed, 28 Jun 2023 18:26:08 +0800 (CST) Message-ID: Date: Wed, 28 Jun 2023 18:26:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 06/19] arch/loongarch: Implement with generic helpers Content-Language: en-US To: Thomas Zimmermann , arnd@arndb.de, daniel.vetter@ffwll.ch, deller@gmx.de, javierm@redhat.com, gregkh@linuxfoundation.org Cc: linux-arch@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-snps-arc@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen References: <20230417125651.25126-1-tzimmermann@suse.de> <20230417125651.25126-7-tzimmermann@suse.de> From: WANG Xuerui In-Reply-To: <20230417125651.25126-7-tzimmermann@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 2023/4/17 20:56, Thomas Zimmermann wrote: > Replace the architecture's fbdev helpers with the generic > ones from . No functional changes. > > v2: > * use default implementation for fb_pgprotect() (Arnd) > > Signed-off-by: Thomas Zimmermann > Cc: Huacai Chen > Cc: WANG Xuerui > --- > arch/loongarch/include/asm/fb.h | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/arch/loongarch/include/asm/fb.h b/arch/loongarch/include/asm/fb.h > index 3116bde8772d..ff82f20685c8 100644 > --- a/arch/loongarch/include/asm/fb.h > +++ b/arch/loongarch/include/asm/fb.h > @@ -5,19 +5,6 @@ > #ifndef _ASM_FB_H_ > #define _ASM_FB_H_ > > -#include > -#include > -#include > - > -static inline void fb_pgprotect(struct file *file, struct vm_area_struct *vma, > - unsigned long off) > -{ > - vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); > -} > - > -static inline int fb_is_primary_device(struct fb_info *info) > -{ > - return 0; > -} > +#include > > #endif /* _ASM_FB_H_ */ Sorry for the late review. The change is fairly trivial, so: Reviewed-by: WANG Xuerui Thanks! -- WANG "xen0n" Xuerui Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/