Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 20:06:18 +0900
From:   Naoya Horiguchi <naoya.horiguchi@linux.dev>
To:     Miaohe Lin <linmiaohe@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, naoya.horiguchi@nec.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: memory-failure: fix unexpected return value in
 soft_offline_page()
Message-ID: <20230628110618.GA1248243@ik1-406-35019.vs.sakura.ne.jp>
References: <20230627112808.1275241-1-linmiaohe@huawei.com>
 <20230627123046.ef7e791208214bbfecd71e42@linux-foundation.org>
 <dc6f687f-926f-effd-338f-32edc7508479@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <dc6f687f-926f-effd-338f-32edc7508479@huawei.com>
Precedence: bulk

On Wed, Jun 28, 2023 at 09:56:38AM +0800, Miaohe Lin wrote:
> On 2023/6/28 3:30, Andrew Morton wrote:
> > On Tue, 27 Jun 2023 19:28:08 +0800 Miaohe Lin <linmiaohe@huawei.com> wrote:
> > 
> >> When page_handle_poison() fails to handle the hugepage or free page in
> >> retry path, soft_offline_page() will return 0 while -EBUSY is expected
> >> in this case.
> > 
> > What are the user visible effects of the bug?
> 
> The user will think soft_offline_page succeeds while it failed in fact. So user
> will not try again later in this case.

I think that it's helpful to put this in patch descrition so that maintainers can
easily guess the impact of this patch.

Anyway, the patch looks good to me, thank you.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> 
> > 
> >> Fixes: b94e02822deb ("mm,hwpoison: try to narrow window race for free pages")
> >>
> >> ...
> >>
> >> --- a/mm/memory-failure.c
> >> +++ b/mm/memory-failure.c
> >> @@ -2737,10 +2737,13 @@ int soft_offline_page(unsigned long pfn, int flags)
> >>  	if (ret > 0) {
> >>  		ret = soft_offline_in_use_page(page);
> >>  	} else if (ret == 0) {
> >> -		if (!page_handle_poison(page, true, false) && try_again) {
> >> -			try_again = false;
> >> -			flags &= ~MF_COUNT_INCREASED;
> >> -			goto retry;
> >> +		if (!page_handle_poison(page, true, false)) {
> >> +			if (try_again) {
> >> +				try_again = false;
> >> +				flags &= ~MF_COUNT_INCREASED;
> >> +				goto retry;
> >> +			}
> >> +			ret = -EBUSY;
> >>  		}
> >>  	}
> > .
> > 
> 
> 
>