Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Lu Hongfei <luhongfei@vivo.com>,
        Alim Akhtar <alim.akhtar@samsung.com>,
        Bart Van Assche <bvanassche@acm.org>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Asutosh Das <quic_asutoshd@quicinc.com>,
        "Bao D. Nguyen" <quic_nguyenb@quicinc.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Arthur Simchaev <Arthur.Simchaev@wdc.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "opensource.kernel@vivo.com" <opensource.kernel@vivo.com>,
        Tang Huan <tanghuan@vivo.com>
Subject: RE: [PATCH] scsi: ufs: Optimize the WB flush process to save device
 power consumption
Thread-Topic: [PATCH] scsi: ufs: Optimize the WB flush process to save device
 power consumption
Thread-Index: AQHZqY6OHBTqRdMiA0iSFVx8XZy+n6+gCiIA
Date:   Wed, 28 Jun 2023 11:00:40 +0000
Message-ID: <DM6PR04MB65757599481E7CAA98D89CE1FC24A@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20230628070229.61855-1-luhongfei@vivo.com>
In-Reply-To: <20230628070229.61855-1-luhongfei@vivo.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lZRu7yE7mT6kAs9LoG5d6C2+vNLhHXSfnR+/U+g5uRUxmdb0KzbFxcfXpFfj?=
 =?us-ascii?Q?Zaa9uiBtcZAPjs6UdYRXYOmnn1KpBGDR3ShsFdaQ6YkkWfLcf3M/7/CLVvD+?=
 =?us-ascii?Q?RrCburU8vRwtR1JShrRdkGnRoR5tTN7/ay6rkI+WzjeenrtTPDmY4EgFzs+F?=
 =?us-ascii?Q?j6cMWokQTAhipfM+UPJYTNH5RCU2vZX8UIZHLR2YOrBqdnBgwyUV6/KwngaO?=
 =?us-ascii?Q?gWvaUUcdbyyALcmvyhQpfMTU/278VaWiJQXmX1MGhMteZqoFodKl1fEN90uN?=
 =?us-ascii?Q?ln8K2cSBppeF794rAF54iYeeAcKKUzdyd0TXu8pXZ/6kFF9vthBdsTK6eQci?=
 =?us-ascii?Q?2/+Tod7WQdrjmx3E0IZe5FK9yRqXmbJ4U+dr/hIaUGKlc43TQ0cq0UBMlTDL?=
 =?us-ascii?Q?lotd5BiBJeOqWmX/fWtb/yYj4N/LZFcwWxfirPSM/9I+VZ6pIVKrv1+O/gwV?=
 =?us-ascii?Q?au9Iiut//SUSZg9lqey+ie7l15IfJ3I7jk2//gWZkm4xV+26g6ckOmHeEdHU?=
 =?us-ascii?Q?1I9s3ONlBDdsDKxSHWHkT5q7EB+Dl7Ltzy0ZcvTcixCKYmdh6KhmzHAQkB4d?=
 =?us-ascii?Q?TPYNnlh4koGeuZOxWercP9sweuW1ZqEIo7ySC5/J6veE8YsCJVKoH4QL3dJ8?=
 =?us-ascii?Q?k0qm2JJY7V5SLNNDtwSCPGQ0ocHapVg7VlktPztZ/0iOIYVhHiC0HfbBXyk6?=
 =?us-ascii?Q?hYY0fvjsLeOGPSm5xSndsu4Md5aGzR7+4wusVBn1TXoJSA1vfRJBSxPs5c3w?=
 =?us-ascii?Q?2bDonjCAVbhlL3n7AWivibG2cxelpxn5LguKB396k2IExyO45xBrKhSH1SYI?=
 =?us-ascii?Q?zkLGTeE2l1SPPClQp6dP5JLKsubOf2J1gSoHN6X/7PwSJeL8ZNm0YTosc1it?=
 =?us-ascii?Q?VcNWZFx6dY/av1b8pchdN8Wz6tCMqxMSDIeQBFUx8MkdKQYof5vimTn5ygHJ?=
 =?us-ascii?Q?Iu51sEV1g0OhglE89ZyljQYqqyjuF7jQQztD8yg4ajeQga1ZvhZuOSwvz3US?=
 =?us-ascii?Q?wL5Z+FOplrdaO+JQHqt3aHrMc95CgA6f0pHzH2j88RVl95KN+gfZXoCnho9G?=
 =?us-ascii?Q?EnTaoBZqS2i5jeiUvhW32fU5UeAe5iBtB8uFZVSCqnRqVIrhrl6nqip4PG3U?=
 =?us-ascii?Q?OyrS2uCUgXJOXdb+dKOcaZbioj9U8WGqVp+dA9Ti+l2wlLK5cP6srWrchqZx?=
 =?us-ascii?Q?vTJcQZ/pGIRsGeGmjuWL4ynxvIDTZOkTRBs0N12xNObhFf36f6QxMnaMVcVE?=
 =?us-ascii?Q?CZJkVZg5chnjB6OtM4/Dm2wgxEbu55ogIaCeHBOMk/g/0QDXeQC4lgmEImZe?=
 =?us-ascii?Q?HujKpLuZNfW9PXocLmk4nAZFGDZrCFFpjRoehf9CbW3UQuYZ19PqnPdW9VRW?=
 =?us-ascii?Q?oQ9zy84a1a6+F06L0ed4/cv5C6b8SztENcY+tYanXZqL/R8qmcFRSDoSA57f?=
 =?us-ascii?Q?lBTQqknRvQcvAzO8T7oqY+qe6ZdU9huIDcGV9GMVMW3uKM8v2yARwvXiJu17?=
 =?us-ascii?Q?2dqLSwsIzxyOgAf8RUNewznQOXztkkGUGQSZYq2VoWPatd3lBdztjwIEzC13?=
 =?us-ascii?Q?JHlUM02tQJkzvgAfuHYNd9AEF985Q5RILQ4+wGMx?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?9vxrXe0X5KLh/3vdORcAWQMitsXI9OBPcjwc5SLjPALQ0khfXNyuF6tGBMso?=
 =?us-ascii?Q?JEe23VEZQkk/RKh66YwMOR0UqnU2cPVQx1qg+xekKd5kmUAbvvM7ucHItHWK?=
 =?us-ascii?Q?70l7HQ5RQOUFndN+Vw9YZ+msB8/0eivzFh5KXeLobYOGKV6mfGYykE4N3P0N?=
 =?us-ascii?Q?xGfkifXOhoowFG/joohkXMHw+tCSlRZNCRrMn1HSOyuMbrk8n5AuMcu+jNVj?=
 =?us-ascii?Q?t5y3QaGwvU+VuQVeomqqcFPQvNsyswdtNxtsRlXsOByXhB3toj7q9SAIGthu?=
 =?us-ascii?Q?P7UPBNgtOlnZjfyrMJGftAn2atSU2Z8735alnMZOLR62uxmdmEd6wNrVWi6X?=
 =?us-ascii?Q?j7alNgKoIbuZAgPslOGePdbB76RyuLPr8MdLbWVoXINkSP9buOwiWQDWm1qu?=
 =?us-ascii?Q?DRi963EBKoIGSSPsR8G1JbTqlPz7cyRso7Uikb4B1Ak4ZfD5DFjVwbYGWpAP?=
 =?us-ascii?Q?50Ec+KTYbkucez+g0yTz/2ty5c6F4bVj1SXQd8Op5hbCZFkDWRCp9rQjqmqE?=
 =?us-ascii?Q?yV62PUOCRl/YaPTr5hyVAv2pmqmpzlOS9YXMPsH9kzc8O/+0ZcgusmPuOCTC?=
 =?us-ascii?Q?tm4ooMjMG7GmYhY5nkRb8SV6pS17/RrPM19d5LwIJ0uNUb6ImMM8QvkT9sft?=
 =?us-ascii?Q?RoejoiYpnWP0Tqv0MR6xwt6f/2QxCu48Xwf2upB2h4ILE+6Jd9nAfOQHPMIa?=
 =?us-ascii?Q?mRZOhGjA1QctYjvzzmHnLPvE2bSdrB/Ys+UPzofP23MZXZHSItxKjPpexUt9?=
 =?us-ascii?Q?R7lmc7itd9CB010vLSRFwMLKzeNfzddR+INSmh/WYlUF98QEzUmI1SJWBNEP?=
 =?us-ascii?Q?yvmHhepOeNuRaMgbMx1BfoqodUq7cOw3iy0SP1lyPufjfFc4VZL0Bkz4KOK0?=
 =?us-ascii?Q?EVgdLrchhHe9KFZr3An02mRjmhf6ahVQs+pSJ+vceUht1QBj81LW0tkouM+f?=
 =?us-ascii?Q?EVwmyo5lXw8Lzb8D2VF2D665hNHOYHWRCiDuaxGFIUSYRco3/+ExnOFPTbk5?=
 =?us-ascii?Q?G8WzzyFIUuj0IKi6O31I9/m7Ww=3D=3D?=
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aafd2cfb-b79b-44c9-bda5-08db77c6e9a6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 11:00:40.9992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WD8/o1sjGY64ROQJkw/soasczoFDOq1nTwQ3xLC8zRfSsLhSJ6sR5pPJtPYrwbavBtNzl4Ve+hB6XJSKW1qmhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR04MB6770
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
> In the original logic, WB Hibern Flush was always on.
> During suspend flow, the host will determine whether the device needs
> BKOP or WB flush, and if so, it will keep VCC supply.
> WB flush is only a part of BKOP, and device that needs BKOP do not
> necessarily need WB flush if the conditions are not met. Therefore,
> if WB flush is not needed, it will be better to disable WB Hibern
> Flush,.....=20
I beg to differ on this conclusion.
If you expect SLC write performance, without fluctuations,
the host should let the device manage its wb buffer on its own.
This is exactly what flush on hibernate does and better leave it be.

Thanks,
Avri