Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 12:47:50 +0100
From:   Mark Brown <broonie@kernel.org>
To:     cy_huang@richtek.com
Cc:     krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        robh+dt@kernel.org, lgirdwood@gmail.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: rt5739: Add DID check and compatible for
 rt5733
Message-ID: <2a8732f4-13fe-476d-9ae7-b970bd82c218@sirena.org.uk>
References: <1687942037-14652-1-git-send-email-cy_huang@richtek.com>
 <1687942037-14652-3-git-send-email-cy_huang@richtek.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="dZp7zQbwpodH2L5a"
Content-Disposition: inline
In-Reply-To: <1687942037-14652-3-git-send-email-cy_huang@richtek.com>
Precedence: bulk


--dZp7zQbwpodH2L5a
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jun 28, 2023 at 04:47:17PM +0800, cy_huang@richtek.com wrote:

> +	if (did == RT5733_CHIPDIE_ID) {
> +		min_uV = RT5733_VOLT_MINUV;
> +		max_uV = RT5733_VOLT_MAXUV;
> +		step_uV = RT5733_VOLT_STPUV;
> +	} else {
> +		min_uV = RT5739_VOLT_MINUV;
> +		max_uV = RT5739_VOLT_MAXUV;
> +		step_uV = RT5739_VOLT_STPUV;
> +	}

It would be better to write these as switch statements so if any more
variants turn up they can be added more easily.

--dZp7zQbwpodH2L5a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmScHeUACgkQJNaLcl1U
h9CKKgf/eMaIvJ+GA0vHvvKksA4S1NUI7q/j1CaaMTXgwqcv9WCmMdTEZWJHb5GC
sPxe1EOuqiz0RpkDk2NDzgYyUcJGNnY/cdhhYSaejkaaCHToEvz+sSZex642DVRQ
mvwJrxVNlVKFWh7ZQbaqEjpKxy4cSLcaWI4PVq8BFIfS5QzxD04Xq1fqaZu7soSi
Wmvn+XjxALwUEYCtlzDu2m/xncpWC3bcy+3t9lh/44lhwpWTM2keR5NQ7jZj1akB
1X3jGXBOIzfjPPCUxEpgviXVVJik2w9wjUMHNa2FD7ub679cLdACJGL7gH4/CUv3
Xz8F3/FpOBZcDe7otdRBIHTYTMfSPA==
=e51C
-----END PGP SIGNATURE-----

--dZp7zQbwpodH2L5a--