Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b3908ce2-43e1-b56d-5d1d-48a932a2a016@nvidia.com>
Date:   Wed, 28 Jun 2023 15:42:44 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v3 1/1] gro: decrease size of CB
To:     David Ahern <dsahern@kernel.org>,
        Richard Gobert <richardbgobert@gmail.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        aleksander.lobakin@intel.com, lixiaoyan@google.com,
        lucien.xin@gmail.com, alexanderduyck@fb.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230601160924.GA9194@debian> <20230601161407.GA9253@debian>
 <f83d79d6-f8d7-a229-941a-7d7427975160@nvidia.com>
 <fe5c86d1-1fd5-c717-e40c-c9cc102624ed@kernel.org>
Content-Language: en-US
From:   Gal Pressman <gal@nvidia.com>
In-Reply-To: <fe5c86d1-1fd5-c717-e40c-c9cc102624ed@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nlg5NXVLM0srOTRwZHlRRk9ZL3FjU1JyM09FZzlUUjNuM3h4N1pMN2FJVDly?=
 =?utf-8?B?QXJKMEp4NTRYdmtnZlJNS1N3QjZtMFNISk1XL1JaOXdHeUZBZXZKR2VIVHN4?=
 =?utf-8?B?Sk9vNVBMUlhqMjRDOHl3ZmV2Qk5FKzVoLzFSRk1oYTJwOFY1bWZTYVJGMFpC?=
 =?utf-8?B?V3l1VnE2aDVFNUNsSDEzN1E2QmRoaU40NDhmZ0lFVWl1eHp1eDVqS1R1eC9V?=
 =?utf-8?B?MVFyQ0hsL0k3aFU2d0M5UzF6c2VHdmRRU1d6L3htRUhKTkFzbTVGNm5KaGJV?=
 =?utf-8?B?aGFQdDRyQ21ySEJzRzNPbWV6dFBnKzJ1T3RTeHBkN3Vqa0sxeXZreEFPczlP?=
 =?utf-8?B?d1k0RTIvb3k0UHhCZGUxNXdvYzlUbGZCMU5jbnBhZTRva3dGQS81YzJTZUsx?=
 =?utf-8?B?emsrMWY2VERjUDNHcUdUNHNrM0wrYlZWQ1BxNWx6ZjM4UjA1ZXh6Q0llNUIz?=
 =?utf-8?B?bHdrWjdyb1lHcGxic09UWmxDdGFzbFQ5WHpPbVc4K215V2ZZWXFFajY0b0ZG?=
 =?utf-8?B?OVArWmFiZTZFSGEzQVQxbTgwQjdRZEhYSWZjYXhzd1R2cXc2MnlDbVo1MHlP?=
 =?utf-8?B?NjVGWk9qcEZMN2lhdU1tQWMwLzFKNmt0VE05NlFhNE5YSnR0TWlwT3hCUno1?=
 =?utf-8?B?YlR6RjNGMVRDY0FHYkp5ZjNvcVdRbmlJbE9tUjR5YTZxcUp4ZSs2VUE1eTV4?=
 =?utf-8?B?OGJCdHFJN2w1dElJOEEyQjNjQTBzNFRNdTNtNjZXTDZESjVsVnFNUmNsRkxY?=
 =?utf-8?B?NXdFejJKMUk0VXp5SFEyeU1pTHpORUsyMkRpRDI5NWpSblViUnBRNFVPT2Jl?=
 =?utf-8?B?QVNkTU9OeCt6WUdHYkkxK2d0Q1Eyb2VrWENITStjOUJNbld0Ym1VbWJ1N1dS?=
 =?utf-8?B?NXArNkovRkFxNjgvZnpzb3dkdUhsbjhhVjhkWkxWN1RNL3loVDJuRnpoVEZn?=
 =?utf-8?B?TVlyUy8xdkJMaEQ5Q2VlM0lxdmVlR1ZSTmcrTGRLNnFETUpwWDJ2UTh2VUdY?=
 =?utf-8?B?Sm55Z2RKVGt6Rkp1bCtsN3JCaERXSmJCNE9qM2Y2UE41Z2JYT0FaUEp5aTZE?=
 =?utf-8?B?Q2ZwYjhPSzVVREVZZXpkMGRJWjY3Yzc4SVZkcDJIemVhOHpzZGJ2WjJvVTli?=
 =?utf-8?B?SUZWWFJyb3RhOWppRWhiN25hMUxWckdpdkszY28wUXYrckVOTHhtQ1k2SHFl?=
 =?utf-8?B?VGEySXE4NlliOWNLYjgvOVF4R2RSS0gxbmpuVzlicEtQWWtFbHVUL3g5Y2Vt?=
 =?utf-8?B?dW1nUVdRUzhNSnhxQU9jL1pia0Y2MlZuSlpkdGNJVFFzTVNFUDJTUms3ODkr?=
 =?utf-8?B?WkhMNGI4WG9uSEU0eHI1ZmtQRHR4V2ZkTGlTVmVPMFVsblJvQ3FqQmdqYXpa?=
 =?utf-8?B?QzE0eFpYbmxKU2xyOUxvUjV2M1UyaDRlZ0NpQXBZbXFCanRucXVXeUo5QVZG?=
 =?utf-8?B?Y3M1S0FzOS9DQ2hjYldQV0RNS051N1RpQUNhb095OXlrMlMyUVJKRFhZWjdR?=
 =?utf-8?B?TGhBV2ZLSjZtZi9zK3pEU3pYbVVMb3BjRE96eFFUTjcvVUY1RUNLak83TXRo?=
 =?utf-8?B?bHdHTGxlTmVMbFd2NzhjUXl4eEVPaVZDR083aC9Rd0NXcDFCT2VGQzlXSVFN?=
 =?utf-8?B?a3pramZ3SGRYVllGek1TZVN2MzZJZFVxM1dLcGgrYnAwNkpPTit3OFMrZFhI?=
 =?utf-8?B?dENzVThybEt6QnMyNXpzS2RtWHp5aU10bW1zdnd5VHZZTGphdXZiTFVENFBJ?=
 =?utf-8?B?c0JoVG1DcHo1RGtTVUFmQ1hNdyszeWpkK2toalc4N3hORlJuMHZ5bHZleDlJ?=
 =?utf-8?B?eHhpTUYxQnVxbDZvSXNEUzF2WlVlYjlreEZxWTQzWXR3RExzUkJOSFlLM1NJ?=
 =?utf-8?B?KzZpeWFhS3lTY2hjVUhqam1pQStrZ3pJRDZSYXdWclh3dW1oaU5qZktmK0h4?=
 =?utf-8?B?S29RM1I2ajg4Z2JBRTd5QXpEWWsxb2lyK0tXRzQ3TUIybU9ra3I1bWV0ZElW?=
 =?utf-8?B?QmpxanFrclFxNHFkLytVeUdOVGRIWGs4YkNDclloMjNXMUN5anF2TS9lZW9w?=
 =?utf-8?B?L0Z0T2U5dElhK3ZtUW1vWmxHbWNTdGRuK0xzQ3g3cVFkMGFUUklWUW9wdnEv?=
 =?utf-8?Q?VINHNfjdi57ycuxIQDswtYm8U?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 005381e5-02e4-4151-5f38-08db77d53155
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6288.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 12:42:54.5077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jGeztZxP+qCbfGh/9q09yL3U8N0R5LbNHFCwHBDwqZ93/ZOo9hTg+/NpZn6t40+C
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6672
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 27/06/2023 17:21, David Ahern wrote:
> On 6/26/23 2:55 AM, Gal Pressman wrote:
>> I believe this commit broke gro over udp tunnels.
>> I'm running iperf tcp traffic over geneve interfaces and the bandwidth
>> is pretty much zero.
>>
> 
> Could you add a test script to tools/testing/selftests/net? It will help
> catch future regressions.
> 

I'm checking internally, someone from the team might be able to work on
this, though I'm not sure that a test that verifies bandwidth makes much
sense as a selftest.

Richard, did you get a chance to look at this issue? Maybe we should
revert this patch until it is properly fixed?