Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75ea8257-cad1-418e-fd2a-329fd7b208ce@gmail.com>
Date:   Wed, 28 Jun 2023 16:16:36 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH -next] x86: ia32.h: Remove unused code
Content-Language: en-US
To:     YueHaibing <yuehaibing@huawei.com>, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
        x86@kernel.org, hpa@zytor.com
Cc:     linux-kernel@vger.kernel.org
References: <20230625125411.25840-1-yuehaibing@huawei.com>
From:   Nikolay Borisov <n.borisov.lkml@gmail.com>
In-Reply-To: <20230625125411.25840-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 25.06.23 г. 15:54 ч., YueHaibing wrote:
> Since commit 32974ad4907c ("[IA64] Remove COMPAT_IA32 support")
> IA32_STACK_TOP and ia32_setup_arg_pages() is not used anymore.
> And commit 675a0813609f ("x86: unify mmap_{32|64}.c") left behind
> ia32_pick_mmap_layout() extern declaration.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   arch/x86/include/asm/ia32.h | 11 -----------
>   1 file changed, 11 deletions(-)
> 
> diff --git a/arch/x86/include/asm/ia32.h b/arch/x86/include/asm/ia32.h
> index fada857f0a1e..68f7eefe63d3 100644
> --- a/arch/x86/include/asm/ia32.h
> +++ b/arch/x86/include/asm/ia32.h
> @@ -57,17 +57,6 @@ struct stat64 {
>   	unsigned long long	st_ino;
>   } __attribute__((packed));
>   
> -#define IA32_STACK_TOP IA32_PAGE_OFFSET
> -
> -#ifdef __KERNEL__
> -struct linux_binprm;
> -extern int ia32_setup_arg_pages(struct linux_binprm *bprm,
> -				unsigned long stack_top, int exec_stack);
> -struct mm_struct;
> -extern void ia32_pick_mmap_layout(struct mm_struct *mm);
> -
> -#endif
> -
>   #endif /* CONFIG_IA32_EMULATION */
>   
>   #endif /* _ASM_X86_IA32_H */


Reviewed-by: Nikolay Borisov <nik.borisov@suse.com>

I've sent very similar patch (minus removal of IA32_STACK_TOP define) on 
12.06 - 
https://lore.kernel.org/all/20230612154438.638491-1-nik.borisov@suse.com/