Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8158b5de-c2c5-2b4b-a2c4-5ace9a17a99b@oracle.com>
Date:   Wed, 28 Jun 2023 08:30:42 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3 11/13] riscv/kexec: refactor for kernel/Kconfig.kexec
Content-Language: en-US
To:     Conor Dooley <conor.dooley@microchip.com>
Cc:     linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org,
        chenhuacai@kernel.org, geert@linux-m68k.org,
        tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
        deller@gmx.de, ysato@users.sourceforge.jp, dalias@libc.org,
        glaubitz@physik.fu-berlin.de, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-ia64@vger.kernel.org, loongarch@lists.linux.dev,
        linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org,
        linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
        linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
        linux-sh@vger.kernel.org, kernel@xen0n.name, mpe@ellerman.id.au,
        npiggin@gmail.com, christophe.leroy@csgroup.eu,
        paul.walmsley@sifive.com, palmer@dabbelt.com,
        aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com,
        agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
        svens@linux.ibm.com, hpa@zytor.com, keescook@chromium.org,
        paulmck@kernel.org, peterz@infradead.org, frederic@kernel.org,
        akpm@linux-foundation.org, ardb@kernel.org,
        samitolvanen@google.com, juerg.haefliger@canonical.com,
        arnd@arndb.de, rmk+kernel@armlinux.org.uk,
        linus.walleij@linaro.org, sebastian.reichel@collabora.com,
        rppt@kernel.org, kirill.shutemov@linux.intel.com,
        anshuman.khandual@arm.com, ziy@nvidia.com, masahiroy@kernel.org,
        ndesaulniers@google.com, mhiramat@kernel.org, ojeda@kernel.org,
        thunder.leizhen@huawei.com, xin3.li@intel.com, tj@kernel.org,
        gregkh@linuxfoundation.org, tsi@tuyoix.net, bhe@redhat.com,
        hbathini@linux.ibm.com, sourabhjain@linux.ibm.com,
        boris.ostrovsky@oracle.com, konrad.wilk@oracle.com
References: <20230626161332.183214-1-eric.devolder@oracle.com>
 <20230626161332.183214-12-eric.devolder@oracle.com>
 <20230628-urologist-faction-42ebe5372206@wendy>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <20230628-urologist-faction-42ebe5372206@wendy>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bU1CQVhtRmtkWkhNRS9tTFpCVytXdVhhVXBNSzAyaHhGcTg5VHlpTUhmSjlr?=
 =?utf-8?B?SDY1Z1VsOGo4Ylc1bmgzMExTbWlUSDNkN3hRWjUvVUJWM09rNVh0aFZIdDNx?=
 =?utf-8?B?NVpYR3MyNU11bVNYY3NqSTdvckdCRkdSQ25nS0h2R2FvR2MwaEJSU0hCMlhW?=
 =?utf-8?B?aW1jbzJkb21rVDM3emVKSHFNUEx6MVZydGdGVG1KblhRSlVORkJVMWs5aFlF?=
 =?utf-8?B?MTNBR0lJZ00zSHEvODR3T0gvRnA5cnJiQXFFSHZYM0N6eDlZU09vNHlEcDQ5?=
 =?utf-8?B?SVd4TlkrazYySmp1YjRxWk9oVkVBc3lHMWRKT1dmRmJtMk5RVnNtMmhrdndV?=
 =?utf-8?B?eVVnQkttU3JtRk4zRHhoUFZra0hMN1ozT1dxaUhDd3hvc3BEVnFjamZGSG5M?=
 =?utf-8?B?YzBJNGdqall3U0JoZ0hwQXdLeWJzZi9xL21qcWdwdGUrbTFtdGI5S3QvY25n?=
 =?utf-8?B?ZnFlelVvQ08zSUFnMFZoNjI4R2lmaFhDLytCbjUvMnhIOGVJZnlUdFFSeU50?=
 =?utf-8?B?SHBYTyt2UTk0T0wvU3dsQlo3a2t1WW1yQkhDcWFXQ1U3Q0FzZjIzaHA4MktH?=
 =?utf-8?B?YTBYS3FQYzJNanhFejJ3ZytwOGdSaXZ6ZXk0b0pHWXhUU1VhNnVYdlVJSjAy?=
 =?utf-8?B?TnY3L1pjMkJ6aUwyd2ViVC8rZHNIZjdXdCtmajk3eEpnalJuR01vaTZZbzZx?=
 =?utf-8?B?L2dldk9adzZydHQ1dHVRUW0yWmtjZlFqMUZKMEVTMm9lRUp0V2hyUDllTDBX?=
 =?utf-8?B?ellzL0JvMXJJZENScDhwQjJGUnBoYTNwNjFXQ1NKbHgxTWpURTdPRlJ3Tkdu?=
 =?utf-8?B?dWI2endTV3ZTa2ZFUS9zaDA5MEhhRXViRFl0UzJhbUMzdkQ0SGVkWkZaV3JO?=
 =?utf-8?B?YTVRTEJQVGtoOVprUlpUdGEzNGpTcUJqRG5FUGljTFBJY3JOZ0dEZ0ZEdlB4?=
 =?utf-8?B?Tk04RkZrb0VTWlk5UFVONUVrWU50OGV2cENTMm1YWEJBSUdYZ0l0QkxaV1R2?=
 =?utf-8?B?RTJkVGZtZ08yT1RCUEpjL2hjVlNacUxWMG1MZjdwMUtuSWwvSEw1V2dUQVJS?=
 =?utf-8?B?OTlQd1puQ2ZTcEtSc01xOUdQR3VPNVJHK2FicVhRMi9wZmdkY2o5UEZkV1Yr?=
 =?utf-8?B?ZW56MDFTaXpNUkhJN0o1MlpLWncvUnpIZFJ1R3VEbzg5THpMdng1aTNJMUY2?=
 =?utf-8?B?MmVnL3lPMVBuQXVzM2FtUExQOWJXSk5aN1NLK0RTeTlKd2ZGRDZuaHROTDBJ?=
 =?utf-8?B?NlJSUzRteEQ2VlRRNjRnNjlhR0g1Z2RXQW45Y2psTnRNQ2N6K3R5RGdHK28r?=
 =?utf-8?B?NDVYd0tzdDQrWkhjaFh0QWQwV0lDVFkwck0zR1A2aW80OVBzVFV3ajYxK29t?=
 =?utf-8?B?SEZDa0lpZnNHczErbjVEako0TXU2Qm9xdnNyaXRtdHdxZTM0MlVUVEpxejhL?=
 =?utf-8?B?VnlXSEk3bkU5TzhMRmg5RXlaV2FFY3YrRjQyVVE1enZLM2ZPSDhpUEpQVTlq?=
 =?utf-8?B?aWhLUFBjbExvcXVaekhRcTBwbk0rMSt0YjM2MEZwYlRiSEhDd2t5L3QxUzhi?=
 =?utf-8?B?cmw1YkJWUFA4R3NldWw2dWpHYlcwRU0ydEdNZXVPTDNSeFc5N05TWlpTSDJQ?=
 =?utf-8?B?bVpKYWxhY1UrTGg2ZFcybHJLenBPOWQ0Wk9iOTZ3UEhCNjhXNHJ3VjVXSEtY?=
 =?utf-8?B?ZE1IdEgwTGtTd1BVSVVETVBKTU9wZDg1cTRjclBLMXJBL1pDVG5rQkt6M05k?=
 =?utf-8?B?YXF1emkraFpBTWV6djliVi9ZcWluYm5Obm5IeVZLZjJIOTRGbUUySk02endM?=
 =?utf-8?B?TVZQQ1ZSL3dicDFKd1ZqQWlteXdxd2xnSk00MlNYall2ZGNsU0lSZWMrQjlD?=
 =?utf-8?B?VTE2S0N2N1BYT2sxNVQ3UGNQUGhGL1JuOHMySk1rQlEzbWxESm5XOHZSR2Vu?=
 =?utf-8?B?blFzTzhMRnN1dGlyeXR2T3J3cS9YV21YcFRuaGY5SXdha2ZxcDF2L2xsSlNE?=
 =?utf-8?B?S090SkNibVpoVXlsSFp3WTgvcEFtMmt2QkFpUmhHTHp5UllFclBReklRK1R0?=
 =?utf-8?B?Y1lMMjE0N20wOFRpVlpsU3pSdDNwZjVtbFpYTmJTemhxdmQ5bnVPVnkvQ3dC?=
 =?utf-8?B?VEVsVjhqMFR1SGlUSDJCZDltdmZOU0Znck1qTG02djlSMVRiZmhvcFdJTUpC?=
 =?utf-8?B?Unc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 2
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?U1V3aUI3VkE2MWNRWjl6bVhIdFNSbXhyTkxTSWRyekR0ZFJwQUhOYW5MUG1U?=
 =?utf-8?B?QUtqdVQ0R3c1akFvejNIMHRWVXNjS0o2NjB4T1dKQ2tkeHQ3NkdKUi9uTEpU?=
 =?utf-8?B?YmF0OW4wUlpoUEphRHdneXE2bngzQk51TGFHQ3hOMHBuUEE0elg5UWlFaXNP?=
 =?utf-8?B?YnFqS3QzdGh4WWdyc1NSTUlEOHlTcjhsK0pBTDVEZ3pDS0ZBRFF2QzIvTHFa?=
 =?utf-8?B?R0JKcjVtUEwwOWluOFUrRThzdTkyK1dmNUxXQ0VVTitUeXR5NEZBNFd0S0Ja?=
 =?utf-8?B?WTBFS2twZDlDbGV1RWFiUUNwV0UveDBOU3JlVzFXNjJmS1NMRnoxZHRsVGpz?=
 =?utf-8?B?cnc3eXpNUTYyTFpPTElmZHVHZkNoZGJjREFWZWVudllxdytYSS9yQnk4TmNz?=
 =?utf-8?B?R0JxRndvTkloc09JNGwrRTZDN0F3Szl0SUk3MSt6N25kOS9VdkFYSFk3NlZ4?=
 =?utf-8?B?TUx6cURzdytVd2NBSjhvd0pLcTd4WmhVNEkxUUVBcFFpN1d4dVJEYkhJR3c4?=
 =?utf-8?B?aU4rTjE3dTl0VTJHZEtvVk40VTZheXRTVmhhckxZdjFpaXdYaDVac3Njbzl6?=
 =?utf-8?B?R1Z1eFduN1dNUHBzTkk5bmlrNFhUY0FQTkRCaUlIdFNhODF2TUluMlZUaDA1?=
 =?utf-8?B?Q3p5ZGRtSmhnRzlCcjU3ZGdxcTlCZk8vU1YrTTIvTmorc0JMQURmTUxxMy9Q?=
 =?utf-8?B?cHlRbG1WTy92UnFEcGhhVkl0blBGQ2xJUmU2eUJwWmZmRXZuUGVTNWVxVEsx?=
 =?utf-8?B?OXlvamdvQ3QvZFk0eDU3dEs1VXh4L0s4TjYzWFNmWWFJbTB4anN4VDh4dVZa?=
 =?utf-8?B?cmZCdGZ1Z1dzbVJyYkl5bUhZWnJONEFMWk04Qmw3aXdoQW1SUlNPSEdDSXBh?=
 =?utf-8?B?WTdIYUhhT2VzZlBWRVBEbDhMdlNvOE9GQi9TSWg2LzhVZkFkRExoekFlRmhl?=
 =?utf-8?B?MlhxTWJhQ3JyMldRQmdrNXhuQUFhT1hWVTdBdlZMUm9nbHJSZ3pvbnV4clBq?=
 =?utf-8?B?WjljUC9TMmNtL1BqSEl5UXNQTWVjUGNvbUoyT2RnUjJHUDA2VkJjZHRpQVBK?=
 =?utf-8?B?TzRXNW9HRjdMRHNlSE5VTkVlMlRmRnNHellBRjRlaFR2R3NVN1drRnFrdTNT?=
 =?utf-8?B?Z05PNDZVY3FsRkgzU1VXaFlwQW4xeWltUE5mV0t5dDdJSy95SDlvTWNjK0RX?=
 =?utf-8?B?aS82aWYyTmcvcmhqQjVPM0dOREhSN3VzaTh4Q2ovZlAzYVhWbng3UmNNVGlj?=
 =?utf-8?B?TFl6SHVjcWV2OEFvK1JjaXU3emJFN3FyZUpTUVM4Mk9GYzBtWStFWDNUYVBH?=
 =?utf-8?B?NDJGUDRNRWNWb01NMGdLOVgxQ2hoRHFpN3g3M3FmT09xL01zejd2dFk1RVVv?=
 =?utf-8?B?Y0Y2VGcyaElOWU9kWkRzVGQ4M0duOTdRV2haSTRJdk5ybDRZQ2haaE5Ea2Zx?=
 =?utf-8?B?Vkd6Mkg2LzFQaERzdkF5L2FEdWQzR01zSy9yK09JT2tPUFR6bHp0Y0NmaWRS?=
 =?utf-8?B?cFIydUYrWFB4RlBzbjB2NlZvbERLUEN4VndGWTJWMGpoWWlsejdaQTg5QVE4?=
 =?utf-8?B?dkdkbzIrYUxzNi9BbEVQMGJuZkJxQVRIUXBvYWJqeEEzbkdESHRMcTM1SnEv?=
 =?utf-8?B?UHZjekR5aFFCa0VhbllSdjJWU1loSS9HNzFhaCtqdmx2dk5vMC9RS3FUZXNu?=
 =?utf-8?B?VjJmemhvS2k3NCtIYitQMmR1N2drTmlOeWFVYUdad1RaVVJ0dHNrVFhlL3Fl?=
 =?utf-8?B?eWlST2l1Zm16cHBFaHd1OENma0F1TTEwZEFjVDE5N2hab2QyR0FIY1IzQmtH?=
 =?utf-8?B?d3FjQk1NenEyTkpsSml4Z1FTOXNvRXlPR0FmWUMxSFpQOGxqbnQ4MTJielc3?=
 =?utf-8?B?VFZjd2V4STZTbS9kN2kvemsweFREOWZmNElQSUVhdkVXaGpySk9DZ3FXWDBF?=
 =?utf-8?B?emkrTlp4UnExNVg2cm1VRXpSaHN4S1lxdnpzSTBhM1Y2S2dmd1FWVmtTallo?=
 =?utf-8?B?Y0JqMW5XaU5OSHlUenFFL3lUSHFKZ2hTYW9sOTZ2ZGhkTlVZUnJxYXhZSStw?=
 =?utf-8?B?L3hVcXNQaFJMSS9aY0h4Tk83TEt1WW00RHE2NmMydUx3cDRpQ0Fadkp4Vm5Z?=
 =?utf-8?B?YTVkMmJyVm5OK2FRR2FpNzJGSy9JQklJazhxd0NmbSt6bFh3T2ZiQSswTUZ4?=
 =?utf-8?B?VmFJUXJ1VUk3ZTMwRGRHN1hydDBxZ2N5cEEzMFptZnpsUGoyWUFsazBLeVhI?=
 =?utf-8?B?aFEvU3BMZ2VQZ05teGlUa3I0MkVsREgrM2NOWTNoODJMLzVqQWxGZWIvOElz?=
 =?utf-8?B?VVJ5ZmVlWFdFdStKOGtyZDZ4MWlRMXpuUFJDRTBGOWxMM3JjdjA1a0FwRkNy?=
 =?utf-8?Q?tJ9cXQYTHDEphrs2oOJaUADo4LKqGHJ1AwK3Hzjw/vbfs?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-1: +Fjfx9FFApqFEiWXGg4T15wvTc7KISa+SbUl1w2rWgdRG6T7LnEfs5UnH84DJlVXdb/qMwchq5Br1GDpCLQVvUCIl2Su78MVSCIpJUO9aYFHi0DUBTwl/ocV3OBXWc5A28IWWwPimacWOuI0fd9hGkdVsGT718MRTWIuBVnFLYCDPgBx3yZJxfxlatFZeSL+QbxGqgXPdB0bD9+FNeFCBMBTh8xoWQMjiYrx08w787VzqO+nB7NeY8b0KhRjAtwmBToJzQqbrhL2UnT5CZ8NR+rIXNP6dPe8fPJkkImG54wcLZO074kjGhEU9yiArF2McRsaSlWZiQtH1T4h/a+D7GoYUfEeo/AOyaFCShgKHd/btYtbcGx2fAnPhFciItV4inKb0DPa0rYQO3CqjpYIF66MINgUcxWLcZb18aJgNX60PcGSUy9Uy5mO1ss2pgIGsuWJw8sqE5n9IFjvWQMmf5AK/KxIncFFGwXG4vDQRLZP77Unf5os9jWC
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2821a4fd-9f1b-4999-2bed-08db77dbe55d
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 13:30:53.5530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: COj5tdljajzTM5GwjG/czGSUNDPZ9ctwfGiNtWCfNMmto4UrgcbtO8em+fl4jgvIDH4RWyM61fTA1BHJMGSJgZPYQC0CVr890Xq56GMnkwo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5166
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-28_09,2023-06-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 adultscore=0 mlxlogscore=999 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306280120
X-Proofpoint-ORIG-GUID: 2R7_TIJwpnZhb78eOaUZ1eLNDHaj7McR
X-Proofpoint-GUID: 2R7_TIJwpnZhb78eOaUZ1eLNDHaj7McR
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/28/23 03:20, Conor Dooley wrote:
> Hey Eric,
> 
> On Mon, Jun 26, 2023 at 12:13:30PM -0400, Eric DeVolder wrote:
>> The kexec and crash kernel options are provided in the common
>> kernel/Kconfig.kexec. Utilize the common options and provide
>> the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the
> 
>> equivalent set of KEXEC and CRASH options.
> 
> I find this diff a little hard to follow (since the other half off the
> change is in another patch), so it may be me missing something, but are
> you sure?
> 
>>
>> Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
>> ---
>>   arch/riscv/Kconfig | 48 ++++++++++++++--------------------------------
>>   1 file changed, 14 insertions(+), 34 deletions(-)
>>
>> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
>> index 5966ad97c30c..c484abd9bbfd 100644
>> --- a/arch/riscv/Kconfig
>> +++ b/arch/riscv/Kconfig
>> @@ -585,48 +585,28 @@ config RISCV_BOOT_SPINWAIT
>>   
>>   	  If unsure what to do here, say N.
>>   
>> -config KEXEC
>> -	bool "Kexec system call"
>> -	depends on MMU
>> +config ARCH_SUPPORTS_KEXEC
>> +	def_bool MMU
>> +
>> +config ARCH_SELECTS_KEXEC
>> +	def_bool y
>> +	depends on KEXEC
>>   	select HOTPLUG_CPU if SMP
>> -	select KEXEC_CORE
>> -	help
>> -	  kexec is a system call that implements the ability to shutdown your
>> -	  current kernel, and to start another kernel. It is like a reboot
>> -	  but it is independent of the system firmware. And like a reboot
>> -	  you can start any kernel with it, not just Linux.
>>   
>> -	  The name comes from the similarity to the exec system call.
>> +config ARCH_SUPPORTS_KEXEC_FILE
>> +	def_bool 64BIT && MMU && CRYPTO=y && CRYPTO_SHA256=y
> 
> This looks like a change to me. Previously, only KEXEC_PURGATORY
> required these crypto options to be like so, but now KEXEC_FILE needs
> them too.
> 
> What am I missing?
Conor,
Thanks for looking at this! Indeed I erroneously applied the CRYPTO=y && CRYPTO_SHA256=y
to KEXEC_FILE rather than PURGATORY. I will correct for v4!
Thanks!
eric

> 
> Cheers,
> Conor.
> 
>>   
>> -config KEXEC_FILE
>> -	bool "kexec file based systmem call"
>> -	depends on 64BIT && MMU
>> -	select HAVE_IMA_KEXEC if IMA
>> -	select KEXEC_CORE
>> +config ARCH_SELECTS_KEXEC_FILE
>> +	def_bool y
>> +	depends on KEXEC_FILE
>>   	select KEXEC_ELF
>> -	help
>> -	  This is new version of kexec system call. This system call is
>> -	  file based and takes file descriptors as system call argument
>> -	  for kernel and initramfs as opposed to list of segments as
>> -	  accepted by previous system call.
>> -
>> -	  If you don't know what to do here, say Y.
>> +	select HAVE_IMA_KEXEC if IMA
>>   
>>   config ARCH_HAS_KEXEC_PURGATORY
>>   	def_bool KEXEC_FILE
>> -	depends on CRYPTO=y
>> -	depends on CRYPTO_SHA256=y
>>   
>> -config CRASH_DUMP
>> -	bool "Build kdump crash kernel"
>> -	help
>> -	  Generate crash dump after being started by kexec. This should
>> -	  be normally only set in special crash dump kernels which are
>> -	  loaded in the main kernel with kexec-tools into a specially
>> -	  reserved region and then later executed after a crash by
>> -	  kdump/kexec.
>> -
>> -	  For more details see Documentation/admin-guide/kdump/kdump.rst
>> +config ARCH_SUPPORTS_CRASH_DUMP
>> +	def_bool y
>>   
>>   config COMPAT
>>   	bool "Kernel support for 32-bit U-mode"
>> -- 
>> 2.31.1
>>