Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <90f35697-5941-d42d-b600-245454cbd040@oracle.com>
Date:   Wed, 28 Jun 2023 09:02:14 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [Jfs-discussion] [PATCH 0/3] dedupe smb unicode files
Content-Language: en-US
To:     "Dr. David Alan Gilbert" <linux@treblig.org>,
        Tom Talpey <tom@talpey.com>
Cc:     sfrench@samba.org, linux-cifs@vger.kernel.org,
        jfs-discussion@lists.sourceforge.net, linkinjeon@kernel.org,
        linux-kernel@vger.kernel.org
References: <20230628011439.159678-1-linux@treblig.org>
 <9343462e-6a4a-ca7b-03b8-4855e5a33b72@talpey.com>
 <ZJw4iLlFWRMq6a3S@gallifrey> <ZJw50e0pvn/IN5Gj@gallifrey>
From:   Dave Kleikamp <dave.kleikamp@oracle.com>
In-Reply-To: <ZJw50e0pvn/IN5Gj@gallifrey>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnFIdUpFMVovaTlHQk5BbE92YWhPQXk3Y3IzUUhVcTdmb1VIQlBFaGIyd3RN?=
 =?utf-8?B?RERGQVNldlBEN25OYmhDeFUwSlJiWENiQ3RWSDlEVlJnN3RJbmFnSmF5RUp5?=
 =?utf-8?B?QmNmWERJTjg3amZ2Q0l2alY4YTc0WWh6U2hqR3JLWU5YWlFBQXFBQzB3Z1l1?=
 =?utf-8?B?RWxhKzdXcjM1Y2h3Qm5BeFZYVmgveVcvM3pxUGZuNDJWbkdpVWpsSy9YMFFk?=
 =?utf-8?B?QmRjMElZUXNDWXpSakFrMXdvQUo0RzlWTjdWZlNkYnF2S29RQUFuSEZQTjlm?=
 =?utf-8?B?NUp2U0ZxVHlVWEdYUVZyNy8yMHpNMlg5S0RzbytJWGdvMmxJa1NsemFUcjY3?=
 =?utf-8?B?ejcwaE1ldTFqdzVZTzlGd1djcmltcWlQVFFhZTJGZEY1V1o5cVFWZXVwb2JF?=
 =?utf-8?B?U053MmhtcFo3L1RldHFoenNMMmtnc0FBMTdqRlZBMXUva2tIckVGQnVDd0NV?=
 =?utf-8?B?bGdhYlRDc25KT0xGaXltOUpackc4aWFLR2F5bW5IbWo2MExZUTdxZ25pM215?=
 =?utf-8?B?K0ZUdUQrbVBNOGJKWWFtb21aUkRmVXhLdEd3TTVqYmM2RUF3azJ1WDJqUGNk?=
 =?utf-8?B?MUVPTHRvbVdqYkljTzJMK0JNNTJiV2hPalFGVU5qclREUzNIWnJad25pV0Uw?=
 =?utf-8?B?MDBxcU4rS0xyQnBVenFPQWZnK21HSWpZQTRReFE4MEZiaXJKR29zZDk1eUVz?=
 =?utf-8?B?WXlNcnRHR0dtVFp1QmxkbUJHTlN6cjRoWmN3WmZlU1VyaUlHTktTbGxCZ210?=
 =?utf-8?B?aWxLa2FqZDFNODYwQ1JFTEUrQXJLNitZd1ZzbmRScVkxazlTbVZqQ21EMmds?=
 =?utf-8?B?NW1IYkJ0UFcrZkJCKzZkQ3FnQlh1UGVEN1NpY2ZSMXkwb0t4WXE4ckloUDZz?=
 =?utf-8?B?VU50bXJvRDRidzhGeGNBNWp6ZTJGc1VsSmloSnUvaGxQNnhwUU5CRW50QXlr?=
 =?utf-8?B?anBnWTJCQmt0SWl5emZBZGw3ZHJqbmFJY1VXM3FsV1VJNGQwbzMzRXhJQnFq?=
 =?utf-8?B?RE1UTnVwRitxcUFmcjVTSm41NVN4dVNEdGlRc1hLWlFIUGllbXdIcGRrWm5F?=
 =?utf-8?B?RDlUV2Q5dTQyRHE5M2c4dzl0d1ZVTkNoVnM3dEtyL2F2QzVydjlwbXhxRmda?=
 =?utf-8?B?cW5pRUh5aHprMGNxRURieXBJbjdNYjNOUWkxZnpXZ1FXQXEwM0RXbUdUbCt5?=
 =?utf-8?B?eEJpQ09aeDV3WE1LL0JnNVNIZkFGMms4MzBWR1hjRUJZcGI2RncrUE1vUzdB?=
 =?utf-8?B?UWlSUitjOEkrbG5XRXAvb25zNWE0RDJadWJGVVVCakU1MUtsZWQzQVdJVndX?=
 =?utf-8?B?ZVJzY3kzSkNUcWxLUEpraXJTbXRxMmlucDVFa0xiMXBYUXdUcHJobjNjYTBv?=
 =?utf-8?B?WFl2TFZLdzd3dEFvcDF3SzlCTUtTczloVXRSVkt4Tm03T0Q3Q3BNQ1JHQU5m?=
 =?utf-8?B?ZVVYTWVOVkhrWjFvOE9iczJDREl4KzVyVjg4bUhZTG1kVWx4QW9Jd004anpW?=
 =?utf-8?B?U1o5UUNLdG84SFNKanA5SlZXVm5hWEMvNUZyd1M1Q3hiRGd5ekR1bkNmM0ta?=
 =?utf-8?B?SVJWbVEvVzZSVFp3Z0pBa1lSck00YTdjQTBjYlBLbVYrcHFYWU9FVmdYSEs1?=
 =?utf-8?B?dzc5akFGd1AvQzMvVUdidHlyUkltMEJnYUt2NTdHNVFNRllDeTRldGFNK1lO?=
 =?utf-8?B?aFluQ3dUSThmb0V5QUZPMHQwUXBwR2xLMGZkNEtvLzgxT3ViMFhxUklCMXEw?=
 =?utf-8?B?SitOV1lObm4xZzR5aHNib3hoTzc4SDR2U3ZkU24wQjBuNEVoc0pYakE3S0J5?=
 =?utf-8?B?bTZ2bnBJS25RMUZOSDduaVZCMEJ0ZmpzMU1yK0JQZmgzZVJwcUlGQWNpM0ZJ?=
 =?utf-8?B?S1I3ZGdrOG1DWTlMMHk5MGZsUFJpZTZZc1hWdXBhVXBlcFJZcFlWdDFSQXpC?=
 =?utf-8?B?MklHdlM1Q0dEWERiaHJRNXBIRlRDVGNub3lnc2VmN0JqaUdXcTJad0NhenZZ?=
 =?utf-8?B?VExweGQrM2VmZHZ5dlNoMkJpc0RibzM3aSttWVNpYlhvenprRW9PMVdkeUdU?=
 =?utf-8?B?WnlRb0VEU1hBUHJXblhqWm9MeGxNWHJQQWdVdHhEN2JtditlK0ZvV0FjSXlk?=
 =?utf-8?B?N1NEVFNNOThjQVJTOHZmSHRtcUdvYTZ5SHkyUlBJaUhzZXpXc2c0NEFSUFZ4?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZXJoWXNkOHN3VDM5SVY1dEc2bjhyV1JxUWFRYXZwaTVFeDdzME1rTFVFclBm?=
 =?utf-8?B?d3ZOblg3emdtUWM2YWVsVjBRR0RNR3pDM21nZ0s5RytyTmFvejVzKzI2emlv?=
 =?utf-8?B?OXlWRkN5Wkhkb3dvSjErU1AzWGQ1RWowS1JpSmtINEVuRWYzVjVQbTUrd01h?=
 =?utf-8?B?emRDRWJHbzF0dXZIU2MyMUMvUzVDSFZ5djN3Nk96MjZJTlcrdldZa3dxdHBs?=
 =?utf-8?B?cDNlSjNDY2dHSE1hdVUyaU9zT09FL2dxSXpsWGpTQWZvVWRpZVVBM2lTenlT?=
 =?utf-8?B?bjloUHlGT1V1TEVpQXZEZnF2QWZNeGxXM25ueWpCTms2MjRBTVNLZ25OdWZr?=
 =?utf-8?B?WkVLcjkxVWc1cTVsb3BMUGE0SDdRWUNRNDcxVjM4VmxSYjJuWnFjcEZVaTgz?=
 =?utf-8?B?c0FLYlQ0cG1zT3VQenNLWFE5eFl3aTZwdEhVdzUrc0NwVHlZWE5qUWxJL0c5?=
 =?utf-8?B?Z2VZcmZjRjRLL25tRSsxRkliZElEK0FLYzdrbTFxb2lQS0ZYYWk5YmsxRWl2?=
 =?utf-8?B?Nys4ZWZsYVVOZkdmQ2NMa0JUeklXTTBuVWFNa0xWQWUremRXbjdlNmpOMVQ0?=
 =?utf-8?B?cm9yNzRNd1ExcnlIcXFiRW90azNWR2xYenYyOFpSK1p4WjFiSkpHYzZjZGg4?=
 =?utf-8?B?dkp4V0VBUStWSENyVmVLd1hMbmsvRWZXSGtFZStaRVZoY0NXeERjMkFqOTFZ?=
 =?utf-8?B?NnhKL0FxTzdaa2dDcG5EMUo1VG4zNDlNeDF6dnJwQlRrUUp6UEs5bmdFWlMv?=
 =?utf-8?B?d0h5WTBVS1cyMG1hMWRXY1l4Rk9uaER5NmFCUHdtbktzbWx4L2pLcjlxcGJp?=
 =?utf-8?B?SllDQVFzUEh3dUN4Qy9iRExaTnN6TkN5SWVpTkNrZTFVTEt3VEJUY2RqUWVZ?=
 =?utf-8?B?MS95TlM4SVhXeE9CbGJnaU9LYmdlbk5oQk1OYzlQZkZIOFFKS0twTi9FcHl3?=
 =?utf-8?B?aThKdVpVczRuOGR5bWVaMDA0RWtzNFovOHJ5T0llWXdJUzhFRmZqV2tzNTA2?=
 =?utf-8?B?Z2V0Wno4UnFJWVhBSVRscW9vaTg5VmZyL1pLMjhqSkVWVE8waTYvc1FPQWdQ?=
 =?utf-8?B?WEN0RWhOUGF0aUxwQlZCRlg3b1o1UlFJVHVGV0l4VkR6c2xkLzdnR0RobTVD?=
 =?utf-8?B?L2I5ZlhPOXY0QTloVmI3cTVmcVpDcU8vUGdZeFFaRjBLclV3QzU1N29yQzQr?=
 =?utf-8?B?N2dLeXBibHhDYUJodm1TeGJ1d3VMTmxTM0UzV3pXcEV3dHRYTS9rYTBwSzlJ?=
 =?utf-8?Q?OCU5WC1Zf4wUVuv?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 54d23dcd-4353-4e76-13c5-08db77e047e7
X-MS-Exchange-CrossTenant-AuthSource: MW5PR10MB5738.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 14:02:16.7319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w/APoHlCnawB8L4JX8lEFMXiP1yOO3E62/ARmdos0AYj+DCkJrAiLRfejTM5V1LZU4AFw3n6H6udL78H9FsaUPNnQJx0pSwIiiIf2823qO0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7029
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-06-28_09,2023-06-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0
 malwarescore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2305260000 definitions=main-2306280124
X-Proofpoint-ORIG-GUID: nXjiitgPNiqTEUy-Oty3aTC3vv1kPIqa
X-Proofpoint-GUID: nXjiitgPNiqTEUy-Oty3aTC3vv1kPIqa
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/28/23 8:46AM, Dr. David Alan Gilbert wrote:
> * Dr. David Alan Gilbert (dave@treblig.org) wrote:
>> * Tom Talpey (tom@talpey.com) wrote:
>>> On 6/27/2023 9:14 PM, linux@treblig.org wrote:
>>>> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>>>>
>>>> The smb client and server code have (mostly) duplicated code
>>>> for unicode manipulation, in particular upper case handling.
>>>>
>>>> Flatten this lot into shared code.
>>>>
>>>> There's some code that's slightly different between the two, and
>>>> I've not attempted to share that - this should be strictly a no
>>>> behaviour change set.
>>>>
>>>> I'd love to also boil out the same code from fs/jfs/ - but that's
>>>> a thought for another time (and harder since there's no good test
>>>> for it).
>>>>
>>>> Lightly tested with a module and a monolithic build, and just mounting
>>>> itself.
>>>>
>>>> This dupe was found using PMD:
>>>>     https://pmd.github.io/pmd/pmd_userdocs_cpd.html
>>>>
>>>> Dave
>>>>
>>>> Dr. David Alan Gilbert (3):
>>>>     fs/smb: Remove unicode 'lower' tables
>>>>     fs/smb: Swing unicode common code from server->common
>>>>     fs/smb/client: Use common code in client
>>>>
>>>>    fs/smb/client/cifs_unicode.c                  |   1 -
>>>>    fs/smb/client/cifs_unicode.h                  | 313 +-----------------
>>>>    fs/smb/client/cifs_uniupr.h                   | 239 -------------
>>>>    fs/smb/common/Makefile                        |   1 +
>>>>    .../uniupr.h => common/cifs_unicode_common.c} | 156 +--------
>>>>    fs/smb/common/cifs_unicode_common.h           | 279 ++++++++++++++++
>>>
>>> So far so good, but please drop the "cifs_" prefix from this new file's
>>> name, since its contents apply to later smb dialects as well.
>>
>> Sure.
> 
> Actually, would you be ok with smb_unicode_common ?  The reason is that
> you end up with a module named unicode_common  that sounds too generic.

I'd suggest make it generic and move it to fs/nls/. I'd run it by the 
nls maintainers, but I don't think there are any.

Shaggy

> 
> Dave
> 
>> Dave
>>
>>> Tom.
>>>
>>>>    fs/smb/server/unicode.c                       |   1 -
>>>>    fs/smb/server/unicode.h                       | 301 +----------------
>>>>    8 files changed, 298 insertions(+), 993 deletions(-)
>>>>    delete mode 100644 fs/smb/client/cifs_uniupr.h
>>>>    rename fs/smb/{server/uniupr.h => common/cifs_unicode_common.c} (50%)
>>>>    create mode 100644 fs/smb/common/cifs_unicode_common.h
>>>>
>> -- 
>>   -----Open up your eyes, open up your mind, open up your code -------
>> / Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \
>> \        dave @ treblig.org |                               | In Hex /
>>   \ _________________________|_____ http://www.treblig.org   |_______/