Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19267784rwd; Wed, 28 Jun 2023 07:14:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6nj4OGt8PoUy650RxBH1a8XHHKhhS9K+J8D6qhFM9ua6ng89KcE0S22V9EW6mGNC91n4nb X-Received: by 2002:a17:907:2bc8:b0:98e:4ec0:da6a with SMTP id gv8-20020a1709072bc800b0098e4ec0da6amr1461492ejc.0.1687961696607; Wed, 28 Jun 2023 07:14:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687961696; cv=none; d=google.com; s=arc-20160816; b=O5guWjq7x0GyHSABtyXR3YkJ9/TgkWa58Io1N7dFmSiTuAkwppNF301CwzPbI8PUfH v0Fi+Au4n6+SXEIEFSyciJ5kP5hHxNpR87JtQUWqOoMvCPSpZphKEC9K0xdr9JDidQkM HjyaDW8SusJktlEFvuc++PRnF2f6fM7pBlImahH4GmKUOgjeobK23ECHWQpqpAI4xOJm 39CQwxpuZcGYqFUx7knSjLsPEInIO8a2RF6e3h/yZgsRMcpFoQXjflh0ZCUnyEEUxeDw AygthhX4wZQ+rIp32N7Ps7FmdYCt+yo7YrTzPzECZoTphU+oGDKvSVquRceV/XcPvT/+ +8eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; fh=3DtDjy+qm2mKxT4PhD9WTKRbZFmgjURJ5LyxQ0kcJ64=; b=BuSXxNovYv5DMVHXAoyOBveaUO2TqPl4JLxSPJaSHtBo598j97LZuoDnhsmdmmq/cU bpDsagwa+xAHw5grWGXmuEMyKb4rVm0LNlEmzWgmjXWCXljE7bglJBUyBVvzAA97uaBM viTUeq4u9yVoml1iWxrqiICiswsEn/HUG2Mf5WLflUCYghDOeXzg1g4VdMWX1a+1XgCj HjTOv01slIveJLxcmrGn2wFcad1HxSSsNCMPGNT6REDcoHv39JuCWfSWh9t3u8hBvjWt FP6jp465o48d+8eCH9gjbf0Xy7nURI7HAgw8xlNmpu5VuW6uygorDbKruG7QrCB5HwcL r+FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="E1vo6W//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b10-20020a170906490a00b0098d482d9f3csi5854080ejq.545.2023.06.28.07.14.30; Wed, 28 Jun 2023 07:14:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="E1vo6W//"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231537AbjF1NnX (ORCPT + 99 others); Wed, 28 Jun 2023 09:43:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26245 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbjF1NnI (ORCPT ); Wed, 28 Jun 2023 09:43:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687959739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; b=E1vo6W//54F4gMefK9N52tVpQVQJWpxfu90KQqTqqK95Jf6E2kWa+vRVvH/OAQXrtKU+ho Yjsv4eO3ONJxxpnalFvbCmYYn2dA1tILI/JRPYP/H6X8pbQg4Ifm2NF40KzhddpToP41Wa D0pMZ5PqoCCfkfo+3nZhexzNaupBhYo= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-VFsD99TPO9aDnYYHSWFmsQ-1; Wed, 28 Jun 2023 09:42:15 -0400 X-MC-Unique: VFsD99TPO9aDnYYHSWFmsQ-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-4032a3ad8c0so167691cf.0 for ; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687959734; x=1690551734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rndt2IvyzL1bpq00OdsHzX63mJ29mnBqUBKzgaUOisQ=; b=GrWMThkNtIo3BIgY7cvSuBSLEG338gR1m0Du68WrpL0pWUPjRNg8R2St1fQQmLSrSu fH5RFqNSCKWGKXIjxj2l4FeZfbTd9VeFYXU6PXcn/4fTgdz73IpVp8HYDCuiYei2S+Xg IxXmngA2qDKjVEL/amaDglBW5UGrQ/4MLSSy7r6BCK6sbxXkf1SuA1va8srBARCgzz87 vQZSzmpVtHzhWoayllMu3AuzjeBrLdPm0XswHFX9DT/I2dMfwbKRUv3KAsvtzyvLCSKN 6kstyUUr1mVEcHd0RwvBQjfHBjvXn8V7sYqMCoJWU23K7DfLkk/gFCDu+L6+UyjWG61/ uXaA== X-Gm-Message-State: AC+VfDwwwVBpxfh7fDjgLfYqrRwkOSbqWC/KR6AOWehlAUq2ASmCo6f7 C+XHTXWUh1u6EpKjzLdFlQQ3sWmLUqDAebGefhbgSA6zuT4PaoJcHQCYeKkCJHgddYKQx3B4V58 16HalF/EtjvJmQUYqR7IMaKzx X-Received: by 2002:a05:622a:cd:b0:400:7965:cfe with SMTP id p13-20020a05622a00cd00b0040079650cfemr25071924qtw.4.1687959734533; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) X-Received: by 2002:a05:622a:cd:b0:400:7965:cfe with SMTP id p13-20020a05622a00cd00b0040079650cfemr25071899qtw.4.1687959734190; Wed, 28 Jun 2023 06:42:14 -0700 (PDT) Received: from x1n (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id ge6-20020a05622a5c8600b004009320adb0sm5867387qtb.80.2023.06.28.06.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 06:42:13 -0700 (PDT) Date: Wed, 28 Jun 2023 09:42:11 -0400 From: Peter Xu To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, willy@infradead.org, hannes@cmpxchg.org, mhocko@suse.com, josef@toxicpanda.com, jack@suse.cz, ldufour@linux.ibm.com, laurent.dufour@fr.ibm.com, michel@lespinasse.org, liam.howlett@oracle.com, jglisse@google.com, vbabka@suse.cz, minchan@google.com, dave@stgolabs.net, punit.agrawal@bytedance.com, lstoakes@gmail.com, hdanton@sina.com, apopple@nvidia.com, ying.huang@intel.com, david@redhat.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v4 4/6] mm: change folio_lock_or_retry to use vm_fault directly Message-ID: References: <20230628071800.544800-1-surenb@google.com> <20230628071800.544800-5-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230628071800.544800-5-surenb@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 12:17:58AM -0700, Suren Baghdasaryan wrote: > Change folio_lock_or_retry to accept vm_fault struct and return the > vm_fault_t directly. > > Suggested-by: Matthew Wilcox > Signed-off-by: Suren Baghdasaryan Acked-by: Peter Xu -- Peter Xu