Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230628011439.159678-1-linux@treblig.org> <9343462e-6a4a-ca7b-03b8-4855e5a33b72@talpey.com>
 <ZJw4iLlFWRMq6a3S@gallifrey> <ZJw50e0pvn/IN5Gj@gallifrey>
In-Reply-To: <ZJw50e0pvn/IN5Gj@gallifrey>
From:   Steve French <smfrench@gmail.com>
Date:   Wed, 28 Jun 2023 09:02:42 -0500
Message-ID: <CAH2r5muALCzCujwMZQFpWMtwvv97ZykP-1Wkf3PF4ybkgYNhGw@mail.gmail.com>
Subject: Re: [PATCH 0/3] dedupe smb unicode files
To:     "Dr. David Alan Gilbert" <linux@treblig.org>
Cc:     Tom Talpey <tom@talpey.com>, sfrench@samba.org,
        linkinjeon@kernel.org, linux-cifs@vger.kernel.org,
        jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jun 28, 2023 at 8:56=E2=80=AFAM Dr. David Alan Gilbert
<linux@treblig.org> wrote:
>
> * Dr. David Alan Gilbert (dave@treblig.org) wrote:
> > * Tom Talpey (tom@talpey.com) wrote:
> > > On 6/27/2023 9:14 PM, linux@treblig.org wrote:
> > > > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > > >
> > > > The smb client and server code have (mostly) duplicated code
> > > > for unicode manipulation, in particular upper case handling.
> > > >
> > > > Flatten this lot into shared code.
> > > >
> > > > There's some code that's slightly different between the two, and
> > > > I've not attempted to share that - this should be strictly a no
> > > > behaviour change set.
> > > >
> > > > I'd love to also boil out the same code from fs/jfs/ - but that's
> > > > a thought for another time (and harder since there's no good test
> > > > for it).
> > > >
> > > > Lightly tested with a module and a monolithic build, and just mount=
ing
> > > > itself.
> > > >
> > > > This dupe was found using PMD:
> > > >    https://pmd.github.io/pmd/pmd_userdocs_cpd.html
> > > >
> > > > Dave
> > > >
> > > > Dr. David Alan Gilbert (3):
> > > >    fs/smb: Remove unicode 'lower' tables
> > > >    fs/smb: Swing unicode common code from server->common
> > > >    fs/smb/client: Use common code in client
> > > >
> > > >   fs/smb/client/cifs_unicode.c                  |   1 -
> > > >   fs/smb/client/cifs_unicode.h                  | 313 +------------=
-----
> > > >   fs/smb/client/cifs_uniupr.h                   | 239 -------------
> > > >   fs/smb/common/Makefile                        |   1 +
> > > >   .../uniupr.h =3D> common/cifs_unicode_common.c} | 156 +--------
> > > >   fs/smb/common/cifs_unicode_common.h           | 279 +++++++++++++=
+++
> > >
> > > So far so good, but please drop the "cifs_" prefix from this new file=
's
> > > name, since its contents apply to later smb dialects as well.
> >
> > Sure.
>
> Actually, would you be ok with smb_unicode_common ?  The reason is that
> you end up with a module named unicode_common  that sounds too generic.

Since it is already in the smb/common directory, seems easier to name them:
smb/common/unicode.c
or smb/common/smb_unicode.c

--=20
Thanks,

Steve