Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4d8a22dfc36abff1b4cd1e6ff7c03107dcfb4eb.camel@ndufresne.ca>
Subject: Re: [PATCH] media: amphion: reinit vpu if reqbufs output 0
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Ming Qian <ming.qian@nxp.com>, mchehab@kernel.org,
        hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        xiahong.bao@nxp.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Date:   Wed, 28 Jun 2023 10:14:54 -0400
In-Reply-To: <20230613074846.25964-1-ming.qian@nxp.com>
References: <20230613074846.25964-1-ming.qian@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Hi,

Le mardi 13 juin 2023 =C3=A0 15:48 +0800, Ming Qian a =C3=A9crit=C2=A0:
> according to v4l2 stateful decoder document 4.5.1.3. State Machine,
> the state should change from seek to initialization
> if call VIDIOC_REQBUFS(OUTPUT, 0).
>=20
> so reinit the vpu decoder if reqbufs output 0
>=20
> Fixes: 6de8d628df6e ("media: amphion: add v4l2 m2m vpu decoder stateful d=
river")
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
>=20

No regressions seen with this change so far.

Tested-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

And also:

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

thanks,
Nicolas
=20
> ---
>  drivers/media/platform/amphion/vdec.c     | 2 --
>  drivers/media/platform/amphion/vpu_v4l2.c | 7 ++++++-
>  2 files changed, 6 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/media/platform/amphion/vdec.c b/drivers/media/platfo=
rm/amphion/vdec.c
> index 6515f3cdb7a7..56c4deea4494 100644
> --- a/drivers/media/platform/amphion/vdec.c
> +++ b/drivers/media/platform/amphion/vdec.c
> @@ -1453,9 +1453,7 @@ static void vdec_release(struct vpu_inst *inst)
>  {
>  	if (inst->id !=3D VPU_INST_NULL_ID)
>  		vpu_trace(inst->dev, "[%d]\n", inst->id);
> -	vpu_inst_lock(inst);
>  	vdec_stop(inst, true);
> -	vpu_inst_unlock(inst);
>  }
> =20
>  static void vdec_cleanup(struct vpu_inst *inst)
> diff --git a/drivers/media/platform/amphion/vpu_v4l2.c b/drivers/media/pl=
atform/amphion/vpu_v4l2.c
> index 810e93d2c954..8c9028df3bf4 100644
> --- a/drivers/media/platform/amphion/vpu_v4l2.c
> +++ b/drivers/media/platform/amphion/vpu_v4l2.c
> @@ -489,6 +489,11 @@ static int vpu_vb2_queue_setup(struct vb2_queue *vq,
>  	for (i =3D 0; i < cur_fmt->mem_planes; i++)
>  		psize[i] =3D vpu_get_fmt_plane_size(cur_fmt, i);
> =20
> +	if (V4L2_TYPE_IS_OUTPUT(vq->type) && inst->state =3D=3D VPU_CODEC_STATE=
_SEEK) {
> +		vpu_trace(inst->dev, "reinit when VIDIOC_REQBUFS(OUTPUT, 0)\n");
> +		call_void_vop(inst, release);
> +	}
> +
>  	return 0;
>  }
> =20
> @@ -773,9 +778,9 @@ int vpu_v4l2_close(struct file *file)
>  		v4l2_m2m_ctx_release(inst->fh.m2m_ctx);
>  		inst->fh.m2m_ctx =3D NULL;
>  	}
> +	call_void_vop(inst, release);
>  	vpu_inst_unlock(inst);
> =20
> -	call_void_vop(inst, release);
>  	vpu_inst_unregister(inst);
>  	vpu_inst_put(inst);
> =20