Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19356603rwd; Wed, 28 Jun 2023 08:16:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6XcDmjsdEcLt+VQzsfoysQ9xoet2HRVLNr1N5KTBk0HQiS6bYArGIga8Fmku2atDspzKYh X-Received: by 2002:a17:90a:7f84:b0:261:110e:3d93 with SMTP id m4-20020a17090a7f8400b00261110e3d93mr18894060pjl.45.1687965418034; Wed, 28 Jun 2023 08:16:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687965418; cv=none; d=google.com; s=arc-20160816; b=bgNtlTT8cyEQOGh7oE0Xc2ZuNFv61xna33sNj9T0NmnVuT3t0fJdX3CLG90mGWxW4i YxKPK00CINiSbZ8uzfSC3LPkFFfaWJAJwt2QBeqpTXjbnd5Xnb0h3YIJhste+exV9eQd Z6EKvD/627vltF160qf/tAJa0gU1h3aDJCyYQGQTsJ6i/aNEf3RrP8pz3XeE/+F7tltq r5IxL5zAFaTvyO6NQ1Fzh6iPJGkGQl9NgEPu3zc8reT+AyXbLr4rM4FOWq8cid6mm9dG UIRgtDzt7ZW1Si+3aNyia3RtDDDWy4in3vI/LXjVLmoYLypRJDKCQQfvMy7I7iLWef9E whmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:references :in-reply-to:mime-version:dkim-signature; bh=tYONJNnGCQMJ80wSHKkNy+/9k7bcbNipagC4FIaSVh4=; fh=OQT8nI1IXiY39bUSFdrzXLevoelLgeXbn42G6yWcoSI=; b=x7Uh3BhSWZaB4a/Q9NHDUTAQAvHpgaM6IpK8nkSdaCdaQc7n6nK/ZBz7iPPnb3UlJa 0on6jLRMgh2w7v24RBwc76+IuKCj0vMdEnnO/vpCtaJ35FHm88F+RDYyiMb5u9edbw68 2AH+BVIpG2UEl9lrB6qgwvEC6zpn9C0xpO73l9oxRrhbaaLQkSVwntAUH3IOfMcTj0gA DP32IatYMHWXKlf8JcPKSB47Miz9ALpM9Jlz/OJKMsW9B6SStH+fbsoiiTNeaqIaXpZT Qdox2nLW86p80q3NyXTxs8zxHUyv6Mm/BqS4j33AY2bi9HwDtspTZrvzynfuJtxYykTD HK3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fH3IUtR0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gl4-20020a17090b120400b0026350f0644asi72104pjb.65.2023.06.28.08.16.45; Wed, 28 Jun 2023 08:16:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fH3IUtR0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbjF1PHE (ORCPT + 99 others); Wed, 28 Jun 2023 11:07:04 -0400 Received: from dfw.source.kernel.org ([139.178.84.217]:55358 "EHLO dfw.source.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231969AbjF1PGz (ORCPT ); Wed, 28 Jun 2023 11:06:55 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C8AF6124B; Wed, 28 Jun 2023 15:06:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C45C8C433C8; Wed, 28 Jun 2023 15:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687964814; bh=tYONJNnGCQMJ80wSHKkNy+/9k7bcbNipagC4FIaSVh4=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=fH3IUtR0gjCfGcOCNMckBP2f/Vs37X+rPVTO1uoh0Ocxu9vLx7mIfIgmE5UNXcRoM ogAbNleaeEMIL8vXfLUV9xsABdJYxzznt/+oUqFmmJgFQwmfr4ykUEi5VdEqL4emt1 VBrN0WQBW8RAQNhUWwGsrd7t1QlsAWmwUIRBJveXODht9U2Z5gU0KpuSJvCl+MFffJ ZJ1Pg/F3xXwfFeeY29HbU7PmpVANRdsdDrdVOqc+In+rrGj/DN+DLIwgZIC5FnbX8k x0aRa3Iax38OyIKeajKR4UkyJWdPxg6NH7l2luXYY/3JH5xRtngl8too4lulS6neTZ LmMjwNWo1RHZg== Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-55b8f1c930eso3717093eaf.3; Wed, 28 Jun 2023 08:06:54 -0700 (PDT) X-Gm-Message-State: AC+VfDynyw2x7qiJl5b2bHVt5o/pujFI9Aq8DGoUmYWrosoO9K1MoV2/ gkflC5YJvfSUFOVE4fxLgKNEip4oOHhE6c5cA+o= X-Received: by 2002:a05:6820:396:b0:563:5542:c45 with SMTP id r22-20020a056820039600b0056355420c45mr5562605ooj.7.1687964813976; Wed, 28 Jun 2023 08:06:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:ac9:7a97:0:b0:4e8:f6ff:2aab with HTTP; Wed, 28 Jun 2023 08:06:53 -0700 (PDT) In-Reply-To: <20230628011439.159678-3-linux@treblig.org> References: <20230628011439.159678-1-linux@treblig.org> <20230628011439.159678-3-linux@treblig.org> From: Namjae Jeon Date: Thu, 29 Jun 2023 00:06:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/3] fs/smb: Swing unicode common code from server->common To: linux@treblig.org Cc: sfrench@samba.org, linux-cifs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2023-06-28 10:14 GMT+09:00, linux@treblig.org : > From: "Dr. David Alan Gilbert" > > Swing most of the inline functions and unicode tables into smb/common > from the copy in smb/server. > > UniStrcat has different types between the client and server > versions so I've not moved it (although I suspect it's OK). ksmbd doesn't use this function. You can move it to smb_unicode_common.h. Thanks.