Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19368892rwd; Wed, 28 Jun 2023 08:25:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6Fawl9kGdAj9+qUro8Sek72TXqr2zUKJaFr/LScOH7CyooPFXnZYlG6GagpZYVSHJXcnZO X-Received: by 2002:a17:906:58c5:b0:988:817c:ed59 with SMTP id e5-20020a17090658c500b00988817ced59mr23635268ejs.32.1687965953840; Wed, 28 Jun 2023 08:25:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687965953; cv=none; d=google.com; s=arc-20160816; b=Te0Pqv/KMh6qlqyuRG7MxAiBpxzzySqCw7h5N+ilTMxioeqZaKWfAuCPYA7rwOzCKX /xpNTN7/2+FbL34kh6g734MDc/I7PNUzY2cn5T1/3ehonA/hYmxH5+Fo3Hp/hbeBeRFW 44NJa/duyNGhCc5arkCZERgvb2ENmojbMD2JUbdYqtYxJzb/qRytrDpnekhIGHCRj6Gs QZSYQ6yXbasdk8ULgeHTk02e0zvD+x8OT7VA1bjBx/i2KAyEhjNd99TMRzlrAY8lK2fU 6GRKuQ4dNX53Jt1Aqg0OCrGmr0xqa0zhjPebegqv8k6gh1fEJ5bt76x4QoaG8qEfMUet 4iVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=8wS0/tVVfYmWAxxo37y+v0M6HIvge1vajIKiOpWu/wQ=; fh=HNsa2JVj4vnmZSQJP08V/ueSUmjnoR3lQLuUsMYLEQY=; b=dV0g2ZJWqNSNypGahFsYDMQN1w3iI4+v3nRgIDHe53a3/CX4sofnMx3bhbObVcrsXv tFxKhzkXPihhqmBp/N0/xsF7sBRCuNd77zUCPWzC4Pyi88Uh+377ozh+FlKYM5TcwuHs 0AXWtE7ZsR5BVAJ9PdNRNqsEUJ6WoU9rltgxNaEllvku5GXSuWsaClJEqHU/XRDk4JiP N/0IU/q4bHNTB45pmiXNFpdAVWA+CCjKvQajojwMDwJXJ4pRZ6wj8gGCsskB5CBjFFvw rlpa0UO5XyKQ06bnLmcJi1+I6R5WQ0sFTA210lkRvLhQc2YfFOrHrn0Bk0zk5omlpz4h 8wKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ME6xclwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t7-20020a17090616c700b0098888ba2920si5673093ejd.818.2023.06.28.08.25.27; Wed, 28 Jun 2023 08:25:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ME6xclwZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjF1PDl (ORCPT + 99 others); Wed, 28 Jun 2023 11:03:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231940AbjF1PDh (ORCPT ); Wed, 28 Jun 2023 11:03:37 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC03A10D5; Wed, 28 Jun 2023 08:03:36 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-98e011f45ffso474652066b.3; Wed, 28 Jun 2023 08:03:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687964615; x=1690556615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8wS0/tVVfYmWAxxo37y+v0M6HIvge1vajIKiOpWu/wQ=; b=ME6xclwZwAKxvdbSiH7N5rG8ryo5U4E538D0nnDMbunKQdRXYX78PbUueytpfqLFhB nm08tVIGha1qYoNPECIqFEOr8sams/BfwupmWtLEwvaZJUuaKt5dth9n41ZkWYLW0OBF 58vvJ9OclwmfZLNmoRSfzZrfs9sEBCIKTLFU59hrHX525xL9UnaJKwT/8RozQJWOIbYS Hn52ieE/PTBNEveYm0ZQ5w38seM577yXEC2AFMLmrOg60VLG2wH5q1Tr1UpzIHIuhT4C 0QxQRRt7Op67cHEbPJjCJETKBf7cX9JIXGomfJtJeRl04FaW9ZXeIv7oFBWv9Xz80Pns aw9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687964615; x=1690556615; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8wS0/tVVfYmWAxxo37y+v0M6HIvge1vajIKiOpWu/wQ=; b=UvnIajN4KnO2WL323bENQcwoaDqRkp+wSSl9rycdpZGad2pynKuFSn84VQvETEhRS9 3p9vMun9Yh519QcohpdZzCSKzT6ldZjA7n99Kcr6qiQks/asUQ6G0dG8RaQ3PHvy10p/ i9rHn7JfLCCWlNabUuVePoMi487Qvgh0aoRM5g/UhVunYgrdef/NjfepqZtNYr8h25aX 3HxZxCaB082rJxJaOxzl1bsQMAWuV7sQ5Yjb5JWGBFAOjDAGVAnJ+JzDQuzOyzzrWhnD ikSLbMYh555UDG9PcxkYGCCPlqjDHgqcYLAUVxZn8cQ6OpZC/177SBJAyR6ubp82EjMY PvmA== X-Gm-Message-State: AC+VfDyrHetMobcKKMdnZ0wXaDcPPHSZ7I3uhXUIOICNG3Oo57a74ti7 lZzuyDKLmWreANZVBI6+wuVeL8amyYdmGu0NzCHYK9sM X-Received: by 2002:a17:907:6d1d:b0:992:4a1b:30e2 with SMTP id sa29-20020a1709076d1d00b009924a1b30e2mr3237054ejc.7.1687964614906; Wed, 28 Jun 2023 08:03:34 -0700 (PDT) MIME-Version: 1.0 References: <20230628011439.159678-1-linux@treblig.org> <9343462e-6a4a-ca7b-03b8-4855e5a33b72@talpey.com> <90f35697-5941-d42d-b600-245454cbd040@oracle.com> In-Reply-To: From: Steve French Date: Wed, 28 Jun 2023 10:03:22 -0500 Message-ID: Subject: Re: [Jfs-discussion] [PATCH 0/3] dedupe smb unicode files To: "Dr. David Alan Gilbert" Cc: Dave Kleikamp , krisman@collabora.com, Tom Talpey , sfrench@samba.org, linux-cifs@vger.kernel.org, jfs-discussion@lists.sourceforge.net, linkinjeon@kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 9:40=E2=80=AFAM Dr. David Alan Gilbert wrote: > > > Actually, would you be ok with smb_unicode_common ? The reason is th= at > > > you end up with a module named unicode_common that sounds too generi= c. > > > > I'd suggest make it generic and move it to fs/nls/. I'd run it by the n= ls > > maintainers, but I don't think there are any. > > Steve & Tom - would you be OK with that? Yes - absolutely > (Copying in Gabriel Bertazi, owner of fs/unicode; although this isn't > utf-8) Unicode UCS-2 --=20 Thanks, Steve