Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 17:42:06 +0100
From:   Gary Guo <gary@garyguo.net>
To:     "Qingsong Chen" <changxian.cqs@antgroup.com>
Cc:     linux-kernel@vger.kernel.org,
        "=?UTF-8?B?55Sw5rSq5Lqu?=" <tate.thl@antgroup.com>,
        "Miguel Ojeda" <ojeda@kernel.org>,
        "Alex Gaynor" <alex.gaynor@gmail.com>,
        "Wedson Almeida Filho" <wedsonaf@gmail.com>,
        "Boqun Feng" <boqun.feng@gmail.com>,
        "=?UTF-8?B?QmrDtnJu?= Roy Baron" <bjorn3_gh@protonmail.com>,
        "Benno Lossin" <benno.lossin@proton.me>,
        "Sergio =?UTF-8?B?R29uesOhbGV6?= Collado" <sergio.collado@gmail.com>,
        <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH 1/1] rust: macros: fix redefine const_name in `vtable`
Message-ID: <20230628174206.1e820326.gary@garyguo.net>
In-Reply-To: <20230626074242.3945398-2-changxian.cqs@antgroup.com>
References: <20230626074242.3945398-1-changxian.cqs@antgroup.com>
        <20230626074242.3945398-2-changxian.cqs@antgroup.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XKtluwzqqOBbbhs6HTSPSHGT886opHFkRp25vFd44xXa3dvj0guLY9JU+a3c?=
 =?us-ascii?Q?Uwz3neQUV8JdFkOfUtTrWdEiZ6GAvj4B/aMcv+47l1/CqvKFu3VA05YxTmqA?=
 =?us-ascii?Q?Wa15FBRU8d1JUyT8/EHC+uz1C3qM5po6VqHGk07H5CEKtV+lIwQ6JiueSsLG?=
 =?us-ascii?Q?o1b0osIvse6Tg4Ky6+9OZJNpgSjCWAuzfIF/Zd2Z6eHz1BzHHZLLC5cJnt8R?=
 =?us-ascii?Q?/v1olA6yPp7XdEc6i4zpyYlFQ142baaPnoWZZiI27Os0ZCMcz7IMAtOPX5sW?=
 =?us-ascii?Q?ZIFo5l9NA8lU/umrEastpkWjxvnljrhLKfOGEgfr/5Y+xQNGJKn5NMTJg2Z2?=
 =?us-ascii?Q?CdusHa6fmLhpsD/1VjQ5tbP7VMgwrLWOlIYdiKamMH5tYGT886Gu790frCVW?=
 =?us-ascii?Q?KlOOpWcURCKLQNN/YpaFqupzTd5uok/MhUozjwZWED/6/59F7MnAbrg4coAj?=
 =?us-ascii?Q?9tY0RJZrbWtB8drx/kTuzFwhl+jvVvTAGLkHAbWA4UUd/j3IMjZ3WvdWuXJ6?=
 =?us-ascii?Q?X7fffdFzYzBqQsHttXPw4LfqNviml4CHGZB8+Ed1qmvRPA6nOS1uPJZXtQyv?=
 =?us-ascii?Q?ZTkthVFX3Eiz40rQuF4dTplqaiQOu18DR/KH6k1pdF4l2S/KA3ZDuqJUOERN?=
 =?us-ascii?Q?quUfTh3/pGLFNj6M1eBNrurFqjOFrtA4UpItcWkRe75y+zSJVHBGCwWCDnO5?=
 =?us-ascii?Q?53sCe7FUzA8J8l7BwpacXQCL4Ws70EKvnBmIq4VEKBU65doW3z4oB0uWt0yY?=
 =?us-ascii?Q?AAexDuZ08uvxvnv5sG8Qofdov2IGZzxQ3IuEPICaF0cJ5VJ1umyCSGeIUooY?=
 =?us-ascii?Q?EPiHV7AxP9bZokqqIQLw8PDygkb9NsyFjtHYQ1Z9qEN9EForVeQyyeFsqgum?=
 =?us-ascii?Q?+ots4pLoo8LIqdejC0pQI/Z2Wk/l8ioxuFBSscHutWg3siDvp8bbuOFkR58b?=
 =?us-ascii?Q?qvYp+fwW3TyY9agO1pTggQXNqZ+mDa0ij+GYjusWa05yEEpvwpRj+9fOqvuE?=
 =?us-ascii?Q?PKq9HC2NT6StSmOyFxgZL9ZuhLPcpg9kuWgLhll25CbOlgEYDn71IFOS+Usi?=
 =?us-ascii?Q?erijYlqJz9m6gyeu+mY2w25vQOozLqpsfI3HTryMYV4ybHThpgqGGHs8ngYT?=
 =?us-ascii?Q?8oyQY51RT2yStvj3/8W2lktrT+vWFB3BrObhVtWmYdO4/q6GAg4JjDZvInz1?=
 =?us-ascii?Q?a1Gn3shyzE2kURoMfGvjp6ZSssMWUdmmn/W+CxfjXgDB526OAlsuJtjQMwTs?=
 =?us-ascii?Q?u5HzYzsUHdACpn/Z6a1oqb4X1v+Gcare5Pp0bZFmNw/HXC3vKOq5Mkt92OQF?=
 =?us-ascii?Q?pmkBMVBn87eBNR/EeAFvV6UZpmYcDPPsibo1den3xROkR3ZBr1bC32rc0DeU?=
 =?us-ascii?Q?wH88kQcNjeANGKk5bWVXH5mnztTh4/JMIsAC4ZS3QY8aD8EHZSC01g6BOHXZ?=
 =?us-ascii?Q?pa6O6ti1qCS9R93AgAjF5pMYG1gMJLPleO5o5KwA1keQ4WDyXCSQCHBkhFLh?=
 =?us-ascii?Q?5/dHoDuUGs6iwtWM0n2RLwETzSBocA+muMKDeruit+FgN51Pnd6qDRkJ80sb?=
 =?us-ascii?Q?jIuwH0BblxUnSxzNn0o+qQPWS2hzffSIDlj8BegY?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 18fb44ab-7066-46f5-0139-08db77f69d09
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 16:42:08.4861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tO816HKvCCODZoOYQNbk2B0nptZdsyrrVO65F5q/pu7xKway6aJXsJDjhWCpWF3lviJCjc7e3+qyazAY8IMnYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5570
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 26 Jun 2023 15:42:42 +0800
"Qingsong Chen" <changxian.cqs@antgroup.com> wrote:

> If the trait has same function name, the `vtable` macro
> will redefine its `gen_const_name`, e.g.:
> ```rust
>     #[vtable]
>     pub trait Foo {
>         #[cfg(CONFIG_X)]
>         fn bar();
> 
>         #[cfg(not(CONFIG_X))]
>         fn bar(x: usize);
>     }
> ```
> Use `HashSet` to avoid this.
> 
> Signed-off-by: Qingsong Chen <changxian.cqs@antgroup.com>

Reviewed-by: Gary Guo <gary@garyguo.net>

> ---
>  rust/macros/vtable.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/rust/macros/vtable.rs b/rust/macros/vtable.rs
> index 34d5e7fb5768..08eb0355f99b 100644
> --- a/rust/macros/vtable.rs
> +++ b/rust/macros/vtable.rs
> @@ -27,7 +27,7 @@ pub(crate) fn vtable(_attr: TokenStream, ts: TokenStream) -> TokenStream {
>      };
>  
>      let mut body_it = body.stream().into_iter();
> -    let mut functions = Vec::new();
> +    let mut functions = HashSet::new();
>      let mut consts = HashSet::new();
>      while let Some(token) = body_it.next() {
>          match token {
> @@ -37,7 +37,7 @@ pub(crate) fn vtable(_attr: TokenStream, ts: TokenStream) -> TokenStream {
>                      // Possibly we've encountered a fn pointer type instead.
>                      _ => continue,
>                  };
> -                functions.push(fn_name);
> +                functions.insert(fn_name);
>              }
>              TokenTree::Ident(ident) if ident.to_string() == "const" => {
>                  let const_name = match body_it.next() {