Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230628082716.2075736-1-sergio.paracuellos@gmail.com> <20230628154022.GA520881-robh@kernel.org>
In-Reply-To: <20230628154022.GA520881-robh@kernel.org>
From:   Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date:   Wed, 28 Jun 2023 18:42:51 +0200
Message-ID: <CAMhs-H_WD7tkawv1cg3GympqyzzPwK4Es_GxoFD5gPR=Y0H7kw@mail.gmail.com>
Subject: Re: [PATCH] dt-bindings: timer: add Ralink SoCs system tick counter
To:     Rob Herring <robh@kernel.org>
Cc:     devicetree@vger.kernel.org, tglx@linutronix.de,
        daniel.lezcano@linaro.org, krzysztof.kozlowski+dt@linaro.org,
        conor+dt@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rob,

On Wed, Jun 28, 2023 at 5:40=E2=80=AFPM Rob Herring <robh@kernel.org> wrote=
:
>
> On Wed, Jun 28, 2023 at 10:27:16AM +0200, Sergio Paracuellos wrote:
> > Add YAML doc for the system tick counter which is present on Ralink SoC=
s.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> >  .../bindings/timer/ralink,cevt-systick.yaml   | 38 +++++++++++++++++++
> >  1 file changed, 38 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/timer/ralink,cevt=
-systick.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/timer/ralink,cevt-systic=
k.yaml b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > new file mode 100644
> > index 000000000000..59d97feddf4e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/timer/ralink,cevt-systick.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/timer/ralink,cevt-systick.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: System tick counter present in Ralink family SoCs
> > +
> > +maintainers:
> > +  - Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > +
> > +properties:
> > +  compatible:
> > +    const: ralink,cevt-systick
>
> What is "cevt"? Would be nice to define. Really this should have been
> SoC specific, but it looks like it has been upstream "forever", so fine.

Not sure what cevt really means, I guess maybe "clock event"? Inside
the documentation this is just listed as "System Tick Counter". It is
upstreamed since Ralink SoCs are on tree. I am just documenting
already mainlined stuff since there are lots of missing  binding docs
for old Ralink SoCs.

>
> Otherwise,
>
> Reviewed-by: Rob Herring <robh@kernel.org>

Thanks!

Best regards,
    Sergio Paracuellos
>
> (the error report can be ignored)