Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     Koba Ko <koba.ko@canonical.com>, Borislav Petkov <bp@alien8.de>,
        "James Morse" <james.morse@arm.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Robert Richter <rric@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] EDAC/i10nm: shift exponent is negative
Thread-Topic: [PATCH] EDAC/i10nm: shift exponent is negative
Thread-Index: AQHZqZ42gpR/+sqH6EKfNSuXrGx/Qa+gaXxA
Date:   Wed, 28 Jun 2023 16:39:46 +0000
Message-ID: <SJ1PR11MB608340E81A15F20EBAD75F08FC24A@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20230628085253.1013799-1-koba.ko@canonical.com>
In-Reply-To: <20230628085253.1013799-1-koba.ko@canonical.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6MYkNN92uKx2lVX+UcCr+27C7KZiBQFVhsYiPdAKVxRwJU0owoq/8P/X2GJq?=
 =?us-ascii?Q?PdNaWlaJRuUeStKlmgrllEcqbqjOsraBMl5zF/qSfMbYx26pr91KouW4MahC?=
 =?us-ascii?Q?ukywsyxnOwrsXoqZ9DlHxqzc7oQJhDzCAR08oNHyCP1YDiQPReHfgzwJYiS4?=
 =?us-ascii?Q?tLczxKAMwKWZ43Gopt4i+oFqFSAX+6IrD+eyo4BgSox1Np+Fm6XaJEBsGCWe?=
 =?us-ascii?Q?AymdAn3Fe5JHryeLU4eZYZXaiT01cRFKZ3BYkp1BXkpTOoiuCii8KDE1QKwH?=
 =?us-ascii?Q?ZzeR1BSiR6NAohnynOcf9HO8ZZ6EI3LMStnOm5ctGIsjq6e9zKbDNH77tp7o?=
 =?us-ascii?Q?3xdWyg3ItXzmtxWVTDpbwfwJwY1Vc+2l+cyfrashiVUOJ8twPj6ZPsGUneem?=
 =?us-ascii?Q?7mnzwzlxLNnfZhMTVmSP1JPr1ja31JAXdMVkEQrvi44J29ZdFr6nhwibTZ1Q?=
 =?us-ascii?Q?zOy1HBY1leyI3UO4pTT0LSSP1KfyMXjEULc9QeLiBX2uxuv4bWf3ouTIkH0J?=
 =?us-ascii?Q?kmcYn1qTbYDNb6ZccvinpxoyHh1ED5c0K93TZB44sU5yhUwpf3SEQb50siyW?=
 =?us-ascii?Q?+WG3pSKZMSGQV0i/TLiSxB7cY2U60mtbYPyVSgUefwwhlGdbDSgllrX3SwE2?=
 =?us-ascii?Q?3sDoniMvVeyjS6R1lo0MPxmbwMoWm73CUUz/6PiNFboNDVWOxcCJ0QTQMgFe?=
 =?us-ascii?Q?ilETevo6aL/4gjNOWKXnWiG8fZZdH/TCd9Pr+PCpeksUF3urnWBXKLE/E/gV?=
 =?us-ascii?Q?oddfae76umnD4E9VXqG44lrC9O1HaMJzSBiVzSZxDM4iSrYQrwgyuF3AMS11?=
 =?us-ascii?Q?4geogoQ4M+bDCOHrM8UX6TFLrawe16wP8f2FUAelW6U1RwVg6TkbmH/cvtDT?=
 =?us-ascii?Q?KbQEpm2bf8N9SKXKdp2OFOgEav2yqhuqRy1Iuq8Y3rTXFenO73f+/Ch2dgjO?=
 =?us-ascii?Q?Z+Eu5fIHM0yVrDd2z3748ZY6OfSQV/f9eNWmfdV8b4a07BY5ccUF2YBmXKpO?=
 =?us-ascii?Q?n/C5I3OxY6rJeiju8H4b8OkyBFY3+IJWVCBKZ++XR297HY2ZMVyzaDO6fWUu?=
 =?us-ascii?Q?h9NFKKo1IU5n8OmGQB6ZmKe2Y3IUkupHuvaZs++jhNyB9stldDvT16tmQQyN?=
 =?us-ascii?Q?urCLz43pxIjv1Dhavy/EtyedZkwHkL3FY9fygYRC12OJ8xfOr75rKG/4blGZ?=
 =?us-ascii?Q?WSf0RR2KgXXYfDTe5YrNfFT4wraJUpmScBhyMDAzdGCZw6pvGVpAIOjY/9Om?=
 =?us-ascii?Q?AZDaaGbtU82gpli4X258zXF96thV5JybWJ1fGoTtjRaMUCtQfqcrbOnId7WI?=
 =?us-ascii?Q?XK03KcahNJajDURxvyHZzSfu41WYG8W5Ye/rR81YLUk9ty52axFhKC1INhCc?=
 =?us-ascii?Q?QUca8UYpZY9ATF5dtk4MttQ3B7JS/iEI/gHs1UXkctSOSSkyiTqJ/+aUxz8Q?=
 =?us-ascii?Q?BQ4CDK1b2hKgqm+IHtbO3/6hy/d1/Hbi7sRnWeeZNIF3ZggnsUwQHJH4cU0G?=
 =?us-ascii?Q?Lf1PcDR62gPFBdI2ePbLERqTpRQSE2PA6S8czWsETIr5jRGBWPPHAkqDs3RP?=
 =?us-ascii?Q?hXNBB7DBKKgZ2L6/kGA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 154c76e0-5bff-4804-d43d-08db77f64885
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 16:39:46.5259
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7aKYUhyAEeAeV+rMocGZjL8zuN0H/y+WyzP71RlXCuk7JpkBE7oR3KNXuECRZ3I5+4k90tSuDdIgEGUjuNIxPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6655
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>       ranks =3D numrank(mtr);
>       rows =3D numrow(mtr);
>       cols =3D imc->hbm_mc ? 6 : numcol(mtr);
> +     if (ranks =3D=3D -EINVAL || rows =3D=3D -EINVAL || cols =3D=3D -EIN=
VAL)
> +             return 0;

This seems to be just hiding the real problem that a DIMM was found
with some number of ranks, rows, or columns that the EDAC driver
didn't expect to see. Your fix makes the driver skip over this DIMM.

Can you build your kernel with CONFIG_EDAC_DEBUG=3Dy and see
what messages you get from this code:

static int skx_get_dimm_attr(u32 reg, int lobit, int hibit, int add,
                             int minval, int maxval, const char *name)
{
        u32 val =3D GET_BITFIELD(reg, lobit, hibit);

        if (val < minval || val > maxval) {
                edac_dbg(2, "bad %s =3D %d (raw=3D0x%x)\n", name, val, reg)=
;
                return -EINVAL;
        }

-Tony