Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 28 Jun 2023 17:48:07 +0100
From:   Gary Guo <gary@garyguo.net>
To:     Benno Lossin <benno.lossin@proton.me>
Cc:     Miguel Ojeda <ojeda@kernel.org>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        =?UTF-8?B?QmrDtnJu?= Roy Baron <bjorn3_gh@protonmail.com>,
        Alice Ryhl <aliceryhl@google.com>,
        Andreas Hindborg <nmi@metaspace.dk>,
        rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
        patches@lists.linux.dev, Asahi Lina <lina@asahilina.net>
Subject: Re: [PATCH 3/7] rust: init: make guards in the init macros hygienic
Message-ID: <20230628174807.5eabf3bd.gary@garyguo.net>
In-Reply-To: <w4kyaXwWZEyoBoCCFmVtRmkUS6d0m_DJYTs7OVWLkbBX7PFwjj_wemi1mtvSemjUyhZwSDCA2l-5fXn4sxO4C3DT_8wGyZebpea-wQseOmA=@proton.me>
References: <20230624092330.157338-1-benno.lossin@proton.me>
        <20230624092330.157338-3-benno.lossin@proton.me>
        <20230625215453.25aa38a0.gary@garyguo.net>
        <w4kyaXwWZEyoBoCCFmVtRmkUS6d0m_DJYTs7OVWLkbBX7PFwjj_wemi1mtvSemjUyhZwSDCA2l-5fXn4sxO4C3DT_8wGyZebpea-wQseOmA=@proton.me>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W4W+DiNMEzf0N2Gx4Zzk6L9eNMU1irUSpholttpaXZ6VlGYpIHOHf6++87K/?=
 =?us-ascii?Q?lFfup1dy5TQHCJzvIrjOpv0bYxta+vgoUjszVN3n/7jpgy2scRv6K5Lf3fak?=
 =?us-ascii?Q?kyWFI9mMEG1Ni28DknUJOQoGwnDrVxWw8isdFCIVA1osscjVpiw39dl/wDcK?=
 =?us-ascii?Q?xBLhzgks+lOX3/NnqPtW2PhFbwA0Qwe6W4A8ymQPzk0anpmZiOgKrZ41Hyaj?=
 =?us-ascii?Q?9yLuuoVtDK/cOT12pcy9SuuGLXRgsVqAYKJbGYmjTTIkDpYI+fHHou96CGob?=
 =?us-ascii?Q?OgenFxf8cTaqx83QIxyJCv95hKYLjV4NaUb37WlANwauQX9FGQlwO/srs/wt?=
 =?us-ascii?Q?mZquUutl253vBsghkp1PXfo0mSzx3ZhHqHiUSx4YFlYiqHguPm8m+zziIV31?=
 =?us-ascii?Q?iQbom86foPebsoKA2meMCCc5ZYggWEIW9ReZV7jZeJuQNLFf2W0xKL23KMT0?=
 =?us-ascii?Q?CENTpbP18hS9qzaD/Sjx6tNMlOjmsYKFl4cpp/LIbmiSBIF76evSv4GaNHMe?=
 =?us-ascii?Q?ouTBb6MFqRiwyc5rnLkG7Z9CxjWXRuBiXyPaHNgcShhL2tCcYi+zIFoPEU4o?=
 =?us-ascii?Q?8vFt8vT1Ts8nf7yZlzrC0Mh+ZKB4UvxI2N53a52+xtSCkP0gAllt7gScwroJ?=
 =?us-ascii?Q?1gn226w29mLmPzoWbheXJSzVdvcE3EaRUuGz4R/W9LgYI9YK5khL1vCM6ZyL?=
 =?us-ascii?Q?O7wY4EIwmfJOWsPGSKLcUbejO6ruKsE6OG0vpYDpBcVwJ5H0JoDeMYNC87GS?=
 =?us-ascii?Q?Lgtpn75aT2qLOF5am0HHWMcdy+twzspoD9G+QZFViaOE1vXrtE1XCzboUuaJ?=
 =?us-ascii?Q?vkb/31K+CfQzd19wUZ2WUeKvKLg9yFpbpN68M1Wru/wZ56FpF2dr98YalZfJ?=
 =?us-ascii?Q?WywSuOFy5w8U4CkdaN6t3zdXZZUef7bmdLFKhmMbxEj3WTwDwD8JIBru9sJ5?=
 =?us-ascii?Q?Jnhx+Xxk9UisY01n6H0tPLppISBZYAXOTKDD0fjLdZ/lJm6dLzDEkjof1h7n?=
 =?us-ascii?Q?dSLgBRcpFDzrIoL/YFY1HAQoZsrw/lQGJCZhCgKD8RB6XykqduKQd4JtbRkc?=
 =?us-ascii?Q?2ScO4BfxwKQP/3sddvfoTpmS4ZmE3SlHjtmPpFO95YQFM5KZ/5ifMtJ+Sg8K?=
 =?us-ascii?Q?TlZEVeNcRxT5anTO4pefxxgXHzxPZH1boHq3nOjAuMpw5V3WOim+oX9OJH4D?=
 =?us-ascii?Q?/9qHDL+6Pj7e5e0tgJuKCq0lxrEboRQemHsOtWI2ANWwpdpR+ryb4bFXFHrL?=
 =?us-ascii?Q?kCBQwDm0YQS/Xd+hYdkMf96WyYFVU8HQRlTU4ai9DcRG7U1Xd6TzEvlmjZ0x?=
 =?us-ascii?Q?cufCyJ9110gAfHnLGQMZRIbVWZwQN9Xgc0EIOjEhklvbuqkpRPg7tMRklXeT?=
 =?us-ascii?Q?yUD7RmVFRKvHWQdlt5/I0LdtEXvZjKfcbtIfoI/f361DUONBWcI+4ilidT7u?=
 =?us-ascii?Q?a7sWmclvfm3okSE072uhGgSbvN+3cyPGmgmEx8RVRUxHK8vP7pUN+fGJ6R9u?=
 =?us-ascii?Q?Nctji6ClIGhdJn1z9eNm0nLa0O86w+JQHSvBcbHl+nGwoysF8NAkZbnGLvg0?=
 =?us-ascii?Q?82xH8kUDW6yxRXNzlwFQWKKFcIjSRVohJaWtW2uq?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: d2ae3721-c6c3-4d67-4187-08db77f77483
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 16:48:09.9770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 82XRRMvJiOfOF1JAn90ln4BojWhjDfojOlzlPHkiUVqTlFiG6J64yHqg7Lg/b7d0UPSoIX7/NprEfq7+JBo+ZA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP265MB5404
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 28 Jun 2023 11:41:59 +0000
Benno Lossin <benno.lossin@proton.me> wrote:

> On 25.06.23 22:54, Gary Guo wrote:
> > On Sat, 24 Jun 2023 09:25:10 +0000
> > Benno Lossin <benno.lossin@proton.me> wrote:
> >   
> >> Use hygienic identifiers for the guards instead of the field names. This
> >> makes the init macros feel more like normal struct initializers, since
> >> assigning identifiers with the name of a field does not create
> >> conflicts.
> >> Also change the internals of the guards, no need to make the `forget`
> >> function `unsafe`, since users cannot access the guards anyways. Now the
> >> guards are carried directly on the stack and have no extra `Cell<bool>`
> >> field that marks if they have been forgotten or not, instead they are
> >> just forgotten via `mem::forget`.  
> > 
> > The code LGTM, so:
> > 
> > Reviewed-by: Gary Guo <gary@garyguo.net>
> > 
> > Although this will cause the new expansion we have to be no longer
> > compatible with a totally-proc-macro impl, if we want to do everything
> > in proc macro in the future.
> > 
> > If we have the paste macro upstream (
> > https://github.com/nbdd0121/linux/commit/fff00461b0be7fd3ec218dcc428f25886b5ec04a
> > ) then we can replace the `guard` with `paste!([<$field>])` and keep
> > the expansion identical.
> >   
> 
> I tried it and it seems to work, but I am not sure why the hygiene is
> set correctly. Could you maybe explain why this works?
> ```
>         $crate::__internal::paste!{
>             let [<$field>] = unsafe {
>                 $crate::__internal::DropGuard::new(::core::ptr::addr_of_mut!((*$slot).$field))
>             };
>             $crate::__init_internal!(init_slot($use_data):
>                 @data($data),
>                 @slot($slot),
>                 @guards([<$field>], $($guards,)*),
>                 @munch_fields($($rest)*),
>             );
>         }
> ```
> 
> i.e. why can't a user access the guard? I think it is because the hygiene of the `[<>]`
> is used, but not sure why that works.

Yes, by default the hygiene of pasted macro is that of the group,
unless explicitly overriden.

Best,
Gary