Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19573294rwd; Wed, 28 Jun 2023 11:02:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5pq/o/hlbFybZj9guzKPQEBStKg18fuSSeqGT65cNQJ9h6fAdetLDFJvSgkSRJ1VshJ11F X-Received: by 2002:a17:90a:e10a:b0:262:ec7f:af82 with SMTP id c10-20020a17090ae10a00b00262ec7faf82mr9147011pjz.22.1687975370483; Wed, 28 Jun 2023 11:02:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687975370; cv=none; d=google.com; s=arc-20160816; b=o/OlyLf7ye16xk9vUB2hdddLhA6nlafrRqOgNAmBRmKa8TWoS783t1R3sG10LX90+D 3U0tlVtPQ0aYhAUi2yqrSW5oedaE8CZiDbqzXCKRgTxYjPCD4pY3DvACAoaUiIPYpQRq lHCimHOYVBck7uVwzAId7fhO9Tm13P5KOJtwvVx33KIcsLbuy7F23YZ+Ig3mWA2YAoYB TVdBkNaCzfwykKdLFdRFeJWx5NhFQIJEsIlkkLYzQH2GhqRDiipF5s/ReXE8igljoq8n ieHTXGOwRnaw4scICjpNRPh631p+ZXy6CG8AAvovlsWLW0UG31MMXGXcpcSuXQSo5x49 QHlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Na6wbo2C6aZoJR9rArIrRD0H3fmD8LNX5u5EBRrSJvE=; fh=5yL09K6F0Hd/UtJACofEOgWhdxL6HY6hj5Tu+5Ttu60=; b=W/NMrbv2MmK1AomyGagCz8c3nXCuzrtfPQzvDFsgcQiBivctVIOy+IEJq8m7t361JM 35cR6IcGcsNORTw2DTCHDZIDzj7achSkdRubKNO1g+07bzExH7MWNW84uExwiPoi8N5x 7YqAKH0ZUhYwUIWOJOiTfoGe9C3Bebj3PmuwbRKuBggg1A/8eFBgnQQ0S0Kvk2UGDfMT xaZGBawA8xJ4nsDLn28lR0hXfBkRPPiB8c/S6CeG6TgHKcvhwDMVbJqq+BShndBDMYDj 7rcwF3AFrI/yUOGl/yP5v4/uoiB5cvLIyov2JmXmTR3YMTEOeBMb5vmL7fCl3bhV3NI7 wFaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G2QAokd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c4-20020a17090a8d0400b0025691c00096si9390284pjo.140.2023.06.28.11.02.30; Wed, 28 Jun 2023 11:02:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=G2QAokd6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbjF1Rvj (ORCPT + 99 others); Wed, 28 Jun 2023 13:51:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbjF1Rvg (ORCPT ); Wed, 28 Jun 2023 13:51:36 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 929472127 for ; Wed, 28 Jun 2023 10:51:35 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b80f2e6c17so1709395ad.0 for ; Wed, 28 Jun 2023 10:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1687974695; x=1690566695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Na6wbo2C6aZoJR9rArIrRD0H3fmD8LNX5u5EBRrSJvE=; b=G2QAokd6dY2PkUi0fC/2DH4ukUqdVpFiSHyylIErz3gCFT0crmjp97kh25QtX6+s/K MuDZqV4Hnfw3KTp0bTlR9Q1r+lsC5KlyDY6S4AAjpD14iV/pFM5niWN4wb3N3bssDfH+ Pcl0yjndBA+V2yrpVGiONXHAwPfdCUF9hgu2M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687974695; x=1690566695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Na6wbo2C6aZoJR9rArIrRD0H3fmD8LNX5u5EBRrSJvE=; b=S+UEgIantkbE3DKLG3kHH8KuGYYRgbZaPucYqaytPPqQkAXJ9ayLQngwdgx9FzGRj1 peYtUu2Wy+JrnHij76wtK+Tdw6QFgcNoEMGnXDM6PfhwEyhCYBZLOSRKiRe6cNIl4ENQ mb2WGeNiMuYf5iJxar/9JJTikLif1bA4QxlfnG4P5rTNtsLNZxrfr4vXFUznsqKDud8M BfOYkdm4hms3EZ7llLGfMh5iCfTNrDrjRY5WalJIUF/hKGB6EwLXcKSgC6pXrysWC9e4 Jqcgep/DpPh06E+msygBwd+q8CAMajlqsr+b4PE5g8BhXvaM5/KsV9P3QLgrIdGwx7Of SsLw== X-Gm-Message-State: AC+VfDw105eyBY3OYQTAPujQJoCGxVGLnH6U6CZcigglrEGTi4bfe+ex +PK/+NaO7tcr610YZH9D+7MI8b3sDPsqDytGsGc= X-Received: by 2002:a17:903:24d:b0:1b6:9b38:6004 with SMTP id j13-20020a170903024d00b001b69b386004mr16700746plh.22.1687974695060; Wed, 28 Jun 2023 10:51:35 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l13-20020a170902f68d00b001b843593e48sm1326552plg.228.2023.06.28.10.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 10:51:33 -0700 (PDT) From: Kees Cook To: Alasdair Kergon , Mike Snitzer , Matthias Kaehlcke Cc: Kees Cook , dm-devel@redhat.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] dm: verity-loadpin: Add NULL pointer check for 'bdev' parameter Date: Wed, 28 Jun 2023 10:51:29 -0700 Message-Id: <168797468756.1160226.11804940754677813929.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230627202800.1.Id63f7f59536d20f1ab83e1abdc1fda1471c7d031@changeid> References: <20230627202800.1.Id63f7f59536d20f1ab83e1abdc1fda1471c7d031@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Jun 2023 20:28:01 +0000, Matthias Kaehlcke wrote: > Add a NULL check for the 'bdev' parameter of > dm_verity_loadpin_is_bdev_trusted(). The function is called > by loadpin_check(), which passes the block device that > corresponds to the super block of the file system from which > a file is being loaded. Generally a super_block structure has > an associated block device, however that is not always the > case (e.g. tmpfs). > > [...] Applied, thanks! [1/1] dm: verity-loadpin: Add NULL pointer check for 'bdev' parameter https://git.kernel.org/kees/c/47f04616f2c9 Best regards, -- Kees Cook