Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp19603008rwd; Wed, 28 Jun 2023 11:25:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6WvziW8XpNZ4sLZvDAdb3op5b5s+6+iV+x7kFQLr/Xt0n5qDevjbjJtYoC8xt5/nOn14IM X-Received: by 2002:aa7:cb47:0:b0:51d:9130:3c54 with SMTP id w7-20020aa7cb47000000b0051d91303c54mr6577662edt.26.1687976739901; Wed, 28 Jun 2023 11:25:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687976739; cv=none; d=google.com; s=arc-20160816; b=kOmkLIM6fNgMUoxgMypI2Fh7fx8/kITKwBaFFLBDyfw7vmyxAiz0/N2gf00SUZ93Xk Be4jldGxkAZ212VikkgvI9phLhWL+aj9fShzNVGHwHmEGYOADKZi7r8MhulgzBiPWsoq N2W09T79aDkwooLVseFBASDKIXyNyjUrm//+B9kuVzhW+ADuyrTVtWxOZx+JUmwICsUC IBcAHSbY2xVjkZHpm50Nah4mbMjXKjMjd8dLIvMVwgAa/DjxkPCuxLdCuK0LUMoIH/PI 6YVWxQ/A4iPhDF46bPr90F9ASaUUr4ZqSOgW5PighQCaNvxsT6PzGctIa16KQjAHXLRY wccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Fxsg0bWVMoy2RClbdWsS0ch/7JCeZCdsAq6dsuXvkJs=; fh=EDqS7TtxB6PJk72pIXdNdOPlMipSKwKNrKidhF+9NtQ=; b=wW4I5e5jPJ7aG4M6C0+ioIhqoIyfj1MzXwVqwXpDe7fPSAkQOl+RTTXazFwtISncuw pDL0rKZN733NiLJMlqylC4ZJo+qHamo1YCx5e0eCmdMQFMyjCdjBwpXK2R6hp30p9ZUr 6BKZlUPrWxVCzLQ5rwikdzAI3BZ6RatxaZYddrAnNZN1lQrBzhNghluBdhi+hbSJbNWm nhUmfkzAKSZ3+aMqml3zel9F3ggtM1Uv/xamZWN6Nc71GFFgw2IGGb43l3UPZrRy++jF FXFlBqacZeeuuDnZLgykDdXTOoXmsvZTwoJXOYeiFOlHL2ktc7qM6FzGI06r4mjxZkyn jQ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Xl5IPOjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n26-20020a056402061a00b0051bdd97e331si5375176edv.661.2023.06.28.11.25.15; Wed, 28 Jun 2023 11:25:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Xl5IPOjH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230523AbjF1SKZ (ORCPT + 99 others); Wed, 28 Jun 2023 14:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjF1SKX (ORCPT ); Wed, 28 Jun 2023 14:10:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93CCB10D8 for ; Wed, 28 Jun 2023 11:10:22 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 29AD36137F for ; Wed, 28 Jun 2023 18:10:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EA31C433C8; Wed, 28 Jun 2023 18:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687975821; bh=mRw+zSjf9GVtwo3Ud86Z4s79jqjy9EQmP9Bk+yry79A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Xl5IPOjHQkFkteFmgywK0YHyez1XmlRv472aammeiNpNloRidnxLudrm8amkVjY80 ghvB49te5naUnLaUpzaakeQsuO6SSZHRWtZkLV36FyGmkdylV5pTXA2zPbNNjaB9N1 1+TN1te5e+WOGkViNY8rkqx2xOVAWZtKl99z8KlbqPMamqRINyT3yBETdljldChXvK RwWTFmC2jUgRn/7fh0VfdpQkqvoAWecD5nB4Df/1PlO6bEgbM8b8bCFykQvfEJxx4N k48wxinIXNh9NmEyV3ww3D1LAJVKcHG9V+dgzJs73Ceq369EmMQ5SGY/HVI0LIKY8v Ko7/OTESN2ELA== Date: Wed, 28 Jun 2023 11:10:19 -0700 From: Josh Poimboeuf To: Michal Kubecek Cc: Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: build failure after commit eb0481bbc4ce ("objtool: Fix reloc_hash size") Message-ID: <20230628181019.cmgfbygxfvwamzur@treble> References: <20230628115825.ahqejf5y4hgxhyqj@lion.mk-sys.cz> <20230628151654.zqwy5zsc2cymqghr@treble> <20230628154432.4drtq4pivlkkg6v2@lion.mk-sys.cz> <20230628160631.ryt4icjeck627efs@lion.mk-sys.cz> <20230628164554.womrvwq7chnjtva4@lion.mk-sys.cz> <20230628170530.derop5w2gtmgjeis@treble> <20230628172659.6qwbswgz4ki24wyv@lion.mk-sys.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230628172659.6qwbswgz4ki24wyv@lion.mk-sys.cz> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2023 at 07:26:59PM +0200, Michal Kubecek wrote: > I digged some more and my guess is that the problem is that > elf_open_read() does > > memset(elf, 0, offsetof(struct elf, sections)); > > but commit eb0481bbc4ce ("objtool: Fix reloc_hash size") added > num_relocs after sections so that it is not zeroed (0xbabababababababa > is probably some kind of poison). Argh, that memset() is subtle as heck. Peter, why?!? -- Josh