Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ankit Agrawal <ankita@nvidia.com>
To:     Jason Gunthorpe <jgg@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>
CC:     Aniket Agashe <aniketa@nvidia.com>, Neo Jia <cjia@nvidia.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        "Tarun Gupta (SW-GPU)" <targupta@nvidia.com>,
        Vikram Sethi <vsethi@nvidia.com>,
        Andy Currid <ACurrid@nvidia.com>,
        Alistair Popple <apopple@nvidia.com>,
        John Hubbard <jhubbard@nvidia.com>,
        Dan Williams <danw@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Thread-Topic: [PATCH v4 1/1] vfio/nvgpu: Add vfio pci variant module for grace
 hopper
Thread-Index: AQHZpLaxSTuRkhXihUusFX/7jkP6ra+YYxiAgATjz4CAAASmgIADTv3w
Date:   Wed, 28 Jun 2023 19:00:53 +0000
Message-ID: <BY5PR12MB3763EC8E078A5C43FEBEF050B024A@BY5PR12MB3763.namprd12.prod.outlook.com>
References: <20230622030720.19652-1-ankita@nvidia.com>
 <ZJWdbbNESp1+6GVN@nvidia.com>
 <20230626100629.3c318922.alex.williamson@redhat.com>
 <ZJm7a1BpeLmQQ5Mj@nvidia.com>
In-Reply-To: <ZJm7a1BpeLmQQ5Mj@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QabwE7h9vsMEneh+s02vzquta4Sj8njtSMLfttHziGXGQCzUEqZg45cINaYe?=
 =?us-ascii?Q?fWHTMHMB1JHiwvhd5hCaLFaHyOTlpXMID2nSUWh+6ZowJyqmnJZqJ2lzJT04?=
 =?us-ascii?Q?z1ntuAlFLTUUo1ur7B05OBUsWJunJbe1JP9ToVs+bb2D0a93LO6NLAwFSpVm?=
 =?us-ascii?Q?/NxkjbjC8xLWSHezV9tjFebrtMm5Zp8TiFSLt4ut4ZBFT1fSs4rbinYSzrjl?=
 =?us-ascii?Q?jSdS9R9l88srtLLQ5oP0CI5BC6YLlrAbQD2UlMTC61xRiVpQFrrt7/RNhJ/4?=
 =?us-ascii?Q?L/4Thd3bu2UOsG8QCm13VcZPuz8BbDGIa846vXSHYPYa6AjN59ZFoe/GVgHN?=
 =?us-ascii?Q?OvTQasqLMtBpaOA3wgMlXMQvDrfOJ9fFWeYM6v49S6D7IYeNWEnROlfPVP3k?=
 =?us-ascii?Q?Of986s+yoYPCwpqLW4MphUNz2PPA/n0F/CjwwS+lAw1Epm2tWXJPy6wwMWjV?=
 =?us-ascii?Q?dTBZG/OsUpjX4UYU+DsELVL9WjtR4gC5FxUL4qE7QZnZ+VZjX1Phgd8qBmv2?=
 =?us-ascii?Q?rUSZWqRJKw6w2g/U/8D58aAVjx5ZdGPkLWHlJVpEyKN+OTC/qOON2sqGpRay?=
 =?us-ascii?Q?hnk9XFXFmooOYH6u+5BP+PCd90xW0Q3tdMEA16a+cQLcxjAbf/IYr3XrGwyJ?=
 =?us-ascii?Q?mBX0SYXZU6yERoxynOsaoAYVAhrlVR2fW1uVHdmICbk4IcOvTNvCbXpQ6lDz?=
 =?us-ascii?Q?k/VlmrMFH55Mt3YI95dxTklP8O6AxJn3r3C4KdG/bXIw3NYP7/N+Kmm7tGpl?=
 =?us-ascii?Q?GQiMiBA7ciMX3MDu0Xl0LVr1oKbP5F2GaQhjNB9R0eI800Huj4PQdaX6NJfb?=
 =?us-ascii?Q?f+9bHK5td+zJzAbkLQWh/1rDKHGhLdQlD23ceEYK1kef3hq541bRKeX/D1Ze?=
 =?us-ascii?Q?E+4m6ds2kL6fyqs2pxXaC6N6gju79gAeXQXlbY5O1q7m+UnNQpZ+m34yooGC?=
 =?us-ascii?Q?VTAStAXtngTPFB86fOGLpEVOGSFv8qm2Dpdp0ocBUYPoi9Ri5vXlkRw3O6Yi?=
 =?us-ascii?Q?mQYb0kkD2JU6zW1PNzcxfliWeXB7da8zeb9VoOUF19/8nh3tCsiq7oIO6QsQ?=
 =?us-ascii?Q?fx6kXCsh0sI2Mn8dQm8M04zjbEu/W+Hp49hCufFV6RWVFxSoAsGeSP+WUbl9?=
 =?us-ascii?Q?nymgfD1zcn/gIf2VammIGZLCDV/zLoUtBMR+9B+s4EzoLoSiBR+lLEku21Gg?=
 =?us-ascii?Q?MgwUB7TQE6OGxhoT9mPQUevFPZlR5hFimDil/b8IQseJp+rFO95wscWWz25T?=
 =?us-ascii?Q?48ujoCw/YmeLIa7coeRgyGXFj7Ps6x2oMD/NDDMDROpVpwRkjhafeJdAQRI1?=
 =?us-ascii?Q?V82yD7673ax0/AHQxXNC7eu+3vfPjamxx8GIaag9VXRkjFRZlgNneRmBxisF?=
 =?us-ascii?Q?Um2aOhV60SD6yJOak3+beqjxWqs2+YCRiSxrcd4ubBuse3Db7wJUw0S1gt1z?=
 =?us-ascii?Q?ZzHQJ9RjappxrAgx3TZoWBAaPe1p1Sd7t6qnS2lkkF+298SmRe56HMViZo+B?=
 =?us-ascii?Q?UU7ywP1Kj7su+bzNiSp2bRrDlI65UVVDecQTIcfrGiSgDv08B7ZCk6jmi9iq?=
 =?us-ascii?Q?84r35MQBuilDw6i9OKVuLWwY15Xy8ZlDzloDAAub?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3763.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: faef47ce-7250-42b3-57bb-08db7809ff88
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jun 2023 19:00:54.0205
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0G7jq+XNtg042+bc+qfkc/Xp0eblSourAjZ39DxtLUcWg7rI54AFmTtKCyu5L9WVFKOpMEi7bWNNsOEOPHW5QA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7809
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>> +static ssize_t nvgpu_vfio_pci_read(struct vfio_device *core_vdev,
>>> +           char __user *buf, size_t count, loff_t *ppos) {
>>> +   unsigned int index =3D VFIO_PCI_OFFSET_TO_INDEX(*ppos);
>>> +
>>> +   /*
>>> +    * Only the device memory present on the hardware is mapped, which =
may
>>> +    * not be power-of-2 aligned. A read to the BAR2 region implies an
>>> +    * access outside the available device memory on the hardware.
>>> +    */
>>> +   if (index =3D=3D VFIO_PCI_BAR2_REGION_INDEX)
>>> +           return -EINVAL;
>>>
>> What does the qemu do in this case? Crash the VM?
>
> Yes, I don't think return -errno matches what we discussed for returning =
-1 on read and dropping writes outside of the device memory.

I tried to replicate what is done by vfio-pci core module in vfio_pci_bar_r=
w()
where -EINVAL is returned in case of e.g. the access offset is outside the
BAR range.

Such an error comes to Qemu in vfio_region_read/vfio_region_write() which=20
handles the error by returning data as -1 on read and dropping on write.

But it seems that we don't need such approach here. I will make the change
so that vfio-pci variant driver's read/write explicitly reads -1 and drops =
writes
instead of returning -EINVAL.