Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <CAHk-=wie=MvQzmjhKGCCbRapK3Zz-b8GFUchEDJi7SkeLAX6Pw@mail.gmail.com>
References: <CAHk-=wie=MvQzmjhKGCCbRapK3Zz-b8GFUchEDJi7SkeLAX6Pw@mail.gmail.com> <20230626085035.e66992e96b4c6d37dad54bd9@linux-foundation.org> <CAHk-=wjyJyV=Kyb8XJcLjFEPP-RMF0J6CQfT2OXLmJdM2yEv8w@mail.gmail.com>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     dhowells@redhat.com, Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-mm@kvack.org,
        mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MM updates for 6.5-rc1
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3696803.1687979912.1@warthog.procyon.org.uk>
Date:   Wed, 28 Jun 2023 20:18:32 +0100
Message-ID: <3696804.1687979912@warthog.procyon.org.uk>
Precedence: bulk

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Side note: I think we should just do the "FOLL_GET" doesn't touch the
> refcount either, which would make this all become just

Yeah... but there's a lot of places that would potentially need fixing.
iov_iter_get_pages*(), for example, is used to grab pages and push them to all
sorts of destinations, including pipes and sk_buffs.

> but then we would need to fix try_grab_page() and gup_put_folio() and
> friends to match. And any other cases I haven't thought of.

And put_page(), folio_put(), ...  I wonder if there would be a noticeable
performance loss from adding an is_zero_page() check into those.

It might also make sense to include the entire kernel post-init static image
in that, perhaps a check:

	if ((unsigned long)(virt_address) & KERNEL_MASK == KERNEL_BASE)
		return;

David